|
| 1 | +# Gemini CLI Context for sdk-platform-java |
| 2 | + |
| 3 | +## 1. Overview |
| 4 | + |
| 5 | +This repository, `sdk-platform-java`, is a monorepo containing the foundational components for building Java client libraries for Google Cloud Platform services. It includes the GAPIC (Generated API Client) generator for Java, the GAX (Google API Extensions) runtime library, and other shared modules. |
| 6 | + |
| 7 | +## 2. Project Structure |
| 8 | + |
| 9 | +The repository is structured into several key modules: |
| 10 | + |
| 11 | +* **`gapic-generator-java`**: The core component for creating new client libraries. It is a Protobuf compiler plugin that generates Java client libraries from API definition files. The `DEVELOPMENT.md` file in this module provides detailed information on how to work with the generator. |
| 12 | + |
| 13 | +* **`gax-java`**: The Google API Extensions for Java (GAX) library. It provides runtime support for the generated client libraries, including features like pagination, request batching, and polling of long-running operations. It has the following submodules: |
| 14 | + * `gax`: Transport-independent part of GAX for Java. |
| 15 | + * `gax-grpc`: gRPC-specific logic for GAX. |
| 16 | + * `gax-httpjson`: REST-specific logic for GAX. |
| 17 | + |
| 18 | +* **`api-common-java`**: Contains foundational types and utilities related to Google APIs. It includes the following packages: |
| 19 | + * `core`: Core library containing API stability annotations and wrappers around Guava types. |
| 20 | + * `pathtemplate`: Path Template library for manipulating strings that are formatted as Google API resource names. |
| 21 | + * `resourcenames`: Resource Name library used by generated resource name types. |
| 22 | + |
| 23 | +* **`java-common-protos`**: Provides Protobuf-generated classes for common Google services that are used across multiple APIs. The code is in this module is auto-generated and should not be modified. |
| 24 | + |
| 25 | +* **`java-iam`**: Contains Protobuf-generated classes for Google's Identity and Access Management (IAM) service, used for managing policies. The code is in this module is auto-generated and should not be modified. |
| 26 | + |
| 27 | +* **`java-showcase`**: A demonstration client library for the "Showcase" API, which is a fake API used for integration testing of the GAPIC generator and GAX library. |
| 28 | + |
| 29 | +* **`java-shared-dependencies`**: Manages shared Maven dependencies for all Google Cloud Java client libraries. This ensures consistency and helps avoid dependency conflicts. |
| 30 | + |
| 31 | +## 3. Getting Started |
| 32 | + |
| 33 | +### 3.1. Prerequisites |
| 34 | + |
| 35 | +To build and work with this project, you will need to install: |
| 36 | + |
| 37 | +* Java 8+ |
| 38 | +* Maven |
| 39 | + |
| 40 | +### 3.2. Building the Project |
| 41 | + |
| 42 | +The project uses Maven for its primary build system. To build all modules, run the following command from the root of the repository: |
| 43 | + |
| 44 | +```sh |
| 45 | +mvn install |
| 46 | +``` |
| 47 | + |
| 48 | +### 3.3. Code Formatting |
| 49 | + |
| 50 | +Code formatting is enforced using the `fmt-maven-plugin`. To check for formatting issues, run: |
| 51 | + |
| 52 | +```sh |
| 53 | +mvn fmt:check |
| 54 | +``` |
| 55 | + |
| 56 | +To format the code, run: |
| 57 | + |
| 58 | +```sh |
| 59 | +mvn fmt:format |
| 60 | +``` |
| 61 | + |
| 62 | +## 4. Testing |
| 63 | + |
| 64 | +### 4.1. Testing Strategy |
| 65 | + |
| 66 | +The repository employs a multi-layered testing strategy to ensure the quality and correctness of the generated code: |
| 67 | + |
| 68 | +* **Unit Tests:** Traditional unit tests for individual classes and methods. |
| 69 | +* **Golden Unit Tests:** These tests generate code from test protos and compare the output to "golden" files, which are pre-approved versions of the generated code. These test cases exist inside the `gapic-generator-java` module. |
| 70 | +* **Showcase Integration Tests:** These tests run the generated Showcase client against a local Showcase server to verify end-to-end functionality. This is the preferred way of testing integration tests. |
| 71 | +* **Golden Integration Tests:** These tests generate full client libraries for real Google Cloud APIs and compare them to golden versions. This is an older test strategy and showcase testing is preferred. |
| 72 | + |
| 73 | +Based on where the code changes are, we should add different tests, in general |
| 74 | + |
| 75 | +* If the changes are in `gax` or `api-common` only, you _must_ add traditional unit tests, you _may_ add showcase integration tests if you are modifying a public setting. |
| 76 | +* If the changes are in `gapic-generator-java` only, showcase integration tests are most likely not needed |
| 77 | + * If they are in the `composer` module, you _must_ add golden unit tests, you _may_ add traditional unit tests for better coverage and easier testing. |
| 78 | + * If they are in the `parser` module, you _should_ add traditional unit tests with a test proto if possible, you _may_ add golden unit tests to easily see the changes. For example, [routing_rule_parser_testing](https://github.com/googleapis/sdk-platform-java/blob/main/gapic-generator-java/src/test/proto/routing_rule_parser_testing.proto) that is only used for testing [RoutingRuleParser](https://github.com/googleapis/sdk-platform-java/blob/main/gapic-generator-java/src/main/java/com/google/api/generator/gapic/protoparser/RoutingRuleParser.java). |
| 79 | + * If they are in `other modules(ast, model, writer etc.)`, you _must_ add traditional unit tests, you _may_ add golden unit tests to easily see the changes. |
| 80 | +- If the changes are in both `gax` and `gapic-generator-java`, you _must_ add all test layers, including traditional unit tests, golden unit tests and showcase integration tests. |
| 81 | + |
| 82 | +### 4.2. Running Unit Tests |
| 83 | + |
| 84 | +Unit tests can be tested via this command: |
| 85 | + |
| 86 | +```sh |
| 87 | +mvn test |
| 88 | +``` |
| 89 | + |
| 90 | +### 4.3. Running Golden Integration Tests |
| 91 | + |
| 92 | +Golden integration tests are run using Bazel. To run all golden integration tests, use the following command from the root of the repository: |
| 93 | + |
| 94 | +```sh |
| 95 | +bazelisk test //... |
| 96 | +``` |
| 97 | + |
| 98 | +Specific integration tests can be run by specifying the target, for example: |
| 99 | + |
| 100 | +```sh |
| 101 | +bazelisk test //test/integration:redis |
| 102 | +``` |
| 103 | + |
| 104 | +### 4.4. Updating Golden Files |
| 105 | + |
| 106 | +If you make changes that affect the generated code, you will need to update the golden files. This can be done using the following command: |
| 107 | + |
| 108 | +```sh |
| 109 | +bazelisk run //test/integration:update_asset && bazelisk run //test/integration:update_credentials && bazelisk run //test/integration:update_iam && bazelisk run //test/integration:update_kms && bazelisk run //test/integration:update_pubsub && bazelisk run //test/integration:update_logging && bazelisk run //test/integration:update_redis && bazelisk run //test/integration:update_storage && bazelisk run //test/integration:update_library && bazelisk run //test/integration:update_compute && bazelisk run //test/integration:update_bigtable && bazelisk run //test/integration:update_apigeeconnect |
| 110 | +``` |
| 111 | + |
| 112 | +### 4.5. Running Showcase Integration Tests |
| 113 | + |
| 114 | +Showcase integration tests are run against a local server that implements the Showcase API. The `java-showcase/README.md` file provides detailed instructions on how to run these tests. The general steps are: |
| 115 | + |
| 116 | +1. **Install the Showcase server:** |
| 117 | + |
| 118 | + ```sh |
| 119 | + go install github.com/googleapis/gapic-showcase/cmd/gapic-showcase@latest |
| 120 | + ``` |
| 121 | + |
| 122 | +2. **Run the Showcase server:** |
| 123 | + |
| 124 | + ```sh |
| 125 | + gapic-showcase run |
| 126 | + ``` |
| 127 | + |
| 128 | +3. **Run the integration tests:** |
| 129 | + |
| 130 | + ```sh |
| 131 | + cd java-showcase |
| 132 | + mvn verify -P enable-integration-tests |
| 133 | + ``` |
| 134 | + |
| 135 | +## 5. Dependency Management |
| 136 | + |
| 137 | +- Try not to bump any external dependency version unless there is a known CVE (security or vulnerability issue) or a critical bug fix. |
| 138 | +- Try to avoid introducing new external dependencies. If a new dependency is required, please state the reason. |
| 139 | +- Prefer to use features from the Java standard library, then try to use features from any existing dependencies (preferably from Google managed dependencies). |
| 140 | + |
| 141 | +## 6. Contribution Guidelines |
| 142 | + |
| 143 | +- **Commits:** Commit messages should follow the [Conventional Commits](https://www.conventionalcommits.org/) |
| 144 | + specification. The format is `<type>: <description>`. The type should be one of the following: fix, feat, |
| 145 | + build, chore, docs, test, or refactor. |
| 146 | +- **Issues:** All significant changes should start with a GitHub issue. |
| 147 | +- **Pull Requests:** All code changes must be submitted via a pull request and require review. |
| 148 | +- **Testing:** All new logic should be accompanied by tests. |
| 149 | +- For more details, see `CONTRIBUTING.md`. |
0 commit comments