Commit 49cc63d
authored
chore: revert "ci: exclude internal/librariangen/** on unrelated checks" (#3960)
Reverts #3953. Due to the change, GitHub
Actions stopped running the checks while the checks are still marked as
required. Tried this in
#3959 (comment).
<img width="1742" height="1336" alt="image"
src="https://github.com/user-attachments/assets/513fb435-65a9-4841-b3ca-d79a00fe1687"
/>
The documentation about this GitHub Actions behavior is
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks
:
> If a workflow is skipped due to [path
filtering](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore),
[branch
filtering](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpull_requestpull_request_targetbranchesbranches-ignore)
or a [commit
message](https://docs.github.com/en/actions/managing-workflow-runs/skipping-workflow-runs),
then checks associated with that workflow will remain in a "Pending"
state. A pull request that requires those checks to be successful will
be blocked from merging.
>
> If, however, a job within a workflow is skipped due to a conditional,
it will report its status as "Success". For more information, see [Using
conditions to control job
execution](https://docs.github.com/en/actions/using-jobs/using-conditions-to-control-job-execution).
I didn't find usages of a file path filter in the condition of a job
within a workflow.
https://github.com/googleapis/sdk-platform-java/blob/main/.github/workflows/verify_library_generation.yaml#L8
is is a good example how to skip the main job
library-generation-unit-tests, by introducing the
should-run-library-generation-tests job.1 parent 2f6c75d commit 49cc63d
File tree
6 files changed
+0
-12
lines changed- .github/workflows
6 files changed
+0
-12
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
8 | 6 | | |
9 | 7 | | |
10 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | | - | |
9 | 7 | | |
10 | 8 | | |
11 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | | - | |
21 | 19 | | |
22 | 20 | | |
23 | 21 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
19 | | - | |
20 | 18 | | |
21 | 19 | | |
22 | 20 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | | - | |
10 | 8 | | |
11 | 9 | | |
12 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | 3 | | |
6 | 4 | | |
7 | 5 | | |
| |||
0 commit comments