Skip to content

Commit 49e3821

Browse files
committed
pass changed libraries to docker run
1 parent 67742a0 commit 49e3821

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

.github/scripts/hermetic_library_generation.sh

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,13 @@ pushd "${api_def_dir}"
9292
git checkout "${googleapis_commitish}"
9393
popd
9494

95+
# generate changed libraries
96+
changed_libraries=$(python hermetic_build/common/cli/changed_library_generation.py create \
97+
--baseline-generation-config-path="${baseline_generation_config}" \
98+
--current-generation-config-path="${generation_config}")
99+
100+
echo "Changed libraries are: ${changed_libraries}."
101+
95102
# run hermetic code generation docker image.
96103
docker run \
97104
--rm \
@@ -102,8 +109,8 @@ docker run \
102109
-v "${api_def_dir}:${workspace_name}/googleapis" \
103110
-e GENERATOR_VERSION="${image_tag}" \
104111
gcr.io/cloud-devrel-public-resources/java-library-generation:"${image_tag}" \
105-
--baseline-generation-config-path="${workspace_name}/${baseline_generation_config}" \
106-
--current-generation-config-path="${workspace_name}/${generation_config}" \
112+
--generation-config-path="${workspace_name}/${generation_config}" \
113+
--library-names="${changed_libraries}" \
107114
--api-definitions-path="${workspace_name}/googleapis"
108115

109116
python hermetic_build/release_note_generation/cli/generate_release_note.py generate \
File renamed without changes.

hermetic_build/common/tests/cli/config_change_unit_tests.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
from click.testing import CliRunner
1616
import unittest
1717

18-
from common.cli.config_change import create
18+
from common.cli.changed_library_generation import create
1919

2020
script_dir = os.path.dirname(os.path.realpath(__file__))
2121
test_resource_dir = os.path.join(script_dir, "..", "resources", "cli")

0 commit comments

Comments
 (0)