Skip to content

Commit 60cb67f

Browse files
authored
chore: remove google/shopping/type/types.proto when generating shopping APIs (#2554)
After #2553 is merged, we do not need to add `google/shopping/type/types.proto` in `generate_library.sh` as a special case.
1 parent 180c8a9 commit 60cb67f

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

library_generation/generate_library.sh

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -175,12 +175,6 @@ case "${proto_path}" in
175175
removed_proto="google/rpc/http.proto"
176176
proto_files="${proto_files//${removed_proto}/}"
177177
;;
178-
"google/shopping"*)
179-
# this proto is included in //google/shopping/css/v1:google-cloud-shopping-css-v1-java
180-
# and //google/shopping/merchant/inventories/v1beta:google-cloud-merchant-inventories-v1beta-java
181-
# and //google/shopping/merchant/reports/v1beta:google-cloud-merchant-reports-v1beta-java
182-
proto_files="${proto_files} google/shopping/type/types.proto"
183-
;;
184178
esac
185179
# download gapic-generator-java, protobuf and grpc plugin.
186180
download_tools "${gapic_generator_version}" "${protobuf_version}" "${grpc_version}" "${os_architecture}"
@@ -284,8 +278,7 @@ case "${proto_path}" in
284278
esac
285279
# copy proto files to proto-*/src/main/proto
286280
for proto_src in ${proto_files}; do
287-
if [[ "${proto_src}" == "google/cloud/common/operation_metadata.proto" ]] ||
288-
[[ "${proto_src}" == "google/shopping/type/types.proto" ]]; then
281+
if [[ "${proto_src}" == "google/cloud/common/operation_metadata.proto" ]]; then
289282
continue
290283
fi
291284
mkdir -p "${temp_destination_path}/proto-${folder_name}/src/main/proto"

0 commit comments

Comments
 (0)