Skip to content

Commit 67be17c

Browse files
chore: merge main into generate-libraries-main
2 parents 53f06af + 5ec5040 commit 67be17c

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,12 @@ target/
1313
*.vim
1414

1515
# Vscode Settings
16-
.vscode/settings.json
16+
.vscode
1717

1818
# Python
1919
**/__pycache__/
2020
.venv
21+
.python-version
2122

2223
# library generation
2324
**/googleapis

java-showcase/gapic-showcase/pom.xml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@
1818

1919
<properties>
2020
<gapic-showcase.version>0.36.2</gapic-showcase.version>
21+
<!-- This is the last version supporting slf4j 1.x, do not upgrade -->
2122
<slf4j1-logback.version>1.2.13</slf4j1-logback.version>
23+
<slf4j2-logback.version>1.5.21</slf4j2-logback.version>
2224
</properties>
2325

2426
<build>
@@ -244,13 +246,13 @@
244246
<dependency>
245247
<groupId>ch.qos.logback</groupId>
246248
<artifactId>logback-classic</artifactId>
247-
<version>1.5.16</version>
249+
<version>${slf4j2-logback.version}</version>
248250
<scope>test</scope>
249251
</dependency>
250252
<dependency>
251253
<groupId>ch.qos.logback</groupId>
252254
<artifactId>logback-core</artifactId>
253-
<version>1.5.16</version>
255+
<version>${slf4j2-logback.version}</version>
254256
<scope>test</scope>
255257
</dependency>
256258
</dependencies>
@@ -333,13 +335,13 @@
333335
<dependency>
334336
<groupId>ch.qos.logback</groupId>
335337
<artifactId>logback-classic</artifactId>
336-
<version>1.2.13</version>
338+
<version>${slf4j1-logback.version}</version>
337339
<scope>test</scope>
338340
</dependency>
339341
<dependency>
340342
<groupId>ch.qos.logback</groupId>
341343
<artifactId>logback-core</artifactId>
342-
<version>1.3.15</version>
344+
<version>${slf4j1-logback.version}</version>
343345
<scope>test</scope>
344346
</dependency>
345347
</dependencies>

0 commit comments

Comments
 (0)