Skip to content

Commit 7515a7c

Browse files
committed
chore: Add comments for the showcase test
1 parent 64ecb32 commit 7515a7c

File tree

1 file changed

+3
-1
lines changed
  • java-showcase/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it

1 file changed

+3
-1
lines changed

java-showcase/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/ITOtelMetrics.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -865,7 +865,7 @@ void grpcOpenTelemetryImplementation_setSampledToLocalTracing_methodFullNameIsRe
865865

866866
GrpcOpenTelemetry grpcOpenTelemetry = GrpcOpenTelemetry.newBuilder().sdk(openTelemetry).build();
867867

868-
// Java-Spanner configures the gRPCTransportChannelProvider with gRPCOpenTelemetry
868+
// Java-Spanner configures the InstantiatingGrpcChannelProvider with gRPCOpenTelemetry
869869
// This setup below is copied from their implementation
870870
InstantiatingGrpcChannelProvider.Builder builder =
871871
EchoSettings.defaultGrpcTransportProviderBuilder();
@@ -909,6 +909,8 @@ void grpcOpenTelemetryImplementation_setSampledToLocalTracing_methodFullNameIsRe
909909
for (PointData pointData : pointDataList) {
910910
String methodName =
911911
pointData.getAttributes().get(AttributeKey.stringKey(grpcMethodNameAttributeKey));
912+
913+
// All the attributes in the gRPC metrics should have the full method name
912914
Truth.assertThat(methodName).doesNotMatch("other");
913915
Truth.assertThat(methodName).matches("^google.showcase.v1beta1.Echo/.*$");
914916
}

0 commit comments

Comments
 (0)