Skip to content

Commit 791ab2c

Browse files
committed
don't propogate endpointContext.
1 parent 30ff3d6 commit 791ab2c

File tree

11 files changed

+49
-116
lines changed

11 files changed

+49
-116
lines changed

gax-java/gax-grpc/src/main/java/com/google/api/gax/grpc/InstantiatingGrpcChannelProvider.java

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
import com.google.api.core.InternalApi;
3838
import com.google.api.core.ObsoleteApi;
3939
import com.google.api.gax.core.ExecutorProvider;
40-
import com.google.api.gax.rpc.EndpointContext;
4140
import com.google.api.gax.rpc.FixedHeaderProvider;
4241
import com.google.api.gax.rpc.HeaderProvider;
4342
import com.google.api.gax.rpc.TransportChannel;
@@ -122,7 +121,7 @@ public final class InstantiatingGrpcChannelProvider implements TransportChannelP
122121
private final int processorCount;
123122
private final Executor executor;
124123
private final HeaderProvider headerProvider;
125-
private final EndpointContext endpointContext;
124+
private final boolean useS2A;
126125
private final String endpoint;
127126
// TODO: remove. envProvider currently provides DirectPath environment variable, and is only used
128127
// during initial rollout for DirectPath. This provider will be removed once the DirectPath
@@ -152,7 +151,7 @@ private InstantiatingGrpcChannelProvider(Builder builder) {
152151
this.executor = builder.executor;
153152
this.headerProvider = builder.headerProvider;
154153
this.endpoint = builder.endpoint;
155-
this.endpointContext = builder.endpointContext;
154+
this.useS2A = builder.useS2A;
156155
this.mtlsProvider = builder.mtlsProvider;
157156
this.envProvider = builder.envProvider;
158157
this.interceptorProvider = builder.interceptorProvider;
@@ -243,14 +242,14 @@ public TransportChannelProvider withEndpoint(String endpoint) {
243242
}
244243

245244
/**
246-
* Specify the {@link EndpointContext}.
245+
* Specify whether or not to use S2A.
247246
*
248-
* @param endpointContext
249-
* @return A new {@link InstantiatingGrpcChannelProvider} with the endpointContext
247+
* @param useS2A
248+
* @return A new {@link InstantiatingGrpcChannelProvider} with useS2A set.
250249
*/
251250
@Override
252-
public TransportChannelProvider withEndpointContext(EndpointContext endpointContext) {
253-
return toBuilder().setEndpointContext(endpointContext).build();
251+
public TransportChannelProvider withUseS2A(boolean useS2A) {
252+
return toBuilder().setUseS2A(useS2A).build();
254253
}
255254

256255
/** @deprecated Please modify pool settings via {@link #toBuilder()} */
@@ -586,12 +585,13 @@ private ManagedChannel createSingleChannel() throws IOException {
586585
// Could not create channel credentials via DCA. In accordance with
587586
// https://google.aip.dev/auth/4115, if credentials not available through
588587
// DCA, try mTLS with credentials held by the S2A (Secure Session Agent).
589-
if (endpointContext.useS2A()) {
588+
if (useS2A) {
590589
channelCredentials = createS2ASecuredChannelCredentials();
591590
}
592591
if (channelCredentials != null) {
593592
// Create the channel using S2A-secured channel credentials.
594-
builder = Grpc.newChannelBuilder(endpointContext.mtlsEndpoint(), channelCredentials);
593+
// {@code endpoint} is set to mtlsEndpoint in {@link EndpointContext} when useS2A is true.
594+
builder = Grpc.newChannelBuilder(endpoint, channelCredentials);
595595
} else {
596596
// Use default if we cannot initialize channel credentials via DCA or S2A.
597597
builder = ManagedChannelBuilder.forAddress(serviceAddress, port);
@@ -743,7 +743,7 @@ public static final class Builder {
743743
private Executor executor;
744744
private HeaderProvider headerProvider;
745745
private String endpoint;
746-
private EndpointContext endpointContext;
746+
private boolean useS2A;
747747
private EnvironmentProvider envProvider;
748748
private MtlsProvider mtlsProvider = new MtlsProvider();
749749
@Nullable private GrpcInterceptorProvider interceptorProvider;
@@ -772,7 +772,7 @@ private Builder(InstantiatingGrpcChannelProvider provider) {
772772
this.executor = provider.executor;
773773
this.headerProvider = provider.headerProvider;
774774
this.endpoint = provider.endpoint;
775-
this.endpointContext = provider.endpointContext;
775+
this.useS2A = provider.useS2A;
776776
this.envProvider = provider.envProvider;
777777
this.interceptorProvider = provider.interceptorProvider;
778778
this.maxInboundMessageSize = provider.maxInboundMessageSize;
@@ -841,8 +841,8 @@ public Builder setEndpoint(String endpoint) {
841841
return this;
842842
}
843843

844-
Builder setEndpointContext(EndpointContext endpointContext) {
845-
this.endpointContext = endpointContext;
844+
Builder setUseS2A(boolean useS2A) {
845+
this.useS2A = useS2A;
846846
return this;
847847
}
848848

gax-java/gax-grpc/src/test/java/com/google/api/gax/grpc/GrpcLongRunningTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ void setUp() throws IOException {
101101
TransportChannel transportChannel =
102102
GrpcTransportChannel.newBuilder().setManagedChannel(channel).build();
103103
when(operationsChannelProvider.getTransportChannel()).thenReturn(transportChannel);
104-
when(operationsChannelProvider.withEndpointContext(Mockito.any(EndpointContext.class)))
104+
when(operationsChannelProvider.withUseS2A(Mockito.any(boolean.class)))
105105
.thenReturn(operationsChannelProvider);
106106

107107
clock = new FakeApiClock(0L);

0 commit comments

Comments
 (0)