Skip to content

Commit 7991a91

Browse files
committed
chore: Update generator to generate Message
1 parent a98bdfc commit 7991a91

File tree

6 files changed

+25
-34
lines changed

6 files changed

+25
-34
lines changed

gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/grpc/MockServiceClassComposer.java

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
import com.google.api.generator.gapic.model.GapicClass.Kind;
3737
import com.google.api.generator.gapic.model.GapicContext;
3838
import com.google.api.generator.gapic.model.Service;
39-
import com.google.protobuf.AbstractMessage;
39+
import com.google.protobuf.Message;
4040
import io.grpc.ServerServiceDefinition;
4141
import java.util.Arrays;
4242
import java.util.List;
@@ -130,7 +130,7 @@ private static MethodDefinition createGetRequestsMethod(
130130
TypeNode.withReference(
131131
ConcreteReference.builder()
132132
.setClazz(List.class)
133-
.setGenerics(Arrays.asList(typeStore.get("AbstractMessage").reference()))
133+
.setGenerics(Arrays.asList(typeStore.get("Message").reference()))
134134
.build());
135135
String methodName = "getRequests";
136136
Expr returnExpr =
@@ -153,10 +153,7 @@ private static MethodDefinition createAddResponseMethod(
153153
String methodName = "addResponse";
154154
VariableExpr responseArgExpr =
155155
VariableExpr.withVariable(
156-
Variable.builder()
157-
.setName("response")
158-
.setType(typeStore.get("AbstractMessage"))
159-
.build());
156+
Variable.builder().setName("response").setType(typeStore.get("Message")).build());
160157

161158
Expr methodInvocationExpr =
162159
MethodInvocationExpr.builder()
@@ -235,8 +232,7 @@ private static MethodDefinition createResetMethod(VariableExpr serviceImplVarExp
235232

236233
private static TypeStore createTypes(Service service) {
237234
List<Class<?>> concreteClazzes =
238-
Arrays.asList(
239-
AbstractMessage.class, BetaApi.class, Generated.class, ServerServiceDefinition.class);
235+
Arrays.asList(Message.class, BetaApi.class, Generated.class, ServerServiceDefinition.class);
240236
TypeStore typeStore = new TypeStore(concreteClazzes);
241237

242238
typeStore.put("com.google.api.gax.grpc.testing", "MockGrpcService");

gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/grpc/MockServiceImplClassComposer.java

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
import com.google.api.generator.gapic.model.Service;
5252
import com.google.api.generator.gapic.utils.JavaStyle;
5353
import com.google.longrunning.Operation;
54-
import com.google.protobuf.AbstractMessage;
54+
import com.google.protobuf.Message;
5555
import io.grpc.ServerServiceDefinition;
5656
import io.grpc.stub.StreamObserver;
5757
import java.util.ArrayList;
@@ -75,8 +75,7 @@ public class MockServiceImplClassComposer implements ClassComposer {
7575
TypeNode.withReference(
7676
ConcreteReference.builder()
7777
.setClazz(List.class)
78-
.setGenerics(
79-
Arrays.asList(FIXED_TYPESTORE.get("AbstractMessage").reference()))
78+
.setGenerics(Arrays.asList(FIXED_TYPESTORE.get("Message").reference()))
8079
.build()))
8180
.build());
8281

@@ -179,10 +178,7 @@ private static MethodDefinition createGetRequestsMethod() {
179178
private static MethodDefinition createAddResponseMethod() {
180179
VariableExpr responseArgExpr =
181180
VariableExpr.withVariable(
182-
Variable.builder()
183-
.setName("response")
184-
.setType(FIXED_TYPESTORE.get("AbstractMessage"))
185-
.build());
181+
Variable.builder().setName("response").setType(FIXED_TYPESTORE.get("Message")).build());
186182
Expr methodInvocationExpr =
187183
MethodInvocationExpr.builder()
188184
.setMethodName("add")
@@ -207,8 +203,7 @@ private static MethodDefinition createSetResponsesMethod(Service service) {
207203
TypeNode.withReference(
208204
ConcreteReference.builder()
209205
.setClazz(List.class)
210-
.setGenerics(
211-
Arrays.asList(FIXED_TYPESTORE.get("AbstractMessage").reference()))
206+
.setGenerics(Arrays.asList(FIXED_TYPESTORE.get("Message").reference()))
212207
.build()))
213208
.build());
214209
Expr responseAssignExpr =
@@ -597,7 +592,7 @@ private static Statement createHandleObjectStatement(
597592
private static TypeStore createStaticTypes() {
598593
List<Class<?>> concreteClazzes =
599594
Arrays.asList(
600-
AbstractMessage.class,
595+
Message.class,
601596
ArrayList.class,
602597
BetaApi.class,
603598
Generated.class,

gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/MockDeprecatedService.golden

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ package com.google.testdata.v1;
22

33
import com.google.api.core.BetaApi;
44
import com.google.api.gax.grpc.testing.MockGrpcService;
5-
import com.google.protobuf.AbstractMessage;
5+
import com.google.protobuf.Message;
66
import io.grpc.ServerServiceDefinition;
77
import java.util.List;
88
import javax.annotation.Generated;
@@ -17,12 +17,12 @@ public class MockDeprecatedService implements MockGrpcService {
1717
}
1818

1919
@Override
20-
public List<AbstractMessage> getRequests() {
20+
public List<Message> getRequests() {
2121
return serviceImpl.getRequests();
2222
}
2323

2424
@Override
25-
public void addResponse(AbstractMessage response) {
25+
public void addResponse(Message response) {
2626
serviceImpl.addResponse(response);
2727
}
2828

gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/MockDeprecatedServiceImpl.golden

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package com.google.testdata.v1;
22

33
import com.google.api.core.BetaApi;
4-
import com.google.protobuf.AbstractMessage;
54
import com.google.protobuf.Empty;
5+
import com.google.protobuf.Message;
66
import com.google.testdata.v1.DeprecatedServiceGrpc.DeprecatedServiceImplBase;
77
import io.grpc.stub.StreamObserver;
88
import java.util.ArrayList;
@@ -14,23 +14,23 @@ import javax.annotation.Generated;
1414
@BetaApi
1515
@Generated("by gapic-generator-java")
1616
public class MockDeprecatedServiceImpl extends DeprecatedServiceImplBase {
17-
private List<AbstractMessage> requests;
17+
private List<Message> requests;
1818
private Queue<java.lang.Object> responses;
1919

2020
public MockDeprecatedServiceImpl() {
2121
requests = new ArrayList<>();
2222
responses = new LinkedList<>();
2323
}
2424

25-
public List<AbstractMessage> getRequests() {
25+
public List<Message> getRequests() {
2626
return requests;
2727
}
2828

29-
public void addResponse(AbstractMessage response) {
29+
public void addResponse(Message response) {
3030
responses.add(response);
3131
}
3232

33-
public void setResponses(List<AbstractMessage> responses) {
33+
public void setResponses(List<Message> responses) {
3434
this.responses = new LinkedList<java.lang.Object>(responses);
3535
}
3636

gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/MockEcho.golden

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ package com.google.showcase.v1beta1;
22

33
import com.google.api.core.BetaApi;
44
import com.google.api.gax.grpc.testing.MockGrpcService;
5-
import com.google.protobuf.AbstractMessage;
5+
import com.google.protobuf.Message;
66
import io.grpc.ServerServiceDefinition;
77
import java.util.List;
88
import javax.annotation.Generated;
@@ -17,12 +17,12 @@ public class MockEcho implements MockGrpcService {
1717
}
1818

1919
@Override
20-
public List<AbstractMessage> getRequests() {
20+
public List<Message> getRequests() {
2121
return serviceImpl.getRequests();
2222
}
2323

2424
@Override
25-
public void addResponse(AbstractMessage response) {
25+
public void addResponse(Message response) {
2626
serviceImpl.addResponse(response);
2727
}
2828

gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/MockEchoImpl.golden

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ package com.google.showcase.v1beta1;
22

33
import com.google.api.core.BetaApi;
44
import com.google.longrunning.Operation;
5-
import com.google.protobuf.AbstractMessage;
5+
import com.google.protobuf.Message;
66
import com.google.showcase.v1beta1.EchoGrpc.EchoImplBase;
77
import io.grpc.stub.StreamObserver;
88
import java.util.ArrayList;
@@ -14,23 +14,23 @@ import javax.annotation.Generated;
1414
@BetaApi
1515
@Generated("by gapic-generator-java")
1616
public class MockEchoImpl extends EchoImplBase {
17-
private List<AbstractMessage> requests;
17+
private List<Message> requests;
1818
private Queue<java.lang.Object> responses;
1919

2020
public MockEchoImpl() {
2121
requests = new ArrayList<>();
2222
responses = new LinkedList<>();
2323
}
2424

25-
public List<AbstractMessage> getRequests() {
25+
public List<Message> getRequests() {
2626
return requests;
2727
}
2828

29-
public void addResponse(AbstractMessage response) {
29+
public void addResponse(Message response) {
3030
responses.add(response);
3131
}
3232

33-
public void setResponses(List<AbstractMessage> responses) {
33+
public void setResponses(List<Message> responses) {
3434
this.responses = new LinkedList<java.lang.Object>(responses);
3535
}
3636

0 commit comments

Comments
 (0)