Commit 9050952
chore(hermetic-build): include .github template updates as part of generation (#3723)
Part of the fix for
#3701 ☕
### Approach
The templates come from
https://github.com/googleapis/synthtool/tree/bf182cd41d9a7de56092cafcc7befe6b398332f6.
The only update was to include `generated-files-bot`, which is already
up to date in all the HW repos.
The `.kokoro` folder will be a separate follow up task. We will now
focus on solving the update of `update_generation_config` `yaml` and
`sh` files.
The fix to include the `.github` folder follows from
https://setuptools.pypa.io/en/latest/userguide/datafiles.html:
```
Glob patterns do not automatically match dotfiles, i.e., directory or file names starting with a dot (.).
To include such files, you must explicitly start the pattern with a dot, e.g. .* to match .gitignore.
```
Interestingly, this is also the reason `cp
synthool/gcp/templates/java_library/* ...` did not bring folders
starting with dot (such as .kokoro) into
#2884
### Confirming effects in downstream repos
Demos show the results as of
b66af92
in
- googleapis/java-storage#3012
- googleapis/java-logging#1787
- googleapis/java-pubsub#2384
- googleapis/java-bigtable#2546
- googleapis/java-spanner#3711
- googleapis/java-firestore#2065
- googleapis/java-datastore#1810
- googleapis/java-bigquerystorage#2929
- googleapis/java-pubsublite#1837
There were no regressions on templated files that were manually
modified.1 parent 36e86f4 commit 9050952
File tree
4 files changed
+35
-24
lines changed- hermetic_build
- library_generation
- owlbot/templates/java_library/.github
4 files changed
+35
-24
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
133 | 136 | | |
134 | 137 | | |
135 | 138 | | |
| |||
153 | 156 | | |
154 | 157 | | |
155 | 158 | | |
| 159 | + | |
| 160 | + | |
156 | 161 | | |
157 | 162 | | |
158 | 163 | | |
159 | | - | |
| 164 | + | |
160 | 165 | | |
161 | | - | |
| 166 | + | |
162 | 167 | | |
163 | 168 | | |
164 | 169 | | |
| |||
212 | 217 | | |
213 | 218 | | |
214 | 219 | | |
215 | | - | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
216 | 230 | | |
217 | 231 | | |
218 | | - | |
| 232 | + | |
219 | 233 | | |
220 | 234 | | |
221 | 235 | | |
| |||
Lines changed: 0 additions & 20 deletions
This file was deleted.
Lines changed: 13 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
27 | 31 | | |
28 | 32 | | |
29 | 33 | | |
| |||
0 commit comments