Skip to content

Commit 953e1a0

Browse files
committed
move adv tls changes to another PR.
1 parent b3d457b commit 953e1a0

File tree

1 file changed

+3
-25
lines changed

1 file changed

+3
-25
lines changed

gax-java/gax-grpc/src/main/java/com/google/api/gax/grpc/InstantiatingGrpcChannelProvider.java

Lines changed: 3 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,6 @@
6767
import io.grpc.TlsChannelCredentials;
6868
import io.grpc.alts.GoogleDefaultChannelCredentials;
6969
import io.grpc.auth.MoreCallCredentials;
70-
import io.grpc.util.AdvancedTlsX509KeyManager;
71-
import io.grpc.util.AdvancedTlsX509TrustManager;
7270
import java.io.File;
7371
import java.io.IOException;
7472
import java.lang.reflect.Method;
@@ -80,7 +78,6 @@
8078
import java.util.List;
8179
import java.util.Map;
8280
import java.util.concurrent.Executor;
83-
import java.util.concurrent.Executors;
8481
import java.util.concurrent.ScheduledExecutorService;
8582
import java.util.concurrent.TimeUnit;
8683
import java.util.logging.Level;
@@ -563,32 +560,13 @@ ChannelCredentials buildS2AChannelCredentials(
563560
*/
564561
@VisibleForTesting
565562
ChannelCredentials createMtlsToS2AChannelCredentials(
566-
File trustBundle, File privateKey, File certChain)
567-
throws IOException, GeneralSecurityException {
563+
File trustBundle, File privateKey, File certChain) throws IOException {
568564
if (trustBundle == null || privateKey == null || certChain == null) {
569565
return null;
570566
}
571-
AdvancedTlsX509KeyManager keyManager = new AdvancedTlsX509KeyManager();
572-
ScheduledExecutorService keyManagerExecutor = Executors.newSingleThreadScheduledExecutor(
573-
r -> {
574-
Thread t = new Thread(r, "s2a-key-manager-updater");
575-
t.setDaemon(true);
576-
return t;
577-
});
578-
579-
keyManager.updateIdentityCredentials(certChain, privateKey, 1, TimeUnit.HOURS, keyManagerExecutor);
580-
AdvancedTlsX509TrustManager trustManager = AdvancedTlsX509TrustManager.newBuilder().build();
581-
ScheduledExecutorService trustManagerExecutor = Executors.newSingleThreadScheduledExecutor(
582-
r -> {
583-
Thread t = new Thread(r, "s2a-trust-manager-updater");
584-
t.setDaemon(true);
585-
return t;
586-
});
587-
588-
trustManager.updateTrustCredentials(trustBundle, 1, TimeUnit.HOURS, trustManagerExecutor);
589567
return TlsChannelCredentials.newBuilder()
590-
.keyManager(keyManager)
591-
.trustManager(trustManager)
568+
.keyManager(privateKey, certChain)
569+
.trustManager(trustBundle)
592570
.build();
593571
}
594572

0 commit comments

Comments
 (0)