Skip to content

Commit 965b8d8

Browse files
committed
chore: Add comments
1 parent fbb7e69 commit 965b8d8

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

.kokoro/nightly/downstream-protobuf-binary-compatibility.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,15 +49,18 @@ for repo in ${REPOS_UNDER_TEST//,/ }; do # Split on comma
4949

5050
mvn -B -ntp clean install -T 1C -DskipTests -Dclirr.skip
5151

52+
# Storage-Nio's artifact ID is google-cloud-nio, not google-cloud-storage-nio
5253
if [[ "$repo" == "java-storage-nio" ]]; then
5354
repo_name="nio"
5455
fi
5556
primary_artifact=$(grep -E "^google-cloud-${repo_name}" "versions.txt" | head -n 1)
5657
version=$(echo "${primary_artifact}" | tr ':' '\n' | tail -n 1)
58+
artifact_id="google-cloud-${repo_name}"
5759
echo "Using ${repo} v${version}"
5860
popd
5961

60-
program_args="-r --artifacts com.google.cloud:google-cloud-${repo_name}:${version},com.google.protobuf:protobuf-java:${PROTOBUF_RUNTIME_VERSION} -s com.google.cloud:google-cloud-${repo_name}:${version}"
62+
# The `-s` argument filters the linkage check problems that stem from the artifact
63+
program_args="-r --artifacts com.google.cloud:${artifact_id}:${version},com.google.protobuf:protobuf-java:${PROTOBUF_RUNTIME_VERSION} -s com.google.cloud:${artifact_id}:${version}"
6164
echo "Linkage Checker Program Arguments: ${program_args}"
6265
mvn -B -ntp exec:java -Dexec.mainClass="com.google.cloud.tools.opensource.classpath.LinkageCheckerMain" -Dexec.args="${program_args}"
6366
done

0 commit comments

Comments
 (0)