Skip to content

Commit a8d2f20

Browse files
committed
make requestPayload also as JsonElement in LogData.
1 parent d25e742 commit a8d2f20

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

gax-java/gax-grpc/src/main/java/com/google/api/gax/grpc/GrpcLoggingInterceptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ void logResponse(Status status, LogData.Builder logDataBuilder, Logger logger) {
171171
<RespT> void logRequestDetails(RespT message, LogData.Builder logDataBuilder) {
172172
try {
173173
if (LOGGER.isDebugEnabled()) {
174-
logDataBuilder.requestPayload(GSON.toJson(message));
174+
logDataBuilder.requestPayload(GSON.toJsonTree(message));
175175
Map<String, String> requestDetailsMap = logDataBuilder.build().toMapRequest();
176176
LoggingUtils.logWithMDC(
177177
LOGGER, Level.DEBUG, requestDetailsMap, "Sending gRPC request: request payload");

gax-java/gax-httpjson/src/main/java/com/google/api/gax/httpjson/HttpJsonLoggingInterceptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ void logResponse(int statusCode, LogData.Builder logDataBuilder, Logger logger)
183183
private <RespT> void logRequestDetails(RespT message, LogData.Builder logDataBuilder) {
184184
try {
185185
if (LOGGER.isDebugEnabled()) {
186-
logDataBuilder.requestPayload(GSON.toJson(message));
186+
logDataBuilder.requestPayload(GSON.toJsonTree(message));
187187
Map<String, String> requestDetailsMap = logDataBuilder.build().toMapRequest();
188188
LoggingUtils.logWithMDC(
189189
LOGGER, Level.DEBUG, requestDetailsMap, "Sending HTTP request: request payload");

gax-java/gax/src/main/java/com/google/api/gax/logging/LogData.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public abstract class LogData {
5656
public abstract String requestHeaders();
5757

5858
@Nullable
59-
public abstract String requestPayload();
59+
public abstract JsonElement requestPayload();
6060

6161
@Nullable
6262
public abstract String responseStatus();
@@ -87,7 +87,7 @@ public abstract static class Builder {
8787

8888
public abstract Builder requestHeaders(String requestHeaders);
8989

90-
public abstract Builder requestPayload(String requestPayload);
90+
public abstract Builder requestPayload(JsonElement requestPayload);
9191

9292
public abstract Builder responseStatus(String responseStatus);
9393

@@ -119,7 +119,7 @@ public Map<String, String> toMapRequest() {
119119
map.put("request.headers", requestHeaders());
120120
}
121121
if (requestPayload() != null) {
122-
map.put("request.payload", requestPayload());
122+
map.put("request.payload", gson.toJson(requestPayload()));
123123
}
124124
if (httpMethod() != null) {
125125
map.put("request.method", httpMethod());

0 commit comments

Comments
 (0)