Skip to content

Commit ec21a3b

Browse files
committed
add comment and add assert to test to verify correct methods included.
1 parent 1f5be4b commit ec21a3b

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

gapic-generator-java/src/test/java/com/google/api/generator/gapic/protoparser/ParserTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -760,6 +760,9 @@ void selectiveGenerationTest_shouldGenerateOnlySelectiveMethods() {
760760
assertEquals(1, services.size());
761761
assertEquals("EchoServiceShouldGeneratePartial", services.get(0).overriddenName());
762762
assertEquals(3, services.get(0).methods().size());
763+
for (Method method : services.get(0).methods()) {
764+
assertTrue(method.name().contains("ShouldInclude"));
765+
}
763766
}
764767

765768
@Test

gapic-generator-java/src/test/proto/selective_api_generation.proto

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,9 @@ message Foobar {
9292
string info = 2;
9393
}
9494

95-
// resource name used for message EchoRequestWithFoobarbaz.
95+
// resource name used only for message EchoRequestWithFoobarbaz.
96+
// should not be generated with selective generation when
97+
// AnExcludedMethod is not config as included.
9698
message Foobarbaz {
9799
option (google.api.resource) = {
98100
type: "showcase.googleapis.com/Foobarbaz"

0 commit comments

Comments
 (0)