Revert service client throw comment

Author: cindy-peng

gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/comment/ServiceClientCommentComposer.java

@@ -38,7 +38,7 @@ public class ServiceClientCommentComposer {
   // Tokens.
   private static final String EMPTY_STRING = "";
   private static final String API_EXCEPTION_TYPE_NAME = "com.google.api.gax.rpc.ApiException";
-  private static final String EXCEPTION_CONDITION = "if the remote call fails.";
+  private static final String EXCEPTION_CONDITION = "if the remote call fails";
 
   // Constants.
   private static final String SERVICE_DESCRIPTION_INTRO_STRING =

gapic-generator-java/src/test/java/com/google/api/generator/engine/writer/goldens/GrpcServiceClientWithNestedClassImport.golden

@@ -163,7 +163,7 @@ public class NestedMessageServiceClient implements BackgroundResource {
    * }</pre>
    *
    * @param request The request object containing all of the parameters for the API call.
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final Outer.Middle.Inner nestedMessageMethod(Outer.Middle request) {
     return nestedMessageMethodCallable().call(request);

gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/BookshopClient.golden

@@ -166,7 +166,7 @@ public class BookshopClient implements BackgroundResource {
    *
    * @param booksCount
    * @param books
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final Book getBook(int booksCount, List<Book> books) {
     GetBookRequest request =
@@ -193,7 +193,7 @@ public class BookshopClient implements BackgroundResource {
    *
    * @param booksList
    * @param books
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final Book getBook(String booksList, List<Book> books) {
     GetBookRequest request =
@@ -223,7 +223,7 @@ public class BookshopClient implements BackgroundResource {
    * }</pre>
    *
    * @param request The request object containing all of the parameters for the API call.
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final Book getBook(GetBookRequest request) {
     return getBookCallable().call(request);

gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/DeprecatedServiceClient.golden

@@ -178,7 +178,7 @@ public class DeprecatedServiceClient implements BackgroundResource {
    * }</pre>
    *
    * @param request The request object containing all of the parameters for the API call.
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final void fastFibonacci(FibonacciRequest request) {
     fastFibonacciCallable().call(request);
@@ -223,7 +223,7 @@ public class DeprecatedServiceClient implements BackgroundResource {
    * }</pre>
    *
    * @param request The request object containing all of the parameters for the API call.
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    * @deprecated This method is deprecated and will be removed in the next major version update.
    */
   @Deprecated

gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/EchoClient.golden

@@ -322,7 +322,7 @@ public class EchoClient implements BackgroundResource {
    * }</pre>
    *
    * @param request The request object containing all of the parameters for the API call.
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final EchoResponse echo() {
     EchoRequest request = EchoRequest.newBuilder().build();
@@ -346,7 +346,7 @@ public class EchoClient implements BackgroundResource {
    * }</pre>
    *
    * @param parent
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final EchoResponse echo(ResourceName parent) {
     EchoRequest request =
@@ -371,7 +371,7 @@ public class EchoClient implements BackgroundResource {
    * }</pre>
    *
    * @param error
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final EchoResponse echo(Status error) {
     EchoRequest request = EchoRequest.newBuilder().setError(error).build();
@@ -395,7 +395,7 @@ public class EchoClient implements BackgroundResource {
    * }</pre>
    *
    * @param name
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final EchoResponse echo(FoobarName name) {
     EchoRequest request =
@@ -420,7 +420,7 @@ public class EchoClient implements BackgroundResource {
    * }</pre>
    *
    * @param content
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final EchoResponse echo(String content) {
     EchoRequest request = EchoRequest.newBuilder().setContent(content).build();
@@ -444,7 +444,7 @@ public class EchoClient implements BackgroundResource {
    * }</pre>
    *
    * @param name
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final EchoResponse echo(String name) {
     EchoRequest request = EchoRequest.newBuilder().setName(name).build();
@@ -468,7 +468,7 @@ public class EchoClient implements BackgroundResource {
    * }</pre>
    *
    * @param parent
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final EchoResponse echo(String parent) {
     EchoRequest request = EchoRequest.newBuilder().setParent(parent).build();
@@ -494,7 +494,7 @@ public class EchoClient implements BackgroundResource {
    *
    * @param content
    * @param severity
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final EchoResponse echo(String content, Severity severity) {
     EchoRequest request =
@@ -525,7 +525,7 @@ public class EchoClient implements BackgroundResource {
    * }</pre>
    *
    * @param request The request object containing all of the parameters for the API call.
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final EchoResponse echo(EchoRequest request) {
     return echoCallable().call(request);
@@ -712,7 +712,7 @@ public class EchoClient implements BackgroundResource {
    * }</pre>
    *
    * @param request The request object containing all of the parameters for the API call.
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final PagedExpandPagedResponse pagedExpand(PagedExpandRequest request) {
     return pagedExpandPagedCallable().call(request);
@@ -802,7 +802,7 @@ public class EchoClient implements BackgroundResource {
    * }</pre>
    *
    * @param request The request object containing all of the parameters for the API call.
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final SimplePagedExpandPagedResponse simplePagedExpand() {
     PagedExpandRequest request = PagedExpandRequest.newBuilder().build();
@@ -833,7 +833,7 @@ public class EchoClient implements BackgroundResource {
    * }</pre>
    *
    * @param request The request object containing all of the parameters for the API call.
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final SimplePagedExpandPagedResponse simplePagedExpand(PagedExpandRequest request) {
     return simplePagedExpandPagedCallable().call(request);
@@ -923,7 +923,7 @@ public class EchoClient implements BackgroundResource {
    * }</pre>
    *
    * @param ttl
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final OperationFuture<WaitResponse, WaitMetadata> waitAsync(Duration ttl) {
     WaitRequest request = WaitRequest.newBuilder().setTtl(ttl).build();
@@ -947,7 +947,7 @@ public class EchoClient implements BackgroundResource {
    * }</pre>
    *
    * @param endTime
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final OperationFuture<WaitResponse, WaitMetadata> waitAsync(Timestamp endTime) {
     WaitRequest request = WaitRequest.newBuilder().setEndTime(endTime).build();
@@ -971,7 +971,7 @@ public class EchoClient implements BackgroundResource {
    * }</pre>
    *
    * @param request The request object containing all of the parameters for the API call.
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final OperationFuture<WaitResponse, WaitMetadata> waitAsync(WaitRequest request) {
     return waitOperationCallable().futureCall(request);
@@ -1039,7 +1039,7 @@ public class EchoClient implements BackgroundResource {
    * }</pre>
    *
    * @param request The request object containing all of the parameters for the API call.
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final BlockResponse block(BlockRequest request) {
     return blockCallable().call(request);
@@ -1090,7 +1090,7 @@ public class EchoClient implements BackgroundResource {
    * }</pre>
    *
    * @param request The request object containing all of the parameters for the API call.
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final Object collideName(EchoRequest request) {
     return collideNameCallable().call(request);

gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/EchoServiceSelectiveGapicClient.golden

@@ -233,7 +233,7 @@ public class EchoServiceShouldGeneratePartialPublicClient implements BackgroundR
    * }</pre>
    *
    * @param request The request object containing all of the parameters for the API call.
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final EchoResponse echoShouldGenerateAsPublic() {
     EchoRequest request = EchoRequest.newBuilder().build();
@@ -259,7 +259,7 @@ public class EchoServiceShouldGeneratePartialPublicClient implements BackgroundR
    * }</pre>
    *
    * @param name
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final EchoResponse echoShouldGenerateAsPublic(FoobarName name) {
     EchoRequest request =
@@ -286,7 +286,7 @@ public class EchoServiceShouldGeneratePartialPublicClient implements BackgroundR
    * }</pre>
    *
    * @param name
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final EchoResponse echoShouldGenerateAsPublic(String name) {
     EchoRequest request = EchoRequest.newBuilder().setName(name).build();
@@ -317,7 +317,7 @@ public class EchoServiceShouldGeneratePartialPublicClient implements BackgroundR
    * }</pre>
    *
    * @param request The request object containing all of the parameters for the API call.
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final EchoResponse echoShouldGenerateAsPublic(EchoRequest request) {
     return echoShouldGenerateAsPublicCallable().call(request);
@@ -438,7 +438,7 @@ public class EchoServiceShouldGeneratePartialPublicClient implements BackgroundR
    * }</pre>
    *
    * @param request The request object containing all of the parameters for the API call.
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails. @InternalApi This method
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails @InternalApi This method
    *     is internal used only. Please do not use directly.
    */
   @InternalApi("Internal API. This API is not intended for public consumption.")
@@ -466,7 +466,7 @@ public class EchoServiceShouldGeneratePartialPublicClient implements BackgroundR
    * }</pre>
    *
    * @param name
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails. @InternalApi This method
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails @InternalApi This method
    *     is internal used only. Please do not use directly.
    */
   @InternalApi("Internal API. This API is not intended for public consumption.")
@@ -495,7 +495,7 @@ public class EchoServiceShouldGeneratePartialPublicClient implements BackgroundR
    * }</pre>
    *
    * @param name
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails. @InternalApi This method
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails @InternalApi This method
    *     is internal used only. Please do not use directly.
    */
   @InternalApi("Internal API. This API is not intended for public consumption.")
@@ -528,7 +528,7 @@ public class EchoServiceShouldGeneratePartialPublicClient implements BackgroundR
    * }</pre>
    *
    * @param request The request object containing all of the parameters for the API call.
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails. @InternalApi This method
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails @InternalApi This method
    *     is internal used only. Please do not use directly.
    */
   @InternalApi("Internal API. This API is not intended for public consumption.")

gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/IdentityClient.golden

@@ -245,7 +245,7 @@ public class IdentityClient implements BackgroundResource {
    * @param parent
    * @param displayName
    * @param email
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final User createUser(String parent, String displayName, String email) {
     CreateUserRequest request =
@@ -287,7 +287,7 @@ public class IdentityClient implements BackgroundResource {
    * @param nickname
    * @param enableNotifications
    * @param heightFeet
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final User createUser(
       String parent,
@@ -359,7 +359,7 @@ public class IdentityClient implements BackgroundResource {
    * @param title
    * @param subject
    * @param artistName
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final User createUser(
       String parent,
@@ -424,7 +424,7 @@ public class IdentityClient implements BackgroundResource {
    * }</pre>
    *
    * @param request The request object containing all of the parameters for the API call.
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final User createUser(CreateUserRequest request) {
     return createUserCallable().call(request);
@@ -473,7 +473,7 @@ public class IdentityClient implements BackgroundResource {
    * }</pre>
    *
    * @param name
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final User getUser(UserName name) {
     GetUserRequest request =
@@ -498,7 +498,7 @@ public class IdentityClient implements BackgroundResource {
    * }</pre>
    *
    * @param name
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final User getUser(String name) {
     GetUserRequest request = GetUserRequest.newBuilder().setName(name).build();
@@ -523,7 +523,7 @@ public class IdentityClient implements BackgroundResource {
    * }</pre>
    *
    * @param request The request object containing all of the parameters for the API call.
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final User getUser(GetUserRequest request) {
     return getUserCallable().call(request);
@@ -570,7 +570,7 @@ public class IdentityClient implements BackgroundResource {
    * }</pre>
    *
    * @param request The request object containing all of the parameters for the API call.
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final User updateUser(UpdateUserRequest request) {
     return updateUserCallable().call(request);
@@ -616,7 +616,7 @@ public class IdentityClient implements BackgroundResource {
    * }</pre>
    *
    * @param name
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final void deleteUser(UserName name) {
     DeleteUserRequest request =
@@ -641,7 +641,7 @@ public class IdentityClient implements BackgroundResource {
    * }</pre>
    *
    * @param name
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final void deleteUser(String name) {
     DeleteUserRequest request = DeleteUserRequest.newBuilder().setName(name).build();
@@ -666,7 +666,7 @@ public class IdentityClient implements BackgroundResource {
    * }</pre>
    *
    * @param request The request object containing all of the parameters for the API call.
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final void deleteUser(DeleteUserRequest request) {
     deleteUserCallable().call(request);
@@ -718,7 +718,7 @@ public class IdentityClient implements BackgroundResource {
    * }</pre>
    *
    * @param request The request object containing all of the parameters for the API call.
-   * @throws com.google.api.gax.rpc.ApiException if the remote call fails.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
   public final ListUsersPagedResponse listUsers(ListUsersRequest request) {
     return listUsersPagedCallable().call(request);