feat: Upgrade protobuf runtime and gen code to 4.33. #4000
Conversation
Summary of ChangesHello @blakeli0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a significant infrastructure update by upgrading the project's Protobuf runtime and generated code to version 4.33.0. This ensures compatibility with the latest Protobuf features and improvements, requiring changes across Docker build configurations, Maven dependencies, and a comprehensive regeneration of Java common proto files to reflect the new version's API and internal structure. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades the protobuf runtime and generated code to version 4.33.0. The changes primarily involve updating version numbers in configuration files and regenerating a large number of Java source files to be compatible with the new protobuf version. A key change is the temporary disabling of the clirr check for binary compatibility, which is understandable for a major version upgrade but should be addressed. I've also noted a potential version mismatch in the Dockerfiles that should be verified.
|
|
||
| ARG OWLBOT_CLI_COMMITTISH=3a68a9c0de318784b3aefadcc502a6521b3f1bc5 | ||
| ARG PROTOC_VERSION=25.8 | ||
| ARG PROTOC_VERSION=33.0 |
There was a problem hiding this comment.
The PROTOC_VERSION is being updated to 33.0. This seems inconsistent with the protobuf version 4.33.0 being set in gapic-generator-java-pom-parent/pom.xml. Please verify if this is the correct version for the protoc compiler corresponding to the 4.33.0 Java runtime.
|
|
||
| ARG OWLBOT_CLI_COMMITTISH=3a68a9c0de318784b3aefadcc502a6521b3f1bc5 | ||
| ARG PROTOC_VERSION=25.8 | ||
| ARG PROTOC_VERSION=33.0 |
There was a problem hiding this comment.
Similar to the other Dockerfile, the PROTOC_VERSION is set to 33.0, which appears inconsistent with the protobuf Java version 4.33.0 used in the project. Please double-check that this is the intended version for the protoc compiler.
| <!-- skipping clirr check for protobuf 4.x upgrade --> | ||
| <clirr.skip>true</clirr.skip> |
There was a problem hiding this comment.
While skipping the clirr check is necessary for a major version upgrade with known breaking changes, it's a good practice to create a follow-up issue to re-enable this check and address any binary incompatibilities introduced by the protobuf upgrade. This ensures that binary compatibility is tracked and managed going forward.
Remove hardcoded clirr.skip=false in showcase-clirr check. This enables us to configure the clirr check in poms.
|
|
3 participants
Protobuf-java v4.33 restored gen code compatibility to 3.0.0. Upgrade protobuf runtime and gen code to 4.33 should have minimum risks now.
See go/cloud-java:protobuf-4.x-upgrade for details.