Skip to content

Conversation

@diegomarquezp
Copy link
Contributor

This PR cleans up the .github/release-please.yml file by removing redundant options and the bump-minor-pre-major setting for major releases.

- Remove redundant options already declared at the top level.\n- Remove bumpMinorPreMajor for repositories after the first major release.
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Dec 5, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @diegomarquezp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the automated release process by cleaning up the .github/release-please.yml configuration file. The changes aim to simplify the setup by removing redundant options and adjusting specific release behaviors for various branches, leading to a more concise and maintainable release configuration.

Highlights

  • Configuration Simplification: Streamlined the .github/release-please.yml file by removing redundant options from individual branch configurations, making the file more concise and easier to manage.
  • Removed bumpMinorPreMajor Setting: Eliminated the bumpMinorPreMajor setting from several branch configurations, which affects how minor versions are handled before a major release for those specific branches.
  • Redundant Option Cleanup: Removed handleGHRelease, manifest, primaryBranch, and extraFiles options from branch-specific settings, indicating these are either inherited from global configurations or are no longer necessary at the branch level.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively streamlines the .github/release-please.yml configuration by removing redundant properties from branch-specific setups. This simplification enhances maintainability by relying on inheritance from the top-level configuration. The changes align with the stated goal of cleaning up the file. I have one minor suggestion to further improve the consistency of the branch definitions.

Comment on lines 26 to 29
- releaseType: java-backport
branch: 2.54.x
- releaseType: java-backport
branch: 2.59.x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other branch configurations in this file (like 2.23.x), it's better to list the branch key first. This improves readability and makes the file easier to maintain.

    - branch: 2.54.x
      releaseType: java-backport
    - branch: 2.59.x
      releaseType: java-backport

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2025

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2025

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant