Skip to content
This repository was archived by the owner on Mar 2, 2018. It is now read-only.

Commit c20dce7

Browse files
committed
nits
1 parent 1617989 commit c20dce7

File tree

3 files changed

+14
-6
lines changed

3 files changed

+14
-6
lines changed

AreaLearningJava/app/src/main/java/com/projecttango/experiments/javaarealearning/AreaLearningActivity.java

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -433,7 +433,7 @@ private String getPoseStatus(TangoPoseData pose) {
433433
return getString(R.string.pose_invalid);
434434
case TangoPoseData.POSE_VALID:
435435
return getString(R.string.pose_valid);
436-
default:
436+
default:
437437
return getString(R.string.pose_unknown);
438438
}
439439
}
@@ -580,21 +580,30 @@ public void onSaveAdfSuccess(String adfName, String adfUuid) {
580580
*/
581581
private void showSetADFNameDialog() {
582582
Bundle bundle = new Bundle();
583-
bundle.putString("name", "New ADF");
583+
bundle.putString("name",getResources().getString(R.string.default_adf_name) );
584584
bundle.putString("id", ""); // UUID is generated after the ADF is saved.
585585

586586
FragmentManager manager = getFragmentManager();
587587
SetADFNameDialog setADFNameDialog = new SetADFNameDialog();
588588
setADFNameDialog.setArguments(bundle);
589589
setADFNameDialog.show(manager, "ADFNameDialog");
590590
}
591+
592+
593+
/**
594+
* Implements SetADFNameDialog.CallbackListener.
595+
*/
591596
@Override
592597
public void onAdfNameOk(String name, String uuid) {
593598
saveAdf(name);
594599
}
595600

601+
602+
/**
603+
* Implements SetADFNameDialog.CallbackListener.
604+
*/
596605
@Override
597606
public void onAdfNameCancelled() {
598-
607+
// Continue running.s
599608
}
600609
}

AreaLearningJava/app/src/main/java/com/projecttango/experiments/javaarealearning/SaveAdfTask.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ protected String doInBackground(Void... params) {
9292
}
9393

9494
/**
95-
* Responds to progress updates events by updating the UI.
95+
* Responds to progress update events by updating the UI.
9696
*/
9797
@Override
9898
protected void onProgressUpdate(Integer... progress) {
@@ -102,7 +102,7 @@ protected void onProgressUpdate(Integer... progress) {
102102
}
103103

104104
/**
105-
* Dismisses the progress dialog and call the activity.
105+
* Dismisses the progress dialog and executes callbacks.
106106
*/
107107
@Override
108108
protected void onPostExecute(String adfUuid) {

AreaLearningJava/app/src/main/res/values/strings.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@
7171
<string name="default_adf_name">New ADF</string>
7272
<string name="save_adf_failed_toast_format">"Failed to save ADF '%1$s'."</string>
7373
<string name="save_adf_success_toast_format">"Saved ADF '%1$s' (%2$s)."</string>
74-
7574
<string-array name="SetDialogMenuItemsAPISpace">
7675
<item>Rename</item>
7776
<item>Delete from API space</item>

0 commit comments

Comments
 (0)