Skip to content
This repository was archived by the owner on Oct 1, 2025. It is now read-only.

Commit 2988bbf

Browse files
committed
complete 'visits are never empty' refactor, google-cloud-core unnecessary for Py3
1 parent 361568b commit 2988bbf

File tree

10 files changed

+7
-9
lines changed

10 files changed

+7
-9
lines changed

step0-webapp2-gaendb-py2/main.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def fetch_visits(limit):
3131
class MainHandler(webapp2.RequestHandler):
3232
def get(self):
3333
store_visit(self.request.remote_addr, self.request.user_agent)
34-
visits = fetch_visits(10) or () # empty sequence if None
34+
visits = fetch_visits(10)
3535
tmpl = os.path.join(os.path.dirname(__file__), 'index.html')
3636
self.response.out.write(template.render(tmpl, {'visits': visits}))
3737

step1-flask-gaendb-py2/main.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,5 +31,5 @@ def fetch_visits(limit):
3131
@app.route('/')
3232
def root():
3333
store_visit(request.remote_addr, request.user_agent)
34-
visits = fetch_visits(10) or () # empty sequence if None
34+
visits = fetch_visits(10)
3535
return render_template('index.html', visits=visits)

step2-flask-cloudndb-py2/main.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,5 +34,5 @@ def fetch_visits(limit):
3434
@app.route('/')
3535
def root():
3636
store_visit(request.remote_addr, request.user_agent)
37-
visits = fetch_visits(10) or () # empty sequence if None
37+
visits = fetch_visits(10)
3838
return render_template('index.html', visits=visits)

step2-flask-cloudndb-py3/main.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,5 +34,5 @@ def fetch_visits(limit):
3434
@app.route('/')
3535
def root():
3636
store_visit(request.remote_addr, request.user_agent)
37-
visits = fetch_visits(10) or () # empty sequence if None
37+
visits = fetch_visits(10)
3838
return render_template('index.html', visits=visits)
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
Flask==1.1.2
2-
google-cloud-core==1.4.1
32
google-cloud-ndb==1.7.1

step3-flask-datastore-py2/main.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,5 +35,5 @@ def fetch_visits(limit):
3535
@app.route('/')
3636
def root():
3737
store_visit(request.remote_addr, request.user_agent)
38-
visits = fetch_visits(10) or () # empty sequence if None
38+
visits = fetch_visits(10)
3939
return render_template('index.html', visits=visits)

step3-flask-datastore-py3/main.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,5 +35,5 @@ def fetch_visits(limit):
3535
@app.route('/')
3636
def root():
3737
store_visit(request.remote_addr, request.user_agent)
38-
visits = fetch_visits(10) or () # empty sequence if None
38+
visits = fetch_visits(10)
3939
return render_template('index.html', visits=visits)
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
Flask==1.1.2
2-
google-cloud-core==1.4.1
32
google-cloud-datastore==2.0.0

step3a-flask-firestore-py3/main.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,5 +35,5 @@ def fetch_visits(limit):
3535
@app.route('/')
3636
def root():
3737
store_visit(request.remote_addr, request.user_agent)
38-
visits = fetch_visits(10) or () # empty sequence if None
38+
visits = fetch_visits(10)
3939
return render_template('index.html', visits=visits)

step4a-cloudrun-bldpks-py3/service.yaml

100755100644
File mode changed.

0 commit comments

Comments
 (0)