make ufoLib2 not required, make instantiator work with defcon as well

Remove the unconditional ufoLib2 import and make instantiator work with
name record dicts like defcon has

Fixes #956

Author: anthrotype

Lib/ufo2ft/instantiator.py

@@ -66,7 +66,9 @@
     from collections.abc import Iterable, KeysView
 
     from ufoLib2.objects import Font, Glyph, Info
-    from ufoLib2.objects.info import NameRecord as ufoNameRecord
+
+# Type alias for name records - can be dict (defcon) or NameRecord object (ufoLib2)
+NameRecordDict = Dict[str, Any]
 
 logger = logging.getLogger(__name__)
 
@@ -204,50 +206,53 @@ def process_rules_swaps(rules, location, glyphNames):
 
 
 def _override_name_record(
-    openTypeNameRecords: list[ufoNameRecord],
-    new_value: ufoNameRecord,
-) -> None:
-    """Override an existing name record in the list of OpenType name records."""
+    openTypeNameRecords: list,
+    new_value: NameRecordDict,
+) -> bool:
+    """Override an existing name record in the list of OpenType name records.
+
+    Records can be dicts (defcon) or NameRecord objects (ufoLib2). Both support
+    dict-style read access via []. For writing, dicts use [] while NameRecord
+    uses setattr since it's read-only for the Mapping interface.
+    """
     for record in openTypeNameRecords:
         if (
-            record.platformID == new_value.platformID
-            and record.encodingID == new_value.encodingID
-            and record.languageID == new_value.languageID
-            and record.nameID == new_value.nameID
+            record["platformID"] == new_value["platformID"]
+            and record["encodingID"] == new_value["encodingID"]
+            and record["languageID"] == new_value["languageID"]
+            and record["nameID"] == new_value["nameID"]
         ):
             # Override existing name record
-            record.string = new_value.string
+            if isinstance(record, dict):
+                record["string"] = new_value["string"]
+            else:
+                record.string = new_value["string"]
             return True
     return False
 
 
-def _make_ufo_name_record(
+def _make_name_record_dict(
     name_id: int,
     value: str,
     language_tag: str = "en",
-) -> ufoNameRecord:
-    """Add a name to the list of OpenType name records, or override an existing one."""
-    from ufoLib2.objects.info import NameRecord
-
+) -> NameRecordDict:
+    """Create a name record dict from name ID, value, and language tag."""
     temp_name_record: ftNameRecord = _makeWindowsName(value, name_id, language_tag)
-    new_name_record: ufoNameRecord = NameRecord(
-        platformID=temp_name_record.platformID,
-        encodingID=temp_name_record.platEncID,
-        languageID=temp_name_record.langID,
-        nameID=temp_name_record.nameID,
-        string=value.strip(),
-    )
-    return new_name_record
+    return {
+        "platformID": temp_name_record.platformID,
+        "encodingID": temp_name_record.platEncID,
+        "languageID": temp_name_record.langID,
+        "nameID": temp_name_record.nameID,
+        "string": value.strip(),
+    }
 
 
 def merge_public_font_info(
     font: Font,
     override_public_font_info: Dict[str, Any],
     instance_location: Location,
 ) -> None:
-    """Merge the public.fontInfo dict into the ufoLib2.Font's info object (fontinfo.plist)."""
-    from ufoLib2.objects.info import NameRecord
-
+    """Merge the public.fontInfo dict into the font's info object (fontinfo.plist)."""
     for key, value in override_public_font_info.items():
         try:
             if key == "openTypeNameRecords":
@@ -264,17 +269,17 @@ def merge_public_font_info(
 
                 # merge the existing openTypeNameRecords with the new ones
                 for dict_name_record in value:
-                    ufo_name_record = NameRecord(
-                        platformID=dict_name_record["platformID"],
-                        encodingID=dict_name_record["encodingID"],
-                        languageID=dict_name_record["languageID"],
-                        nameID=dict_name_record["nameID"],
-                        string=dict_name_record["string"].strip(),
-                    )
+                    name_record = {
+                        "platformID": dict_name_record["platformID"],
+                        "encodingID": dict_name_record["encodingID"],
+                        "languageID": dict_name_record["languageID"],
+                        "nameID": dict_name_record["nameID"],
+                        "string": dict_name_record["string"].strip(),
+                    }
                     if not _override_name_record(
-                        font.info.openTypeNameRecords, ufo_name_record
+                        font.info.openTypeNameRecords, name_record
                     ):
-                        font.info.openTypeNameRecords.append(ufo_name_record)
+                        font.info.openTypeNameRecords.append(name_record)
             else:
                 setattr(font.info, key, copy.deepcopy(value))
         except AttributeError:
@@ -804,7 +809,7 @@ def _generate_instance_info(
             if language_tag in instance.localisedFamilyName:
                 # assume is Preferred Family Name (ID=16)
                 mulitlingual_opentype_font_records.append(
-                    _make_ufo_name_record(
+                    _make_name_record_dict(
                         OT_TYPOGRAPHIC_FAMILY_NAME_ID,
                         instance.localisedFamilyName[language_tag],
                         language_tag,
@@ -813,7 +818,7 @@ def _generate_instance_info(
             if language_tag in instance.localisedStyleName:
                 # assume is Preferred Subfamily Name (ID=17)
                 mulitlingual_opentype_font_records.append(
-                    _make_ufo_name_record(
+                    _make_name_record_dict(
                         OT_TYPOGRAPHIC_SUBFAMILY_NAME_ID,
                         instance.localisedStyleName[language_tag],
                         language_tag,
@@ -822,7 +827,7 @@ def _generate_instance_info(
             if language_tag in instance.localisedStyleMapFamilyName:
                 # Style Map Family Name (ID=1)
                 mulitlingual_opentype_font_records.append(
-                    _make_ufo_name_record(
+                    _make_name_record_dict(
                         OT_STYLE_MAP_FAMILY_NAME_ID,
                         instance.localisedStyleMapFamilyName[language_tag],
                         language_tag,
@@ -845,7 +850,7 @@ def _generate_instance_info(
                     # add style name to ID=1
                     full_family_name += " " + font.info.styleName
                 mulitlingual_opentype_font_records.append(
-                    _make_ufo_name_record(
+                    _make_name_record_dict(
                         OT_STYLE_MAP_FAMILY_NAME_ID,
                         full_family_name,
                         language_tag,
@@ -854,7 +859,7 @@ def _generate_instance_info(
             if language_tag in instance.localisedStyleMapStyleName:
                 # Style Map Subfamily Name (ID=2)
                 mulitlingual_opentype_font_records.append(
-                    _make_ufo_name_record(
+                    _make_name_record_dict(
                         OT_STYLE_MAP_STYLE_NAME_ID,
                         instance.localisedStyleMapStyleName[language_tag],
                         language_tag,