Skip to content

Commit 4b8761a

Browse files
mriduljikemurayamasyntxerror
authored
release 1.6.0-rc.1 changes (#1510)
* Default values of configs (#1508) * setting validation and default values of configs * config check in internal/config package * Add open-match-override setting (#1490) * Add open-match-override setting * Added enabled Co-authored-by: Jon Foust <38893532+syntxerror@users.noreply.github.com> Co-authored-by: Mridul Goswami <mridulgoswami@google.com> * shifted e2e tests to project root (#1481) * release 1.6.0-rc.1 changes * release changes for tutorials * remaining changes Co-authored-by: kemurayama <7068107+kemurayama@users.noreply.github.com> Co-authored-by: Jon Foust <38893532+syntxerror@users.noreply.github.com>
1 parent 1e51ad8 commit 4b8761a

File tree

55 files changed

+149
-32
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+149
-32
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
# If you want information on how to edit this file checkout,
5454
# http://makefiletutorial.com/
5555

56-
BASE_VERSION = 0.0.0-dev
56+
BASE_VERSION = 1.6.0-rc.1
5757
SHORT_SHA = $(shell git rev-parse --short=7 HEAD | tr -d [:punct:])
5858
BRANCH_NAME = $(shell git rev-parse --abbrev-ref HEAD | tr -d [:punct:])
5959
VERSION = $(BASE_VERSION)-$(SHORT_SHA)

cloudbuild.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ artifacts:
164164
- install/yaml/06-open-match-override-configmap.yaml
165165

166166
substitutions:
167-
_OM_VERSION: "0.0.0-dev"
167+
_OM_VERSION: "1.6.0-rc.1"
168168
_GCB_POST_SUBMIT: "0"
169169
_GCB_LATEST_VERSION: "undefined"
170170
_ARTIFACTS_BUCKET: "gs://open-match-build-artifacts/output/"

install/helm/open-match/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
# limitations under the License.
1414

1515
apiVersion: v2
16-
appVersion: "0.0.0-dev"
17-
version: 0.0.0-dev
16+
appVersion: "1.6.0-rc.1"
17+
version: 1.6.0-rc.1
1818
name: open-match
1919
dependencies:
2020
- name: redis

install/helm/open-match/templates/om-configmap-override.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
{{- if index .Values "open-match-override" }}
15+
{{- if index .Values "open-match-override" "enabled" }}
1616
apiVersion: v1
1717
kind: ConfigMap
1818
metadata:

install/helm/open-match/templates/tests/om-test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ spec:
9191
command: ["go"]
9292
args:
9393
- "test"
94-
- "./internal/testing/e2e"
94+
- "./testing/e2e"
9595
- "-v"
9696
- "-timeout"
9797
- "150s"

install/helm/open-match/values-production.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,10 @@ open-match-customize:
230230
# function:
231231
# image: [YOUR_MMF_IMAGE]
232232

233+
# Controls if users need to install open-match-override ConfigMap.
234+
open-match-override:
235+
enabled: false
236+
233237
# Global configurations that are visible to all subcharts
234238
global:
235239
kubernetes:
@@ -292,7 +296,7 @@ global:
292296
# Use this field if you need to override the image registry and image tag for all services defined in this chart
293297
image:
294298
registry: gcr.io/open-match-public-images
295-
tag: 0.0.0-dev
299+
tag: 1.6.0-rc.1
296300
pullPolicy: Always
297301

298302
# Expose the telemetry configurations to all subcharts because prometheus, for example,

install/helm/open-match/values.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,10 @@ open-match-customize:
228228
# function:
229229
# image: [YOUR_MMF_IMAGE]
230230

231+
# Controls if users need to install open-match-override ConfigMap.
232+
open-match-override:
233+
enabled: false
234+
231235
# Global configurations that are visible to all subcharts
232236
global:
233237
kubernetes:
@@ -290,7 +294,7 @@ global:
290294
# Use this field if you need to override the image registry and image tag for all services defined in this chart
291295
image:
292296
registry: gcr.io/open-match-public-images
293-
tag: 0.0.0-dev
297+
tag: 1.6.0-rc.1
294298
pullPolicy: Always
295299

296300
# Expose the telemetry configurations to all subcharts because prometheus, for example,

internal/config/config.go

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,30 @@ func Read() (*viper.Viper, error) {
5858
return nil, fmt.Errorf("fatal error reading override config file, desc: %s", err.Error())
5959
}
6060

61+
if !cfg.IsSet("registrationInterval") {
62+
log.Printf("config: registrationInterval is not set in matchmaker_config_override.yaml")
63+
}
64+
65+
if !cfg.IsSet("proposalCollectionInterval") {
66+
log.Printf("config: proposalCollectionInterval is not set in matchmaker_config_override.yaml")
67+
}
68+
69+
if !cfg.IsSet("pendingReleaseTimeout") {
70+
log.Printf("config: pendingReleaseTimeout is not set in matchmaker_config_override.yaml")
71+
}
72+
73+
if !cfg.IsSet("assignedDeleteTimeout") {
74+
log.Printf("config: assignedDeleteTimeout is not set in matchmaker_config_override.yaml")
75+
}
76+
77+
if !cfg.IsSet("queryPageSize") {
78+
log.Printf("config: queryPageSize is not set in matchmaker_config_override.yaml")
79+
}
80+
81+
if !cfg.IsSet("backfillLockTimeout") {
82+
log.Printf("config: backfillLockTimeout is not set in matchmaker_config_override.yaml")
83+
}
84+
6185
// Look for updates to the config; in Kubernetes, this is implemented using
6286
// a ConfigMap that is written to the matchmaker_config_override.yaml file, which is
6387
// what the Open Match components using Viper monitor for changes.

internal/rpc/clients_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ import (
3030
"google.golang.org/grpc"
3131
"open-match.dev/open-match/internal/config"
3232
"open-match.dev/open-match/internal/telemetry"
33-
shellTesting "open-match.dev/open-match/internal/testing"
3433
utilTesting "open-match.dev/open-match/internal/util/testing"
3534
"open-match.dev/open-match/pkg/pb"
35+
shellTesting "open-match.dev/open-match/testing"
3636
certgenTesting "open-match.dev/open-match/tools/certgen/testing"
3737
)
3838

internal/rpc/insecure_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import (
2424

2525
"github.com/stretchr/testify/require"
2626
"google.golang.org/grpc"
27-
shellTesting "open-match.dev/open-match/internal/testing"
27+
shellTesting "open-match.dev/open-match/testing"
2828
)
2929

3030
func TestInsecureStartStop(t *testing.T) {

0 commit comments

Comments
 (0)