feat: migrate onClick out of the layout files, add testing (#2328)

* feat(test): Add tests and refactor demos to use ViewBinding

This commit introduces a suite of Espresso tests for several demo activities and refactors numerous activities to use ViewBinding, eliminating `findViewById` and `onClick` XML attributes.

- **Testing Infrastructure:**
    - Adds `MapIdlingResource` for both Java and Kotlin test sources to synchronize Espresso tests with map camera movements, preventing flaky tests.
    - Introduces custom Truth subjects (`LatLngSubject`, `LatLngBoundsSubject`) for more readable and precise assertions on map-related objects, with built-in tolerance for floating-point comparisons.
    - Adds new dependencies for testing: `espresso-idling-resource`, `truth`, and `uiautomator`.
    - Increases Gradle daemon heap size to support test execution.

- **New Espresso Tests:**
    - Adds comprehensive tests for `GroundOverlayDemoActivity`, `CameraClampingDemoActivity`, `IndoorDemoActivity`, `CameraDemoActivity`, and `VisibleRegionDemoActivity` in both Java and Kotlin modules.
    - Tests verify UI interactions, camera behavior, and state changes within the demo activities.

- **Code Refactoring:**
    - Enables ViewBinding in the `java-app`, `kotlin-app`, and `common-ui` modules.
    - Refactors all major demo activities (e.g., `GroundOverlayDemoActivity`, `MarkerDemoActivity`, `CircleDemoActivity`, `UiSettingsDemoActivity`) to use ViewBinding.
    - Replaces `android:onClick` XML attributes with programmatic `setOnClickListener` calls, improving code organization and maintainability.
    - Enhances Javadoc and KDoc in `GroundOverlayDemoActivity` to better explain the concepts and implementation details, improving its educational value.

* feat(androidTest): Refactor GroundOverlayDemoActivityTest and add MapProvider

Refactors the GroundOverlayDemoActivityTest to improve reliability and readability. This commit introduces a `MapProvider` interface and a base `MapDemoActivityTest` class to abstract away common map initialization logic.

Key changes include:
- Add a `MapProvider` interface to ensure activities provide a `GoogleMap` object.
- Create an abstract `MapDemoActivityTest` to handle common test setup, including map initialization and idling resources (WIP).
- Update `GroundOverlayDemoActivityTest` to extend `MapDemoActivityTest`, simplifying its setup logic.
- Replace `Thread.sleep()` calls with `idlingResource.waitForIdle()`.
- Update `GroundOverlayDemoActivity` to use `lateinit` for overlays, preventing nullable types.
- Add `maps-utils-ktx` dependency for idiomatic spherical offset calculations.

* fix(test): Improve CircleDemoActivityTest readability and precision

Enhances the `testLongClickAddsNewCircle` in `CircleDemoActivityTest` by adding
detailed comments that explain the test's flow and the critical reason for
camera movements: to minimize precision loss during LatLng to screen coordinate
conversion for accurate click event simulation.

This commit also includes the necessary `LatLngSubject` extension, introducing
a `isWith(tolerance).of(target)` assertion. This new assertion allows for
more precise and readable verification of spherical distances between `LatLng`
objects, directly supporting the improved test logic in `CircleDemoActivityTest`.

* feat(java): Align CircleDemoActivity and tests with Kotlin version

* refactor(test): Extend MapDemoActivityTest and improve synchronization

Refactors the java version of `GroundOverlayDemoActivityTest` to extend the common `MapDemoActivityTest` base class. This change centralizes test setup, teardown, and map interaction logic, removing redundant code and improving maintainability.

- `GroundOverlayDemoActivity` now implements the `MapProvider` interface to correctly expose the map instance and its ready state to the test framework.
- Replaces `Thread.sleep()` calls in `CircleDemoActivityTest` and `GroundOverlayDemoActivityTest` with `idlingResource.waitForIdle()`. This creates more reliable tests by waiting for map events to complete rather than using fixed delays.
- Adds a `waitForIdle(long)` overload to `MapIdlingResource` to handle cases requiring a brief, controlled pause after the map has settled.

* chore: fix missing copyright headers

* refactor(kotlin): Address lint warnings

This commit applies several small refactorings to the Kotlin demo activities, focusing on code modernization and resolving lint issues.

- In `MarkerDemoActivity`, replaces `Math.max()` with the more idiomatic Kotlin function `coerceAtLeast()`.
- Simplifies trigonometric function calls by using top-level `sin` and `cos` from the Kotlin standard library instead of `Math`.
- Removes unused imports from `MarkerDemoActivity`.
- In `LayersDemoActivity`, adds `@SuppressLint("MissingPermission")` to the `onMyLocationToggled` method to address a lint warning.

* refactor(ui): Use android:name for FragmentContainerView

This commit updates the layout files to use the `android:name` attribute instead of the `class` attribute for `FragmentContainerView` to declare the fragment class. This is the modern, recommended practice.

It also removes minor whitespace and `onClick` attributes that are no longer necessary.

- Replaces the `class` attribute with `android:name` for all instances of `SupportMapFragment` and `SupportStreetViewPanoramaFragment` within `FragmentContainerView` tags across multiple demo layouts.
- Removes unnecessary `onClick` attributes from checkboxes in `layers_demo.xml`.
- Cleans up minor whitespace in `camera_clamping_demo.xml`, `street_view_panorama_navigation_demo.xml`, `indoor_demo.xml`, and `ground_overlay_demo.xml`.

Author: dkhawk

ApiDemos/project/common-ui/build.gradle.kts

@@ -41,6 +41,12 @@ android {
             )
         }
     }
+    lint {
+        abortOnError = false
+    }
+    buildFeatures {
+        viewBinding = true
+    }
     compileOptions {
         sourceCompatibility = JavaVersion.VERSION_17
         targetCompatibility = JavaVersion.VERSION_17

ApiDemos/project/common-ui/src/main/res/layout-land/snapshot_demo.xml

@@ -16,6 +16,7 @@
 -->
 
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    android:id="@+id/map_container"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
     android:orientation="vertical">
@@ -56,13 +57,10 @@
         <Button
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
-            android:onClick="onScreenshot"
             android:text="@string/snapshot_take_button" />
 
         <Button
-            android:layout_width="wrap_content"
             android:layout_height="wrap_content"
-            android:onClick="onClearScreenshot"
-            android:text="@string/snapshot_clear_button" />
+            android:text="@string/snapshot_clear_button"/>
     </LinearLayout>
 </LinearLayout>

ApiDemos/project/common-ui/src/main/res/layout/background_color_customization_demo.xml

@@ -37,7 +37,7 @@
       android:layout_width="0dp"
       android:layout_height="0dp"
       map:backgroundColor="#fff0b2dd"
-      class="com.google.android.gms.maps.SupportMapFragment"
+      android:name="com.google.android.gms.maps.SupportMapFragment"
       app:layout_constraintTop_toBottomOf="@+id/top_bar"
       app:layout_constraintBottom_toBottomOf="parent"
       app:layout_constraintStart_toStartOf="parent"

ApiDemos/project/common-ui/src/main/res/layout/background_color_customization_programmatic_demo.xml

@@ -38,7 +38,7 @@
 
     <androidx.fragment.app.FragmentContainerView
         android:id="@+id/map"
-        class="com.google.android.gms.maps.SupportMapFragment"
+        android:name="com.google.android.gms.maps.SupportMapFragment"
         android:layout_width="0dp"
         android:layout_height="0dp"
         app:layout_constraintBottom_toBottomOf="parent"

ApiDemos/project/common-ui/src/main/res/layout/basic_demo.xml

@@ -32,7 +32,7 @@
 
     <androidx.fragment.app.FragmentContainerView
         android:id="@+id/map"
-        class="com.google.android.gms.maps.SupportMapFragment"
+        android:name="com.google.android.gms.maps.SupportMapFragment"
         android:layout_width="match_parent"
         android:layout_height="match_parent"
         app:layout_constraintBottom_toBottomOf="parent"

ApiDemos/project/common-ui/src/main/res/layout/camera_clamping_demo.xml

@@ -28,15 +28,15 @@
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toTopOf="parent"
-        app:title="@string/background_color_customization_demo_label"
+        app:title="@string/camera_clamping_demo_label"
         app:titleTextColor="?attr/colorOnPrimary" />
     <androidx.fragment.app.FragmentContainerView
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintTop_toBottomOf="@+id/container"
         app:layout_constraintBottom_toBottomOf="parent"
         android:id="@+id/map"
-        class="com.google.android.gms.maps.SupportMapFragment"
+        android:name="com.google.android.gms.maps.SupportMapFragment"
         android:layout_width="fill_parent"
         android:layout_height="fill_parent"
         map:cameraMaxZoomPreference="14.0"
@@ -68,21 +68,18 @@
                 android:id="@+id/clamp_min_zoom"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
-                android:onClick="onSetMinZoomClamp"
                 android:text="@string/clamp_min_zoom" />
 
             <com.google.android.material.button.MaterialButton
                 android:id="@+id/clamp_max_zoom"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
-                android:onClick="onSetMaxZoomClamp"
                 android:text="@string/clamp_max_zoom" />
 
             <com.google.android.material.button.MaterialButton
                 android:id="@+id/clamp_zoom_reset"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
-                android:onClick="onMinMaxZoomClampReset"
                 android:text="@string/clamp_zoom_reset" />
         </LinearLayout>
 
@@ -96,22 +93,19 @@
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:layout_weight="0.5"
-                android:onClick="onClampToAdelaide"
                 android:text="@string/clamp_latlng_adelaide" />
 
             <com.google.android.material.button.MaterialButton
                 android:id="@+id/clamp_latlng_pacific"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:layout_weight="0.5"
-                android:onClick="onClampToPacific"
                 android:text="@string/clamp_latlng_pacific" />
 
             <com.google.android.material.button.MaterialButton
                 android:id="@+id/clamp_latlng_reset"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
-                android:onClick="onLatLngClampReset"
                 android:text="@string/clamp_latlng_reset" />
         </LinearLayout>
 

ApiDemos/project/common-ui/src/main/res/layout/camera_demo.xml

@@ -32,7 +32,7 @@
 
     <androidx.fragment.app.FragmentContainerView
         android:id="@+id/map"
-        class="com.google.android.gms.maps.SupportMapFragment"
+        android:name="com.google.android.gms.maps.SupportMapFragment"
         android:layout_width="match_parent"
         android:layout_height="match_parent" />
 
@@ -55,17 +55,15 @@
                 android:id="@+id/stop_animation"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
-                android:onClick="onStopAnimation"
                 android:text="@string/stop_animation" />
 
             <ToggleButton
                 android:id="@+id/animate"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:checked="true"
-                android:onClick="onToggleAnimate"
-                android:textOff="@string/animate"
-                android:textOn="@string/animate" />
+                android:textOn="@string/animate"
+                android:textOff="@string/animate" />
         </LinearLayout>
 
         <RelativeLayout
@@ -126,15 +124,13 @@
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:minWidth="48dp"
-                android:onClick="onZoomIn"
                 android:text="@string/zoom_in" />
 
             <com.google.android.material.button.MaterialButton
                 android:id="@+id/zoom_out"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:minWidth="48dp"
-                android:onClick="onZoomOut"
                 android:text="@string/zoom_out" />
         </LinearLayout>
 
@@ -149,15 +145,13 @@
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:minWidth="48dp"
-                android:onClick="onTiltMore"
                 android:text="@string/tilt_more" />
 
             <com.google.android.material.button.MaterialButton
                 android:id="@+id/tilt_less"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:minWidth="48dp"
-                android:onClick="onTiltLess"
                 android:text="@string/tilt_less" />
         </LinearLayout>
     </LinearLayout>
@@ -175,12 +169,11 @@
             android:id="@+id/duration_toggle"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
-            android:onClick="onToggleCustomDuration"
             android:text="@string/duration" />
 
         <SeekBar
             android:id="@+id/duration_bar"
-            android:layout_width="match_parent"
+            android:layout_width="0dp"
             android:layout_height="wrap_content"
             android:layout_weight="1"
             android:max="5000" />

ApiDemos/project/common-ui/src/main/res/layout/circle_demo.xml

@@ -127,15 +127,14 @@
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:checked="true"
-                    android:onClick="toggleClickability"
                     android:text="@string/clickable" />
             </TableRow>
 
         </TableLayout>
 
         <androidx.fragment.app.FragmentContainerView
             android:id="@+id/map"
-            class="com.google.android.gms.maps.SupportMapFragment"
+            android:name="com.google.android.gms.maps.SupportMapFragment"
             android:layout_width="match_parent"
             android:layout_height="match_parent" />
 

ApiDemos/project/common-ui/src/main/res/layout/cloud_styling_basic_demo.xml

@@ -34,7 +34,7 @@
 
     <androidx.fragment.app.FragmentContainerView
         android:id="@+id/map"
-        class="com.google.android.gms.maps.SupportMapFragment"
+        android:name="com.google.android.gms.maps.SupportMapFragment"
         android:layout_width="match_parent"
         android:layout_height="match_parent"
         map:cameraTargetLat="47.6089945"

ApiDemos/project/common-ui/src/main/res/layout/events_demo.xml

@@ -31,7 +31,7 @@
 
     <androidx.fragment.app.FragmentContainerView
         android:id="@+id/map"
-        class="com.google.android.gms.maps.SupportMapFragment"
+        android:name="com.google.android.gms.maps.SupportMapFragment"
         android:layout_width="match_parent"
         android:layout_height="match_parent"
         app:layout_constraintTop_toBottomOf="@+id/top_bar" />