Skip to content

Commit 4b22df6

Browse files
authored
fix: Update samples.spec.ts (#293)
Updates the Playwright test to filter on multiple error messages; adds 3D map error message which happens on all 3D apps only in CI testing. They have been verified to work and pass Playwright tests locally.
1 parent 36c1f1e commit 4b22df6

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

e2e/samples.spec.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,14 @@ sampleFolders.forEach((sampleFolder) => {
9292

9393
// There must be no critical console errors.
9494
await errorPromise;
95-
const criticalErrors = consoleErrors.filter(error => !error.includes('Falling back to Raster'));
95+
// Filter out error messages we can safely avoid.
96+
const filteredErrorMessages = [
97+
'Falling back to Raster',
98+
'Attempted to load a 3D Map, but failed.',
99+
];
100+
const criticalErrors = consoleErrors.filter(error =>
101+
!filteredErrorMessages.some(message => error.includes(message))
102+
);
96103
expect(criticalErrors).toHaveLength(0);
97104

98105
// Wait for the page DOM to load; this does NOT include the Google Maps APIs.

0 commit comments

Comments
 (0)