Skip to content

Commit a8fab8f

Browse files
authored
fix: Adds PinElement to fix breaking change. (#239)
1 parent 5ec2086 commit a8fab8f

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

samples/advanced-markers-animation/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
<!-- prettier-ignore -->
2121
<script>(g=>{var h,a,k,p="The Google Maps JavaScript API",c="google",l="importLibrary",q="__ib__",m=document,b=window;b=b[c]||(b[c]={});var d=b.maps||(b.maps={}),r=new Set,e=new URLSearchParams,u=()=>h||(h=new Promise(async(f,n)=>{await (a=m.createElement("script"));e.set("libraries",[...r]+"");for(k in g)e.set(k.replace(/[A-Z]/g,t=>"_"+t[0].toLowerCase()),g[k]);e.set("callback",c+".maps."+q);a.src=`https://maps.${c}apis.com/maps/api/js?`+e;d[q]=f;a.onerror=()=>h=n(Error(p+" could not load."));a.nonce=m.querySelector("script[nonce]")?.nonce||"";m.head.append(a)}));d[l]?console.warn(p+" only loads once. Ignoring:",g):d[l]=(f,...n)=>r.add(f)&&u().then(()=>d[l](f,...n))})
22-
({key: "AIzaSyB41DRUbKWJHPxaFjMAwdrzWzbVKartNGg", v: "weekly"});</script>
22+
({key: "AIzaSyA6myHzS10YXdcazAFalmXvDkrYCp5cLc8", v: "weekly"});</script>
2323
</body>
2424
</html>
2525
<!-- [END maps_advanced_markers_animation] -->

samples/advanced-markers-animation/index.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
async function initMap(): Promise<void> {
4747
// Request needed libraries.
4848
const { Map } = await google.maps.importLibrary("maps") as google.maps.MapsLibrary;
49-
const { AdvancedMarkerElement } = await google.maps.importLibrary("marker") as google.maps.MarkerLibrary;
49+
const { AdvancedMarkerElement, PinElement } = await google.maps.importLibrary("marker") as google.maps.MarkerLibrary;
5050

5151
const position = {lat: 37.4242011827985, lng: -122.09242296450893};
5252

@@ -59,7 +59,7 @@
5959
// Create 100 markers to animate.
6060
google.maps.event.addListenerOnce(map, 'idle', () => {
6161
for (let i = 0; i < 100; i++) {
62-
createMarker(map, AdvancedMarkerElement);
62+
createMarker(map, AdvancedMarkerElement, PinElement);
6363
}
6464
});
6565

@@ -77,12 +77,15 @@
7777
map.controls[google.maps.ControlPosition.TOP_CENTER].push(controlDiv);
7878
}
7979

80-
function createMarker(map, AdvancedMarkerElement) {
80+
function createMarker(map, AdvancedMarkerElement, PinElement) {
81+
const pinElement = new PinElement();
82+
const content = pinElement.element;
8183
const advancedMarker = new AdvancedMarkerElement({
8284
position: getRandomPosition(map),
8385
map: map,
86+
content: content,
8487
});
85-
const content = advancedMarker.content as HTMLElement;
88+
8689
content.style.opacity = '0';
8790
content.addEventListener('animationend', (event) => {
8891
content.classList.remove('drop');

0 commit comments

Comments
 (0)