Skip to content

Commit 2f919ee

Browse files
committed
chore: Create xcframework-specific Cartfile.
Changes introduced in 721a15d aused GitHub checks to fail due to having duplicate URLs in the Cartfile (see: https://github.com/googlemaps/maps-sdk-for-ios-samples/runs/5635557018) This change fixes that error by moving xcframework-specific versioning into its own file. Once this is submitted, I'll update our docs to point to this new file (cl/437090767). Verified that this change passes: https://github.com/googlemaps/maps-sdk-for-ios-samples/actions/runs/2036764574 Change-Id: I112320490f747593ff56c3ed0ca5501680adeec7
1 parent 2bbc04b commit 2f919ee

File tree

3 files changed

+14
-10
lines changed

3 files changed

+14
-10
lines changed

.github/workflows/build.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,11 @@ jobs:
6464
cd snippets
6565
carthage update --platform iOS
6666
67+
- name: Run carthage update (XCFramework)
68+
run: |
69+
cd snippets/MapsBetaSnippets
70+
carthage update --platform iOS
71+
6772
build-MapsSnippets:
6873
runs-on: macos-latest
6974

snippets/Cartfile

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,3 @@ binary "https://dl.google.com/geosdk/GoogleMaps.json" == 6.1.1
55
# [START maps_ios_places_get_started_install_carthage]
66
binary "https://dl.google.com/geosdk/GooglePlaces.json" == 6.1.1
77
# [END maps_ios_places_get_started_install_carthage]
8-
9-
# [START maps_ios_xcframework_get_started_install_carthage]
10-
binary "https://dl.google.com/geosdk/GoogleMaps.json" == 6.1.1-beta
11-
# [END maps_ios_xcframework_get_started_install_carthage]
12-
13-
# [START maps_ios_places_xcframework_get_started_install_carthage]
14-
binary "https://dl.google.com/geosdk/GooglePlaces.json" == 6.1.1-beta
15-
# [END maps_ios_places_xcframework_get_started_install_carthage]
16-
17-

snippets/MapsBetaSnippets/Cartfile

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
# [START maps_ios_xcframework_get_started_install_carthage]
2+
binary "https://dl.google.com/geosdk/GoogleMaps.json" == 6.1.1-beta
3+
# [END maps_ios_xcframework_get_started_install_carthage]
4+
5+
# [START maps_ios_places_xcframework_get_started_install_carthage]
6+
binary "https://dl.google.com/geosdk/GooglePlaces.json" == 6.1.1-beta
7+
# [END maps_ios_places_xcframework_get_started_install_carthage]
8+
9+

0 commit comments

Comments
 (0)