Skip to content

Commit 7df3b17

Browse files
authored
chore: remove rememberMarkerState from samples (#711)
1 parent 807c957 commit 7df3b17

File tree

11 files changed

+31
-31
lines changed

11 files changed

+31
-31
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ Circle(
296296
Markers and other elements need to be recomposed in the screen. To achieve recomposition, you can set mutable properties of state objects:
297297

298298
```kotlin
299-
val markerState = rememberMarkerState(position = singapore)
299+
val markerState = rememberUpdatedMarkerState(position = singapore)
300300

301301
//...
302302

maps-app/src/androidTest/java/com/google/maps/android/compose/GoogleMapViewTests.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ class GoogleMapViewTests {
218218
@Test(expected = IllegalStateException::class)
219219
fun testMarkerStateCannotBeReused() {
220220
initMap {
221-
val markerState = rememberMarkerState()
221+
val markerState = rememberUpdatedMarkerState()
222222
Marker(
223223
state = markerState
224224
)
@@ -231,7 +231,7 @@ class GoogleMapViewTests {
231231
@Test(expected = IllegalStateException::class)
232232
fun testMarkerStateInsideMarkerComposableCannotBeReused() {
233233
initMap {
234-
val markerState = rememberMarkerState()
234+
val markerState = rememberUpdatedMarkerState()
235235
MarkerComposable(
236236
keys = arrayOf("marker1"),
237237
state = markerState,
@@ -254,7 +254,7 @@ class GoogleMapViewTests {
254254
@Test(expected = IllegalStateException::class)
255255
fun testMarkerStateInsideMarkerInfoWindowComposableCannotBeReused() {
256256
initMap {
257-
val markerState = rememberMarkerState()
257+
val markerState = rememberUpdatedMarkerState()
258258
MarkerInfoWindowComposable(
259259
keys = arrayOf("marker1"),
260260
state = markerState,

maps-app/src/main/java/com/google/maps/android/compose/AccessibilityActivity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class AccessibilityActivity : ComponentActivity() {
3737
super.onCreate(savedInstanceState)
3838
enableEdgeToEdge()
3939
setContent {
40-
val singaporeState = rememberMarkerState(position = singapore)
40+
val singaporeState = rememberUpdatedMarkerState(position = singapore)
4141
val cameraPositionState = rememberCameraPositionState {
4242
position = defaultCameraPosition
4343
}

maps-app/src/main/java/com/google/maps/android/compose/BasicMapActivity.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -142,11 +142,11 @@ fun GoogleMapView(
142142
mapColorScheme: ComposeMapColorScheme = ComposeMapColorScheme.FOLLOW_SYSTEM,
143143
content: @Composable () -> Unit = {}
144144
) {
145-
val singaporeState = rememberMarkerState(position = singapore)
146-
val singapore2State = rememberMarkerState(position = singapore2)
147-
val singapore3State = rememberMarkerState(position = singapore3)
148-
val singapore4State = rememberMarkerState(position = singapore4)
149-
val singapore5State = rememberMarkerState(position = singapore5)
145+
val singaporeState = rememberUpdatedMarkerState(position = singapore)
146+
val singapore2State = rememberUpdatedMarkerState(position = singapore2)
147+
val singapore3State = rememberUpdatedMarkerState(position = singapore3)
148+
val singapore4State = rememberUpdatedMarkerState(position = singapore4)
149+
val singapore5State = rememberUpdatedMarkerState(position = singapore5)
150150

151151
var circleCenter by remember { mutableStateOf(singapore) }
152152
if (!singaporeState.isDragging) {

maps-app/src/main/java/com/google/maps/android/compose/MapInColumnActivity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ private fun GoogleMapViewInColumn(
185185
cameraPositionState: CameraPositionState,
186186
onMapLoaded: () -> Unit,
187187
) {
188-
val singaporeState = rememberMarkerState(position = singapore)
188+
val singaporeState = rememberUpdatedMarkerState(position = singapore)
189189

190190
var uiSettings by remember { mutableStateOf(MapUiSettings(compassEnabled = false)) }
191191
var mapProperties by remember {

maps-app/src/main/java/com/google/maps/android/compose/RecompositionActivity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ class RecompositionActivity : ComponentActivity() {
7070
cameraPositionState: CameraPositionState = rememberCameraPositionState(),
7171
content: @Composable () -> Unit = {},
7272
) {
73-
val markerState = rememberMarkerState(position = singapore)
73+
val markerState = rememberUpdatedMarkerState(position = singapore)
7474

7575
val uiSettings by remember { mutableStateOf(MapUiSettings(compassEnabled = false)) }
7676
val mapProperties by remember {

maps-app/src/main/java/com/google/maps/android/compose/markerexamples/AdvancedMarkersActivity.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ import com.google.maps.android.compose.GoogleMap
4444
import com.google.maps.android.compose.MapProperties
4545
import com.google.maps.android.compose.MapType
4646
import com.google.maps.android.compose.rememberCameraPositionState
47-
import com.google.maps.android.compose.rememberMarkerState
47+
import com.google.maps.android.compose.rememberUpdatedMarkerState
4848

4949

5050
private const val TAG = "AdvancedMarkersActivity"
@@ -70,10 +70,10 @@ class AdvancedMarkersActivity : ComponentActivity(), OnMapsSdkInitializedCallbac
7070
val mapProperties by remember {
7171
mutableStateOf(MapProperties(mapType = MapType.NORMAL))
7272
}
73-
val marker1State = rememberMarkerState(position = santiago)
74-
val marker2State = rememberMarkerState(position = bogota)
75-
val marker3State = rememberMarkerState(position = lima)
76-
val marker4State = rememberMarkerState(position = salvador)
73+
val marker1State = rememberUpdatedMarkerState(position = santiago)
74+
val marker2State = rememberUpdatedMarkerState(position = bogota)
75+
val marker3State = rememberUpdatedMarkerState(position = lima)
76+
val marker4State = rememberUpdatedMarkerState(position = salvador)
7777

7878
// Drawing on the map is accomplished with a child-based API
7979
val markerClick: (Marker) -> Boolean = {

maps-app/src/main/java/com/google/maps/android/compose/markerexamples/MarkerClusteringActivity.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ import com.google.maps.android.compose.clustering.Clustering
5050
import com.google.maps.android.compose.clustering.rememberClusterManager
5151
import com.google.maps.android.compose.clustering.rememberClusterRenderer
5252
import com.google.maps.android.compose.rememberCameraPositionState
53-
import com.google.maps.android.compose.rememberMarkerState
53+
import com.google.maps.android.compose.rememberUpdatedMarkerState
5454
import com.google.maps.android.compose.singapore
5555
import com.google.maps.android.compose.singapore2
5656
import kotlin.random.Random
@@ -119,7 +119,7 @@ fun GoogleMapClustering(items: List<MyItem>) {
119119
}
120120

121121
MarkerInfoWindow(
122-
state = rememberMarkerState(position = singapore),
122+
state = rememberUpdatedMarkerState(position = singapore),
123123
onClick = {
124124
Log.d(TAG, "Non-cluster marker clicked! $it")
125125
true

maps-app/src/main/java/com/google/maps/android/compose/markerexamples/markerdragevents/MarkerDragEventsActivity.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import com.google.maps.android.compose.GoogleMap
3030
import com.google.maps.android.compose.Marker
3131
import com.google.maps.android.compose.defaultCameraPosition
3232
import com.google.maps.android.compose.rememberCameraPositionState
33-
import com.google.maps.android.compose.rememberMarkerState
33+
import com.google.maps.android.compose.rememberUpdatedMarkerState
3434
import com.google.maps.android.compose.singapore
3535
import com.google.maps.android.compose.theme.MapsComposeSampleTheme
3636
import kotlinx.coroutines.flow.dropWhile
@@ -87,7 +87,7 @@ private fun DraggableMarker(
8787
onDrag: (LatLng) -> Unit = {},
8888
onDragEnd: () -> Unit = {}
8989
) {
90-
val markerState = rememberMarkerState(position = singapore)
90+
val markerState = rememberUpdatedMarkerState(position = singapore)
9191

9292
Marker(
9393
state = markerState,

maps-app/src/main/java/com/google/maps/android/compose/markerexamples/syncingdraggablemarkerwithdatamodel/SyncingDraggableMarkerWithDataModelActivity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ private fun LocationMarker(
148148
// It is the price we pay for having source of truth baked into
149149
// com.google.android.gms.maps.model.Marker, and consequently MarkerState.
150150
//
151-
// Do not use rememberMarkerState() here, because it uses rememberSaveable();
151+
// Do not use rememberUpdatedMarkerState() here, because it uses rememberSaveable();
152152
// we want to save the position to persistent storage as part of our data model
153153
// instead - rememberSaveable() would add a conflicting source of truth.
154154
val markerState = remember { MarkerState(locationData.position) }

0 commit comments

Comments
 (0)