chore: added lint report (#1406)

* chore: added lint report

* chore: change path

* chore: updated CodeQL

* chore: get rid of deprecation

* chore: get rid of deprecation

* chore: merging several reports

* chore: removed some lint warnings

* chore: headers

Author: kikoso

.github/workflows/lint-report.yml

@@ -0,0 +1,49 @@
+# Copyright 2024 Google LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Lint and Upload SARIF
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    branches:
+      - main
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+
+      - name: Set up JDK 17
+        uses: actions/setup-java@v3
+        with:
+          distribution: 'adopt'
+          java-version: '17'
+
+      - name: Run Android Lint
+        run: ./gradlew lint
+
+      - name: Merge SARIF files
+        run: |
+          jq -s '{ "$schema": "https://json.schemastore.org/sarif-2.1.0", "version": "2.1.0", "runs": map(.runs) | add }'  library/build/reports/lint-results-debug.sarif  demo/build/reports/lint-results-debug.sarif > merged.sarif
+
+      - name: Upload SARIF file
+        uses: github/codeql-action/upload-sarif@v3
+        with:
+          sarif_file: merged.sarif

demo/build.gradle

@@ -21,6 +21,9 @@ plugins {
 }
 
 android {
+    lintOptions {
+        sarifOutput = file("$buildDir/reports/lint-results.sarif")
+    }
 
     defaultConfig {
         compileSdk 34

demo/src/main/java/com/google/maps/android/utils/demo/ClusteringViewModelDemoActivity.java

@@ -29,7 +29,6 @@
 import org.json.JSONException;
 
 public class ClusteringViewModelDemoActivity extends BaseDemoActivity {
-    private ClusterManager<MyItem> mClusterManager;
     private ClusteringViewModel mViewModel;
 
     @Override
@@ -59,7 +58,7 @@ protected void startDemo(boolean isRestore) {
 
         mViewModel.getAlgorithm().updateViewSize(widthDp, heightDp);
 
-        mClusterManager = new ClusterManager<>(this, getMap());
+        ClusterManager<MyItem> mClusterManager = new ClusterManager<>(this, getMap());
         mClusterManager.setAlgorithm(mViewModel.getAlgorithm());
 
         getMap().setOnCameraIdleListener(mClusterManager);

demo/src/main/java/com/google/maps/android/utils/demo/CustomAdvancedMarkerClusteringDemoActivity.java

@@ -16,8 +16,10 @@
 
 package com.google.maps.android.utils.demo;
 
+import java.util.Objects;
 import java.util.Random;
 
+import android.annotation.SuppressLint;
 import android.graphics.Color;
 import android.util.Log;
 import android.view.View;
@@ -94,6 +96,7 @@ private PinConfig.Builder getPinConfig() {
             return pinConfigBuilder;
         }
 
+        @SuppressLint("SetTextI18n")
         private View addTextAsMarker(int size) {
             TextView textView = new TextView(getApplicationContext());
             textView.setText("I am a cluster of size " + size);
@@ -143,7 +146,7 @@ public boolean onClusterClick(Cluster<Person> cluster) {
         try {
             getMap().animateCamera(CameraUpdateFactory.newLatLngBounds(bounds, 100));
         } catch (Exception e) {
-            e.printStackTrace();
+            Log.e("MapsDemo", Objects.requireNonNull(e.getMessage()));
         }
 
         return true;

demo/src/main/java/com/google/maps/android/utils/demo/CustomMarkerClusteringDemoActivity.java

@@ -48,7 +48,7 @@
  */
 public class CustomMarkerClusteringDemoActivity extends BaseDemoActivity implements ClusterManager.OnClusterClickListener<Person>, ClusterManager.OnClusterInfoWindowClickListener<Person>, ClusterManager.OnClusterItemClickListener<Person>, ClusterManager.OnClusterItemInfoWindowClickListener<Person> {
     private ClusterManager<Person> mClusterManager;
-    private Random mRandom = new Random(1984);
+    private final Random mRandom = new Random(1984);
 
     /**
      * Draws profile photos inside markers (using IconGenerator).

demo/src/main/java/com/google/maps/android/utils/demo/DistanceDemoActivity.java

@@ -16,6 +16,7 @@
 
 package com.google.maps.android.utils.demo;
 
+import android.annotation.SuppressLint;
 import android.widget.TextView;
 import android.widget.Toast;
 
@@ -60,6 +61,7 @@ protected void startDemo(boolean isRestore) {
         showDistance();
     }
 
+    @SuppressLint("SetTextI18n")
     private void showDistance() {
         double distance = SphericalUtil.computeDistanceBetween(mMarkerA.getPosition(), mMarkerB.getPosition());
         mTextView.setText("The markers are " + formatNumber(distance) + " apart.");

demo/src/main/java/com/google/maps/android/utils/demo/StreetViewDemoActivity.kt

@@ -16,6 +16,7 @@
 
 package com.google.maps.android.utils.demo
 
+import android.annotation.SuppressLint
 import android.app.Activity
 import android.os.Bundle
 import android.widget.TextView
@@ -29,6 +30,7 @@ import kotlinx.coroutines.launch
 
 class StreetViewDemoActivity : Activity() {
 
+    @SuppressLint("SetTextI18n")
     @OptIn(DelicateCoroutinesApi::class)
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)

demo/src/main/res/layout/distance_demo.xml

@@ -1,18 +1,18 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!--
-  ~ Copyright 2020 Google Inc.
-  ~
-  ~ Licensed under the Apache License, Version 2.0 (the "License");
-  ~ you may not use this file except in compliance with the License.
-  ~ You may obtain a copy of the License at
-  ~
-  ~      http://www.apache.org/licenses/LICENSE-2.0
-  ~
-  ~ Unless required by applicable law or agreed to in writing, software
-  ~ distributed under the License is distributed on an "AS IS" BASIS,
-  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  ~ See the License for the specific language governing permissions and
-  ~ limitations under the License.
+ Copyright 2024 Google LLC
+
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
 -->
 
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
@@ -25,7 +25,7 @@
             android:layout_height="wrap_content"
             android:id="@+id/textView"/>
 
-    <fragment android:id="@+id/map"
+    <androidx.fragment.app.FragmentContainerView android:id="@+id/map"
               android:layout_width="match_parent"
               android:layout_height="match_parent"
               android:name="com.google.android.gms.maps.SupportMapFragment"/>

demo/src/main/res/layout/geojson_demo.xml

@@ -1,18 +1,18 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!--
-  ~ Copyright 2020 Google Inc.
-  ~
-  ~ Licensed under the Apache License, Version 2.0 (the "License");
-  ~ you may not use this file except in compliance with the License.
-  ~ You may obtain a copy of the License at
-  ~
-  ~      http://www.apache.org/licenses/LICENSE-2.0
-  ~
-  ~ Unless required by applicable law or agreed to in writing, software
-  ~ distributed under the License is distributed on an "AS IS" BASIS,
-  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  ~ See the License for the specific language governing permissions and
-  ~ limitations under the License.
+ Copyright 2024 Google LLC
+
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
 -->
 
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
@@ -21,7 +21,7 @@
               android:layout_width="match_parent"
               android:layout_height="match_parent">
 
-    <fragment
+    <androidx.fragment.app.FragmentContainerView
             android:id="@+id/map"
             android:layout_width="match_parent"
             android:layout_height="0dp"

demo/src/main/res/layout/heatmaps_demo.xml

@@ -1,18 +1,18 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!--
-  ~ Copyright 2020 Google Inc.
-  ~
-  ~ Licensed under the Apache License, Version 2.0 (the "License");
-  ~ you may not use this file except in compliance with the License.
-  ~ You may obtain a copy of the License at
-  ~
-  ~      http://www.apache.org/licenses/LICENSE-2.0
-  ~
-  ~ Unless required by applicable law or agreed to in writing, software
-  ~ distributed under the License is distributed on an "AS IS" BASIS,
-  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  ~ See the License for the specific language governing permissions and
-  ~ limitations under the License.
+ Copyright 2024 Google LLC
+
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
 -->
 
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
@@ -54,7 +54,7 @@
         android:layout_width="fill_parent"
         android:layout_height="wrap_content" />
 
-    <fragment
+    <androidx.fragment.app.FragmentContainerView
         android:id="@+id/map"
         android:layout_width="match_parent"
         android:layout_height="0dp"