Skip to content

v2.2.6 release was missing compiled code #1016

@barbeau

Description

@barbeau

Summary

Reported in #1008 (comment):

I took your sample code and tested it and found indeed there is something weird going on here, but it's actually a problem with the v2.2.6 build itself.

I was able to reproduce what you were seeing with v2.2.6, but not if I copied the MapObjectManager and MarkerManager source code directly to my app, unmodified. I then tested v2.3.0 and this version works as expected. Using the debugger again on v2.2.6, I see that the mObjects variable is actually a HashSet still!

For some reason, the v2.2.6 build that my PR's changes were released in does not have the change in the decompiled binary aar! It is in the source code jar though, which is even more confusing. And the change is in the v2.3.0 binary.

Screenshot 2021-10-26 142228

So v2.2.6 release didn't contain the compiled code that it should have, although v2.3.0 seems ok.

Expected behavior

All changes in main project branch should be included in releases

Observed behavior

PR's changes released in #972 (comment) does not have the change in the decompiled binary aar.

It is in the source code jar though, which is even more confusing. And the change is in the v2.3.0 binary.

Metadata

Metadata

Assignees

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions