feat!: implement consolidated error codes for getDeliveryVehicle (#73)

* feat!: implement consolidated error codes for getDeliveryVehicle

- Add GET_DELIVERY_VEHICLE_ERROR_CODE constant to Android JsErrors.java
- Update iOS error constants to match Android naming convention
- Replace raw exception rejection with consolidated error code on Android
- Ensure error codes and messages are identical across platforms

BREAKING CHANGE: getDeliveryVehicle error code updated to GET_DELIVERY_VEHICLE_ERROR_CODE

Author: jokerttu

android/src/main/java/com/google/android/react/driversdk/lmfs/DeliveryDriverModule.java

@@ -193,8 +193,10 @@ public void onSuccess(DeliveryVehicle deliveryVehicle) {
           }
 
           public void onFailure(@NonNull Throwable thrown) {
-            // TODO: Expose proper gRPC Error code to RN.
-            promise.reject(thrown);
+            promise.reject(
+                JsErrors.GET_DELIVERY_VEHICLE_ERROR_CODE,
+                JsErrors.GET_DELIVERY_VEHICLE_ERROR_MESSAGE,
+                thrown);
           }
         },
         // causes the callbacks to be executed on the main (UI) thread

android/src/main/java/com/google/android/react/driversdk/shared/JsErrors.java

@@ -43,4 +43,8 @@ public class JsErrors {
   public static final String DRIVER_API_NOT_INITIALIZED_CODE = "DRIVER_API_NOT_INITIALIZED_CODE";
   public static final String DRIVER_API_NOT_INITIALIZED_MESSAGE =
       "Driver API has not been initialized.";
+
+  public static final String GET_DELIVERY_VEHICLE_ERROR_CODE = "GET_DELIVERY_VEHICLE_ERROR_CODE";
+  public static final String GET_DELIVERY_VEHICLE_ERROR_MESSAGE =
+      "Failed to retrieve delivery vehicle information.";
 }

ios/DeliveryDriverController.m

@@ -81,8 +81,7 @@ - (void)getDeliveryVehicle:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseR
   [_driverAPI.deliveryVehicleManager
       getVehicleWithCompletion:^(GMTDDeliveryVehicle *_Nullable vehicle, NSError *_Nullable error) {
         if (error != nil || vehicle == nil) {
-          reject(kDriverApiFailedToGetDeliveryVehicleCode,
-                 kDriverApiFailedToGetDeliveryVehicleMessage, nil);
+          reject(kGetDeliveryVehicleErrorCode, kGetDeliveryVehicleErrorMessage, error);
           return;
         }
 

ios/JsErrorsConstants.h

@@ -22,5 +22,5 @@ extern NSString* const kDriverApiAlreadyExistsErrorCode;
 extern NSString* const kDriverApiAlreadyExistsErrorMessage;
 extern NSString* const kNavigatorNotInitializedErrorCode;
 extern NSString* const kNavigatorNotInitializedErrorMessage;
-extern NSString* const kDriverApiFailedToGetDeliveryVehicleCode;
-extern NSString* const kDriverApiFailedToGetDeliveryVehicleMessage;
+extern NSString* const kGetDeliveryVehicleErrorCode;
+extern NSString* const kGetDeliveryVehicleErrorMessage;

ios/JsErrorsConstants.m

@@ -23,7 +23,6 @@
 NSString* const kDriverApiAlreadyExistsErrorMessage = @"Driver API already exists.";
 NSString* const kNavigatorNotInitializedErrorCode = @"NO_NAVIGATOR_CODE";
 NSString* const kNavigatorNotInitializedErrorMessage = @"Navigator is not initialized.";
-NSString* const kDriverApiFailedToGetDeliveryVehicleCode =
-    @"DRIVER_API_FAILED_TO_GET_DELIVERY_VEHICLE";
-NSString* const kDriverApiFailedToGetDeliveryVehicleMessage =
-    @"There was an error retrieving the delivery vehicle";
+NSString* const kGetDeliveryVehicleErrorCode = @"GET_DELIVERY_VEHICLE_ERROR_CODE";
+NSString* const kGetDeliveryVehicleErrorMessage =
+    @"Failed to retrieve delivery vehicle information.";