fix!: create bitmapdescriptor from asset on android (#347)

Breaking change due to changes in the native implementation for imgPath
Release-As: 0.9.0

Author: jokerttu

android/src/main/java/com/google/android/react/navsdk/MapViewController.java

@@ -144,7 +144,7 @@ public Marker addMarker(Map<String, Object> optionsMap) {
 
     MarkerOptions options = new MarkerOptions();
     if (imagePath != null && !imagePath.isEmpty()) {
-      BitmapDescriptor icon = BitmapDescriptorFactory.fromPath(imagePath);
+      BitmapDescriptor icon = BitmapDescriptorFactory.fromAsset(imagePath);
       options.icon(icon);
     }
 
@@ -290,7 +290,7 @@ public GroundOverlay addGroundOverlay(Map<String, Object> map) {
 
     GroundOverlayOptions options = new GroundOverlayOptions();
     if (imagePath != null && !imagePath.isEmpty()) {
-      BitmapDescriptor bitmapDescriptor = BitmapDescriptorFactory.fromPath(imagePath);
+      BitmapDescriptor bitmapDescriptor = BitmapDescriptorFactory.fromAsset(imagePath);
       options.image(bitmapDescriptor);
     }
     options.position(new LatLng(lat, lng), width, height);

example/android/app/build.gradle

@@ -65,7 +65,7 @@ react {
     // hermesFlags = ["-O", "-output-source-map"]
 
     /* This example app uses typescript index file, so we need to specify the entry file */
-    entryFile = file("index.ts")
+    entryFile = file("../../index.ts")
 
     /* Autolinking */
     autolinkLibrariesWithApp()

example/android/app/src/main/assets/circle.png

@@ -1,6 +1,6 @@
 {
   "info" : {
-    "version" : 1,
-    "author" : "xcode"
+    "author" : "xcode",
+    "version" : 1
   }
 }

example/ios/SampleApp/Images.xcassets/Contents.json

@@ -0,0 +1,21 @@
+{
+  "images" : [
+    {
+      "filename" : "circle.png",
+      "idiom" : "universal",
+      "scale" : "1x"
+    },
+    {
+      "idiom" : "universal",
+      "scale" : "2x"
+    },
+    {
+      "idiom" : "universal",
+      "scale" : "3x"
+    }
+  ],
+  "info" : {
+    "author" : "xcode",
+    "version" : 1
+  }
+}

example/ios/SampleApp/Images.xcassets/circle.imageset/Contents.json

@@ -106,7 +106,7 @@ const MapsControls: React.FC<MapControlsProps> = ({ mapViewController }) => {
     console.log(result);
   };
 
-  const addMarker = async () => {
+  const addMarker = async (imgPath?: string) => {
     const cameraPosition = await mapViewController.getCameraPosition();
 
     const marker: Marker = await mapViewController.addMarker({
@@ -115,14 +115,19 @@ const MapsControls: React.FC<MapControlsProps> = ({ mapViewController }) => {
       title: 'Marker test',
       snippet: 'Marker test',
       alpha: 0.8,
-      rotation: 20,
+      rotation: 0,
       flat: false,
       draggable: true,
+      imgPath: imgPath,
     });
 
     console.log(marker);
   };
 
+  const addCustomMarker = async () => {
+    addMarker('circle.png');
+  };
+
   const addCircle = async () => {
     const cameraPosition = await mapViewController.getCameraPosition();
 
@@ -221,7 +226,8 @@ const MapsControls: React.FC<MapControlsProps> = ({ mapViewController }) => {
           setZoom((zoom ?? defaultZoom) - 1);
         }}
       />
-      <Button title="Add marker" onPress={addMarker} />
+      <Button title="Add marker" onPress={() => addMarker()} />
+      <Button title="Add custom marker" onPress={() => addCustomMarker()} />
       <Button title="Add circle" onPress={addCircle} />
       <Button title="Add polyline" onPress={addPolyline} />
       <Button title="Add polygon" onPress={addPolygon} />