Skip to content

Conversation

@jokerttu
Copy link
Contributor

@jokerttu jokerttu commented Nov 26, 2025

Improves error handling and guards for navigation session method calls.
Adds NO_DESTINATIONS error for android implementation if start guidance is called without destinations set.
Adds detox tests.

BREAKING CHANGE:
no_destinations error string on iOS is changed to NO_DESTINATIONS matching other error code formats and Android implementation

Fixes #498

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation
  • I added new tests to check the change I am making
  • All existing and new tests are passing.

@jokerttu jokerttu force-pushed the fix/error-handling-for-navigator-methods branch from 7c32c36 to ff991e1 Compare November 26, 2025 13:59
@jokerttu jokerttu force-pushed the fix/error-handling-for-navigator-methods branch from ff991e1 to ddaa3db Compare November 26, 2025 14:02
@jokerttu jokerttu merged commit a8ddabb into main Nov 27, 2025
12 checks passed
@jokerttu jokerttu deleted the fix/error-handling-for-navigator-methods branch November 27, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Stopping guidance throws error

3 participants