Skip to content

Commit 002ff92

Browse files
LiedtkeV8-internal LUCI CQ
authored andcommitted
Revert "Set a lower limit for max variables"
This reverts commit 377cbe5. Reason for revert: Experiment concluded, knowledge gained, further actions will be taken in follow-ups. The high number of variables appear when importing some test case(s) defining array literals with thousands of entries. Those imported test cases originate as far as we can tell from JS test cases, not from Fuzzilli itself generating such huge cases. Bug: 433646300 Original change's description: > Set a lower limit for max variables > > Bug: 433646300 > Change-Id: Icbcf88d431a255a3f6df6ca113e6c784e5b96e2c > Reviewed-on: https://chrome-internal-review.googlesource.com/c/v8/fuzzilli/+/8446876 > Reviewed-by: Carl Smith <[email protected]> > Reviewed-by: Michael Achenbach <[email protected]> > Commit-Queue: Matthias Liedtke <[email protected]> Bug: 433646300 Change-Id: Ibec37070a30fd3f70a588028a4c96a507475fe97 Reviewed-on: https://chrome-internal-review.googlesource.com/c/v8/fuzzilli/+/8451656 Commit-Queue: Matthias Liedtke <[email protected]> Bot-Commit: Rubber Stamper <[email protected]>
1 parent 324bb4c commit 002ff92

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

Sources/Fuzzilli/Base/ProgramBuilder.swift

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3997,13 +3997,7 @@ public class ProgramBuilder {
39973997

39983998
/// Returns the next free variable.
39993999
func nextVariable() -> Variable {
4000-
// Temporarily introduce a lower limit: Programs shouldn't get exceedingly large.
4001-
// TODO(mliedtke): Undo this once the issues are fixed.
4002-
let maxNumberOfVariables = 10_000
4003-
assert(maxNumberOfVariables <= Code.maxNumberOfVariables)
4004-
if numVariables >= maxNumberOfVariables {
4005-
fatalError("Too many variables \(numVariables). Contributors: \(contributors.map {$0.name})")
4006-
}
4000+
assert(numVariables < Code.maxNumberOfVariables, "Too many variables")
40074001
numVariables += 1
40084002
return Variable(number: numVariables - 1)
40094003
}

0 commit comments

Comments
 (0)