Skip to content

Commit 5250979

Browse files
evicyV8-internal LUCI CQ
authored andcommitted
[wasm] Reduce SIMD, branch and branchif generator weights
Branch and branchif generators might generate many endless loops. Otherwise, the simd instructions got maybe a too high weight (which makes sense in the beginning). Change-Id: I92c15162aeaac5ab8941721febeb4c93b03a6b28 Reviewed-on: https://chrome-internal-review.googlesource.com/c/v8/fuzzilli/+/7977729 Commit-Queue: Eva Herencsárová <[email protected]> Reviewed-by: Carl Smith <[email protected]>
1 parent f671b64 commit 5250979

File tree

2 files changed

+11
-12
lines changed

2 files changed

+11
-12
lines changed

Sources/Fuzzilli/CodeGen/CodeGeneratorWeights.swift

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -279,20 +279,20 @@ public let codeGeneratorWeights = [
279279
"WasmLegacyTryDelegateGenerator": 8,
280280
"WasmThrowGenerator": 2,
281281
"WasmRethrowGenerator": 10,
282-
"WasmBranchGenerator": 10,
283-
"WasmBranchIfGenerator": 10,
282+
"WasmBranchGenerator": 6,
283+
"WasmBranchIfGenerator": 6,
284284
"WasmJsCallGenerator": 30,
285285

286286
// Simd Generators
287-
"ConstSimd128Generator": 10,
288-
"WasmSimd128IntegerUnOpGenerator": 10,
289-
"WasmSimd128IntegerBinOpGenerator": 10,
290-
"WasmSimd128FloatUnOpGenerator": 10,
291-
"WasmSimd128FloatBinOpGenerator": 10,
292-
"WasmSimd128CompareGenerator": 10,
293-
"WasmI64x2SplatGenerator": 10,
294-
"WasmI64x2ExtractLaneGenerator": 10,
295-
"WasmI64x2LoadSplatGenerator": 10,
287+
"ConstSimd128Generator": 5,
288+
"WasmSimd128IntegerUnOpGenerator": 5,
289+
"WasmSimd128IntegerBinOpGenerator": 5,
290+
"WasmSimd128FloatUnOpGenerator": 5,
291+
"WasmSimd128FloatBinOpGenerator": 5,
292+
"WasmSimd128CompareGenerator": 5,
293+
"WasmI64x2SplatGenerator": 5,
294+
"WasmI64x2ExtractLaneGenerator": 5,
295+
"WasmI64x2LoadSplatGenerator": 5,
296296

297297
"WasmSelectGenerator": 10,
298298
]

Tests/FuzzilliTests/LiveTests.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ class LiveTests: XCTestCase {
9797
}
9898
}
9999

100-
// TODO(cffsmith): Try to lower this
101100
// We expect a maximum of 25% of Wasm execution attempts to fail.
102101
checkFailureRate(testResults: results, maxFailureRate: 0.25)
103102
}

0 commit comments

Comments
 (0)