[wasm] Add float binary operations for relaxed SIMD

This adds relaxed_min and relaxed_max from the relaxed SIMD proposal.

Bug: 427134596
Change-Id: I2b00d22e96feb03f740e3762b3dddb620eddd5ac
Reviewed-on: https://chrome-internal-review.googlesource.com/c/v8/fuzzilli/+/8443159
Commit-Queue: Danylo Mocherniuk <[email protected]>
Reviewed-by: Matthias Liedtke <[email protected]>

Author: danylo1999

Sources/Fuzzilli/FuzzIL/WasmOperations.swift

@@ -1595,9 +1595,18 @@ public enum WasmSimd128FloatBinOpKind: Int, CaseIterable {
     case pmin = 6
     case pmax = 7
 
+    // f32x4: 0x100 + offset
+    // f64x2: 0x102 + offset
+    case relaxed_min = 13
+    case relaxed_max = 14
+
     func isValidForShape(shape: WasmSimd128Shape) -> Bool {
         return shape.isFloat()
     }
+
+    func isRelaxed() -> Bool {
+        return self == .relaxed_min || self == .relaxed_max
+    }
 }
 
 final class WasmSimd128FloatBinOp: WasmOperation {
@@ -1611,6 +1620,15 @@ final class WasmSimd128FloatBinOp: WasmOperation {
         self.binOpKind = binOpKind
         super.init(numInputs: 2, numOutputs: 1, attributes: [.isMutable], requiredContext: [.wasmFunction])
     }
+
+    func getOpcode() -> Int {
+        let base = if(binOpKind.isRelaxed()) {
+            shape == .f32x4 ? 0x100 : 0x102;
+        } else {
+            shape == .f32x4 ? 0xE4 : 0xF0;
+        }
+        return base + binOpKind.rawValue
+    }
 }
 
 final class WasmSimdSplat: WasmOperation {

Sources/Fuzzilli/Lifting/WasmLifter.swift

@@ -1918,9 +1918,8 @@ public class WasmLifter {
             }
             return Data([Prefix.Simd.rawValue]) + encoding
         case .wasmSimd128FloatBinOp(let op):
-            assert(WasmSimd128FloatBinOpKind.allCases.count == 8, "New WasmSimd128FloatBinOpKind added: check if the encoding is still correct!")
-            let base = (op.shape == .f32x4) ? 0xE4 : 0xF0;
-            return Data([Prefix.Simd.rawValue]) + Leb128.unsignedEncode(base + op.binOpKind.rawValue) + Leb128.unsignedEncode(0x01)
+            assert(WasmSimd128FloatBinOpKind.allCases.count == 10, "New WasmSimd128FloatBinOpKind added: check if the encoding is still correct!")
+            return Data([Prefix.Simd.rawValue]) + Leb128.unsignedEncode(op.getOpcode()) + Leb128.unsignedEncode(0x01)
         case .wasmSimd128Compare(let op):
             assert(WasmIntegerCompareOpKind.allCases.count == 10, "New WasmIntegerCompareOpKind added: check if the encoding is still correct!")
             assert(WasmFloatCompareOpKind.allCases.count == 6, "New WasmFloatCompareOpKind added: check if the encoding is still correct!")

Tests/FuzzilliTests/WasmTests.swift

@@ -2271,7 +2271,7 @@ class WasmFoundationTests: XCTestCase {
                     let result = function.wasmSimd128FloatBinOp(varA, varB, WasmSimd128Shape.f32x4, WasmSimd128FloatBinOpKind.add)
                     return (0..<4).map {function.wasmSimdExtractLane(kind: WasmSimdExtractLane.Kind.F32x4, result, $0)}
                 }
-            },"4.8[0-9]*,7.4[0-9]*,9.6[0-9]*,11.8[0-9]*"), // for floating point math need to allow trailing digits
+            },"4.8[0-9]*,7.4[0-9]*,9.6[0-9]*,11.8[0-9]*"), // for floating point math need to allow trailing digits and take into account rounding issues
             // Test float sub
             ({wasmModule in
                 let returnType = (0..<4).map {_ in ILType.wasmf32}
@@ -2281,7 +2281,7 @@ class WasmFoundationTests: XCTestCase {
                     let result = function.wasmSimd128FloatBinOp(varA, varB, WasmSimd128Shape.f32x4, WasmSimd128FloatBinOpKind.sub)
                     return (0..<4).map {function.wasmSimdExtractLane(kind: WasmSimdExtractLane.Kind.F32x4, result, $0)}
                 }
-            },"4.8[0-9]*,-4.4[0-9]*,4.4[0-9]*,4.4[0-9]*"), // for floating point math need to allow trailing digits
+            },"4.8[0-9]*,-4.4[0-9]*,4.4[0-9]*,4.4[0-9]*"),
             // Test float mul
             ({wasmModule in
                 let returnType = (0..<4).map {_ in ILType.wasmf32}
@@ -2291,7 +2291,7 @@ class WasmFoundationTests: XCTestCase {
                     let result = function.wasmSimd128FloatBinOp(varA, varB, WasmSimd128Shape.f32x4, WasmSimd128FloatBinOpKind.mul)
                     return (0..<4).map {function.wasmSimdExtractLane(kind: WasmSimdExtractLane.Kind.F32x4, result, $0)}
                 }
-            },"0,8.85[0-9]*,(18.1[0-9]*|18.2[0-9]*),29.97[0-9]*"), // for floating point math need to allow trailing digits and take into account rounding issues
+            },"0,8.85[0-9]*,(18.1[0-9]*|18.2[0-9]*),29.97[0-9]*"),
             // Test float div
             ({wasmModule in
                 let returnType = (0..<4).map {_ in ILType.wasmf32}
@@ -2301,7 +2301,7 @@ class WasmFoundationTests: XCTestCase {
                     let result = function.wasmSimd128FloatBinOp(varA, varB, WasmSimd128Shape.f32x4, WasmSimd128FloatBinOpKind.div)
                     return (0..<4).map {function.wasmSimdExtractLane(kind: WasmSimdExtractLane.Kind.F32x4, result, $0)}
                 }
-            },"0,0.2542[0-9]*,2.6923[0-9]*,2.1891[0-9]*"), // for floating point math need to allow trailing digits and take into account rounding issues
+            },"0,0.2542[0-9]*,2.6923[0-9]*,2.1891[0-9]*"),
             // Test float min
             ({wasmModule in
                 let returnType = (0..<4).map {_ in ILType.wasmf32}
@@ -2311,7 +2311,7 @@ class WasmFoundationTests: XCTestCase {
                     let result = function.wasmSimd128FloatBinOp(varA, varB, WasmSimd128Shape.f32x4, WasmSimd128FloatBinOpKind.min)
                     return (0..<4).map {function.wasmSimdExtractLane(kind: WasmSimdExtractLane.Kind.F32x4, result, $0)}
                 }
-            },"0,1.5[0-9]*,NaN,NaN"), // for floating point math need to allow trailing digits and take into account rounding issues
+            },"0,1.5[0-9]*,NaN,NaN"),
             // Test float max
             ({wasmModule in
                 let returnType = (0..<4).map {_ in ILType.wasmf32}
@@ -2321,7 +2321,7 @@ class WasmFoundationTests: XCTestCase {
                     let result = function.wasmSimd128FloatBinOp(varA, varB, WasmSimd128Shape.f32x4, WasmSimd128FloatBinOpKind.max)
                     return (0..<4).map {function.wasmSimdExtractLane(kind: WasmSimdExtractLane.Kind.F32x4, result, $0)}
                 }
-            },"4.8[0-9]*,5.9[0-9]*,NaN,NaN"), // for floating point math need to allow trailing digits and take into account rounding issues
+            },"4.8[0-9]*,5.9[0-9]*,NaN,NaN"),
             // Test float pmin
             ({wasmModule in
                 let returnType = (0..<4).map {_ in ILType.wasmf32}
@@ -2331,7 +2331,7 @@ class WasmFoundationTests: XCTestCase {
                     let result = function.wasmSimd128FloatBinOp(varA, varB, WasmSimd128Shape.f32x4, WasmSimd128FloatBinOpKind.pmin)
                     return (0..<4).map {function.wasmSimdExtractLane(kind: WasmSimdExtractLane.Kind.F32x4, result, $0)}
                 }
-            },"0,1.5[0-9]*,7,NaN"), // for floating point math need to allow trailing digits and take into account rounding issues
+            },"0,1.5[0-9]*,7,NaN"),
             // Test float pmax
             ({wasmModule in
                 let returnType = (0..<4).map {_ in ILType.wasmf32}
@@ -2341,7 +2341,27 @@ class WasmFoundationTests: XCTestCase {
                     let result = function.wasmSimd128FloatBinOp(varA, varB, WasmSimd128Shape.f32x4, WasmSimd128FloatBinOpKind.pmax)
                     return (0..<4).map {function.wasmSimdExtractLane(kind: WasmSimdExtractLane.Kind.F32x4, result, $0)}
                 }
-            },"4.8[0-9]*,5.9[0-9]*,7,NaN"), // for floating point math need to allow trailing digits and take into account rounding issues
+            },"4.8[0-9]*,5.9[0-9]*,7,NaN"),
+            // Test float relaxed_min
+            ({wasmModule in
+                let returnType = (0..<4).map {_ in ILType.wasmf32}
+                wasmModule.addWasmFunction(with: [] => returnType) { function, label, args in
+                    let varA = function.constSimd128(value: floatToByteArray([0.0, 5.9, 7.0, 0.0 / 0.0]))
+                    let varB = function.constSimd128(value: floatToByteArray([4.8, 1.5, 0.0 / 0.0, 3.7]))
+                    let result = function.wasmSimd128FloatBinOp(varA, varB, WasmSimd128Shape.f32x4, WasmSimd128FloatBinOpKind.relaxed_min)
+                    return (0..<4).map {function.wasmSimdExtractLane(kind: WasmSimdExtractLane.Kind.F32x4, result, $0)}
+                }
+            },"0,1.5[0-9]*,(NaN|7),(NaN|3.7[0-9]*)"),
+            // Test float relaxed_max
+            ({wasmModule in
+                let returnType = (0..<4).map {_ in ILType.wasmf32}
+                wasmModule.addWasmFunction(with: [] => returnType) { function, label, args in
+                    let varA = function.constSimd128(value: floatToByteArray([0.0, 5.9, 7.0, 0.0 / 0.0]))
+                    let varB = function.constSimd128(value: floatToByteArray([4.8, 1.5, 0.0 / 0.0, 3.7]))
+                    let result = function.wasmSimd128FloatBinOp(varA, varB, WasmSimd128Shape.f32x4, WasmSimd128FloatBinOpKind.relaxed_max)
+                    return (0..<4).map {function.wasmSimdExtractLane(kind: WasmSimdExtractLane.Kind.F32x4, result, $0)}
+                }
+            },"4.8[0-9]*,5.9[0-9]*,(NaN|7),(NaN|3.7[0-9]*)"),
 
 
         ]