Skip to content

Commit ff0f89c

Browse files
evicyV8-internal LUCI CQ
authored andcommitted
[improve livetests] Decrease accepted error rate to 1% for validity check
The testWasmCodeGenerationAndCompilation() LiveTest failed only once in 10 executions where an execution consists of 250 runs. (A run consists of generating a random Wasm module and compiling it.) Before this change we expected a max of 10% of Wasm compilations to fail which was way too high. Change-Id: Ic190b9da5d706b982a7590676fb20e856b1cb053 Reviewed-on: https://chrome-internal-review.googlesource.com/c/v8/fuzzilli/+/7960390 Reviewed-by: Carl Smith <[email protected]> Commit-Queue: Eva Herencsárová <[email protected]>
1 parent a923d15 commit ff0f89c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Tests/FuzzilliTests/LiveTests.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ class LiveTests: XCTestCase {
5858
}
5959
}
6060

61-
// We expect a maximum of 10% of Wasm compilation attempts to fail
62-
checkFailureRate(testResults: results, maxFailureRate: 0.10)
61+
// We expect a maximum of 1% of Wasm compilation attempts to fail.
62+
checkFailureRate(testResults: results, maxFailureRate: 0.01)
6363
}
6464

6565
func testWasmCodeGenerationAndCompilationAndExecution() throws {

0 commit comments

Comments
 (0)