Skip to content

Commit 0bb21b2

Browse files
author
Rubin Xu
committed
Fix Common Criteria toggle
Prefernce changed listener was not set up, causing the policy not being set correctly. Bug: 155725222 Test: manual Change-Id: Ic888f6e4b2179b0986beee62fd26040f05f7dd23
1 parent f2bdc59 commit 0bb21b2

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

app/src/main/java/com/afwsamples/testdpc/policy/PolicyManagementFragment.java

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -614,6 +614,7 @@ public void onCreatePreferences(Bundle savedInstanceState, String rootKey) {
614614
mEnableBackupServicePreference.setCustomConstraint(this::validateDeviceOwnerBeforeQ);
615615
mCommonCriteriaModePreference = (DpcSwitchPreference) findPreference(
616616
COMMON_CRITERIA_MODE_KEY);
617+
mCommonCriteriaModePreference.setOnPreferenceChangeListener(this);
617618
findPreference(REQUEST_BUGREPORT_KEY).setOnPreferenceClickListener(this);
618619
mEnableSecurityLoggingPreference =
619620
(SwitchPreference) findPreference(ENABLE_SECURITY_LOGGING);
@@ -774,6 +775,7 @@ public void onCreatePreferences(Bundle savedInstanceState, String rootKey) {
774775
reloadScreenCaptureDisableUi();
775776
reloadMuteAudioUi();
776777
reloadEnableBackupServiceUi();
778+
reloadCommonCriteriaModeUi();
777779
reloadEnableSecurityLoggingUi();
778780
reloadEnableNetworkLoggingUi();
779781
reloadSetAutoTimeRequiredUi();
@@ -1444,6 +1446,7 @@ public boolean onPreferenceChange(Preference preference, Object newValue) {
14441446
case COMMON_CRITERIA_MODE_KEY:
14451447
setCommonCriteriaModeEnabled((Boolean) newValue);
14461448
reloadCommonCriteriaModeUi();
1449+
return true;
14471450
case ENABLE_SECURITY_LOGGING:
14481451
setSecurityLoggingEnabled((Boolean) newValue);
14491452
reloadEnableSecurityLoggingUi();
@@ -1589,16 +1592,9 @@ private void setBackupServiceEnabled(boolean enabled) {
15891592
mDevicePolicyManager.setBackupServiceEnabled(mAdminComponentName, enabled);
15901593
}
15911594

1592-
//@TargetApi(VERSION_CODES.R)
1595+
@TargetApi(VERSION_CODES.R)
15931596
private void setCommonCriteriaModeEnabled(boolean enabled) {
1594-
try {
1595-
ReflectionUtil.invoke(mDevicePolicyManager,
1596-
"setCommonCriteriaModeEnabled",
1597-
new Class<?>[]{ComponentName.class, boolean.class},
1598-
mAdminComponentName, enabled);
1599-
} catch (ReflectionIsTemporaryException e) {
1600-
Log.e(TAG, "Error invoking setCommonCriteriaModeEnabled", e);
1601-
}
1597+
mDevicePolicyManager.setCommonCriteriaModeEnabled(mAdminComponentName, enabled);
16021598
}
16031599

16041600
@TargetApi(VERSION_CODES.M)

0 commit comments

Comments
 (0)