Skip to content

Commit 1495460

Browse files
author
Rubin Xu
committed
Fix issues in setting OTA policy pre-P or without freeze
Bug: 78446129 Test: Set policy without freeze periods; set policy on an Oreo device Change-Id: I0d98f91b827f2aeb18ce2646c56d9d6b1b41014c
1 parent c1ad4b0 commit 1495460

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

app/src/main/java/com/afwsamples/testdpc/policy/systemupdatepolicy/SystemUpdatePolicyFragment.java

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -281,21 +281,22 @@ private boolean setSystemUpdatePolicy() {
281281
default:
282282
newPolicy = null;
283283
}
284-
if (BuildCompat.isAtLeastP() && newPolicy != null && mFreezePeriods.size() != 0) {
285-
List<FreezePeriod> periods = new ArrayList<>(mFreezePeriods.size());
286-
for (Period p : mFreezePeriods) {
287-
periods.add(p.toFreezePeriod());
288-
}
289-
try {
284+
285+
try {
286+
if (BuildCompat.isAtLeastP() && newPolicy != null && mFreezePeriods.size() != 0) {
287+
final List<FreezePeriod> periods = new ArrayList<>(mFreezePeriods.size());
288+
for (Period p : mFreezePeriods) {
289+
periods.add(p.toFreezePeriod());
290+
}
290291
newPolicy.setFreezePeriods(periods);
291-
mDpm.setSystemUpdatePolicy(DeviceAdminReceiver.getComponentName(getActivity()),
292-
newPolicy);
293-
Toast.makeText(getContext(), "Policy set successfully", Toast.LENGTH_LONG).show();
294-
return true;
295-
} catch (IllegalArgumentException e) {
296-
Toast.makeText(getContext(), "Failed to set system update policy: " + e.getMessage(),
297-
Toast.LENGTH_LONG).show();
298292
}
293+
mDpm.setSystemUpdatePolicy(DeviceAdminReceiver.getComponentName(getActivity()),
294+
newPolicy);
295+
Toast.makeText(getContext(), "Policy set successfully", Toast.LENGTH_LONG).show();
296+
return true;
297+
} catch (IllegalArgumentException e) {
298+
Toast.makeText(getContext(), "Failed to set system update policy: " + e.getMessage(),
299+
Toast.LENGTH_LONG).show();
299300
}
300301
return false;
301302
}

0 commit comments

Comments
 (0)