In app permissions, when selecting an app to view its permissions from

the drop down, display a text message if there is no permission to show.

Bug:24800054
Test: adb install ./out/gradle/TestDPC/build/outputs/apk/normal/debug/TestDPC-normal-debug.apk
Change-Id: I077575d0692f98f23050c24b006057014e79f403

Author: Irina Dumitrescu

app/src/main/java/com/afwsamples/testdpc/common/BaseManageComponentFragment.java

@@ -81,10 +81,15 @@ public void onNothingSelected(AdapterView<?> parent) {
         view.findViewById(R.id.reset_app).setOnClickListener(this);
         view.findViewById(R.id.add_new_row).setOnClickListener(this);
         view.findViewById(R.id.load_default_button).setOnClickListener(this);
-        onSpinnerItemSelected((T) mManagedAppsSpinner.getSelectedItem());
         return view;
     }
 
+    @Override
+    public void onActivityCreated(Bundle savedInstanceState) {
+        super.onActivityCreated(savedInstanceState);
+        onSpinnerItemSelected((T) mManagedAppsSpinner.getSelectedItem());
+    }
+
     protected abstract SpinnerAdapter createSpinnerAdapter();
 
     protected abstract BaseAdapter createListAdapter();

app/src/main/java/com/afwsamples/testdpc/profilepolicy/permission/ManageAppPermissionsFragment.java

@@ -32,9 +32,9 @@
 import android.view.ViewGroup;
 import android.widget.BaseAdapter;
 
+import android.widget.TextView;
 import com.afwsamples.testdpc.DeviceAdminReceiver;
 import com.afwsamples.testdpc.R;
-import com.afwsamples.testdpc.common.BaseManageComponentFragment;
 import com.afwsamples.testdpc.common.ManageAppFragment;
 
 import java.util.ArrayList;
@@ -50,6 +50,7 @@ public class ManageAppPermissionsFragment extends ManageAppFragment {
 
     private DevicePolicyManager mDpm;
     private List<AppPermissionsArrayAdapter.AppPermission> mAppPermissions = new ArrayList<>();
+    private TextView mAppPermissionsView;
 
     @Override
     public void onCreate(Bundle savedInstanceState) {
@@ -64,6 +65,8 @@ public View onCreateView(LayoutInflater layoutInflater, ViewGroup container,
         view.findViewById(R.id.load_default_button).setVisibility(View.GONE);
         view.findViewById(R.id.add_new_row).setVisibility(View.GONE);
         view.findViewById(R.id.manage_app_button_container).setVisibility(View.GONE);
+        mAppPermissionsView = view.findViewById(R.id.error_message);
+        mAppPermissionsView.setText(R.string.app_permissions_empty);
         return view;
     }
 
@@ -107,8 +110,7 @@ protected void onSpinnerItemSelected(ApplicationInfo appInfo) {
                                 permissionState);
                 populatedPermissions.add(populatedPerm);
             }
-
-            loadAppPermissionsList(populatedPermissions);
+            displayAppPermissions(populatedPermissions);
         }
     }
 
@@ -129,12 +131,19 @@ protected BaseAdapter createListAdapter() {
         return new AppPermissionsArrayAdapter(getActivity(), 0, mAppPermissions);
     }
 
-    private void loadAppPermissionsList(
-            List<AppPermissionsArrayAdapter.AppPermission> permissions) {
-        if (permissions != null) {
-            mAppPermissions.clear();
+    /**
+     * Displays the list of permissions for the selected app. If there are no permissions to
+     * be displayed, a text view displays a message about this.
+     */
+    private void displayAppPermissions(
+        List<AppPermissionsArrayAdapter.AppPermission> permissions) {
+        mAppPermissions.clear();
+        if (permissions.isEmpty()) {
+            mAppPermissionsView.setVisibility(View.VISIBLE);
+        } else {
+            mAppPermissionsView.setVisibility(View.GONE);
             mAppPermissions.addAll(permissions);
-            mAdapter.notifyDataSetChanged();
         }
+        mAdapter.notifyDataSetChanged();
     }
 }

app/src/main/res/layout/manage_apps.xml

@@ -50,6 +50,16 @@ limitations under the License.
             android:layout_alignParentRight="true"
             android:text="@string/plus" />
 
+    <TextView
+        android:id="@+id/error_message"
+        android:layout_below="@id/header_view"
+        android:layout_above="@+id/load_default_button"
+        android:visibility="gone"
+        android:layout_height="wrap_content"
+        android:layout_width="match_parent"
+        android:paddingTop="16dp"
+        android:paddingBottom="4dp" />
+
     <ListView
             android:id="@+id/app_list_view"
             android:layout_below="@id/header_view"

app/src/main/res/values/strings.xml

@@ -797,6 +797,8 @@
     <string name="permission_default">Let user decide</string>
     <string name="permission_deny">Deny</string>
     <string name="manage_app_permissions">Manage app permissions</string>
+    <!-- Message displayed when there are no apps permissions to show. -->
+    <string name="app_permissions_empty">There are no permissions to display for this app.</string>
 
     <!-- Keyguard features -->
     <string name="keyguard_features">Keyguard features</string>