Do not dismiss the dialog again when it already is

tony-mak · tony-mak · commit 7caf9757e668 · 2018-04-16T19:39:42.000+01:00
The dialog is already gone when onCancel/ onDismiss is called, not
necessary to call dismiss the callback.

To reproduce the issue, just rotate the screen in that dialog.

Change-Id: Icb4a9dbf50f4fc4ed90e886159487422fda70714
Fixes: 33447412
diff --git a/app/src/main/java/com/afwsamples/testdpc/policy/wifimanagement/WifiConfigCreationDialog.java b/app/src/main/java/com/afwsamples/testdpc/policy/wifimanagement/WifiConfigCreationDialog.java
@@ -149,15 +149,13 @@ public void onDismiss(DialogInterface dialog) {
         if (mListener != null) {
             mListener.onDismiss();
         }
-        dismiss();
     }
 
     @Override
     public void onCancel(DialogInterface dialog) {
         if (mListener != null) {
             mListener.onCancel();
         }
-        dismiss();
     }
 
     private void initialize() {

Original file line number	Diff line number	Diff line change
`@@ -149,15 +149,13 @@ public void onDismiss(DialogInterface dialog) {`
`149`	`149`	`if (mListener != null) {`
`150`	`150`	`mListener.onDismiss();`
`151`	`151`	`}`
`152`		`- dismiss();`
`153`	`152`	`}`
`154`	`153`
`155`	`154`	`@Override`
`156`	`155`	`public void onCancel(DialogInterface dialog) {`
`157`	`156`	`if (mListener != null) {`
`158`	`157`	`mListener.onCancel();`
`159`	`158`	`}`
`160`		`- dismiss();`
`161`	`159`	`}`
`162`	`160`
`163`	`161`	`private void initialize() {`