Skip to content

Commit 86a588f

Browse files
committed
Replace VERSION.SDK_INT with Util.SDK_INT.
This is to ensure that the new release of TestDPC still works with the pre-release version of Q. When we begin adding R features to TestDPC, we can replace IS_RUNNING_Q with IS_RUNNING_R. This will make it easier to transition upon full release of R in future. Test: Manual Change-Id: Ib0c930335f1b9a35544c97ce2e1b970592cd7d6a
1 parent 29e5b14 commit 86a588f

30 files changed

+93
-105
lines changed

app/src/main/java/com/afwsamples/testdpc/AddAccountActivity.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
import android.content.ComponentName;
2929
import android.content.Context;
3030
import android.content.Intent;
31-
import android.os.Build;
3231
import android.os.Build.VERSION_CODES;
3332
import android.os.Bundle;
3433
import android.os.UserManager;
@@ -38,6 +37,7 @@
3837
import android.widget.EditText;
3938
import android.widget.RadioGroup;
4039
import android.widget.Toast;
40+
import com.afwsamples.testdpc.common.Util;
4141
import com.android.setupwizardlib.GlifLayout;
4242
import java.io.IOException;
4343

@@ -123,7 +123,7 @@ private void addAccount(String accountName) {
123123
}
124124

125125
private void disableUserRestrictions() {
126-
if (Build.VERSION.SDK_INT >= VERSION_CODES.N) {
126+
if (Util.SDK_INT >= VERSION_CODES.N) {
127127
// DPC is allowed to bypass DISALLOW_MODIFY_ACCOUNTS on N or above.
128128
Log.v(TAG, "skip disabling user restriction on N or above");
129129
return;
@@ -136,7 +136,7 @@ private void disableUserRestrictions() {
136136
}
137137

138138
private void restoreUserRestrictions() {
139-
if (Build.VERSION.SDK_INT >= VERSION_CODES.N) {
139+
if (Util.SDK_INT >= VERSION_CODES.N) {
140140
// DPC is allowed to bypass DISALLOW_MODIFY_ACCOUNTS on N or above.
141141
Log.v(TAG, "skip restoring user restrictions on N or above");
142142
return;

app/src/main/java/com/afwsamples/testdpc/BootReceiver.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import android.content.Intent;
2222
import android.os.Process;
2323
import android.os.UserHandle;
24-
2524
import com.afwsamples.testdpc.common.Util;
2625
import com.afwsamples.testdpc.comp.BindDeviceAdminServiceHelper;
2726
import com.afwsamples.testdpc.comp.DeviceOwnerService;

app/src/main/java/com/afwsamples/testdpc/CommonReceiverOperations.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
import android.text.TextUtils;
3232
import android.util.Log;
3333
import android.widget.Toast;
34+
import com.afwsamples.testdpc.common.Util;
3435
import java.io.File;
3536
import java.io.FileOutputStream;
3637
import java.io.IOException;
@@ -92,7 +93,7 @@ public static void onNetworkLogsAvailable(Context context, ComponentName admin,
9293
context.getString(R.string.on_network_logs_available_success, batchToken));
9394

9495
ArrayList<String> loggedEvents = new ArrayList<>();
95-
if (Build.VERSION.SDK_INT >= VERSION_CODES.P) {
96+
if (Util.SDK_INT >= VERSION_CODES.P) {
9697
for (NetworkEvent event : events) {
9798
loggedEvents.add(event.toString());
9899
}

app/src/main/java/com/afwsamples/testdpc/DeviceAdminReceiver.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import android.net.Uri;
2727
import android.os.AsyncTask;
2828
import android.os.Binder;
29-
import android.os.Build;
3029
import android.os.Build.VERSION_CODES;
3130
import android.os.ParcelFileDescriptor;
3231
import android.os.PersistableBundle;
@@ -38,7 +37,6 @@
3837
import android.widget.Toast;
3938
import com.afwsamples.testdpc.common.NotificationUtil;
4039
import com.afwsamples.testdpc.common.Util;
41-
import com.afwsamples.testdpc.policy.UserRestriction;
4240
import com.afwsamples.testdpc.provision.PostProvisioningTask;
4341
import java.io.BufferedReader;
4442
import java.io.BufferedWriter;
@@ -506,7 +504,7 @@ && isUsingUnifiedPassword(context)) {
506504

507505
@TargetApi(VERSION_CODES.P)
508506
private static Boolean isUsingUnifiedPassword(Context context) {
509-
if (Build.VERSION.SDK_INT < VERSION_CODES.P) {
507+
if (Util.SDK_INT < VERSION_CODES.P) {
510508
return false;
511509
}
512510
final DevicePolicyManager dpm = context.getSystemService(DevicePolicyManager.class);

app/src/main/java/com/afwsamples/testdpc/DeviceAdminService.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import android.content.BroadcastReceiver;
44
import android.content.Intent;
55
import android.content.IntentFilter;
6-
import android.os.Build;
76
import android.os.Build.VERSION_CODES;
87
import android.support.annotation.RequiresApi;
98

app/src/main/java/com/afwsamples/testdpc/FinalizeActivity.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package com.afwsamples.testdpc;
1818

1919
import static android.app.admin.DevicePolicyManager.EXTRA_PROVISIONING_ADMIN_EXTRAS_BUNDLE;
20-
import static android.app.admin.DevicePolicyManager.EXTRA_PROVISIONING_DEVICE_ADMIN_COMPONENT_NAME;
2120

2221
import android.accounts.Account;
2322
import android.accounts.AccountManager;
@@ -30,7 +29,6 @@
3029
import android.widget.Button;
3130
import android.widget.ImageView;
3231
import android.widget.TextView;
33-
3432
import com.afwsamples.testdpc.common.LaunchIntentUtil;
3533
import com.afwsamples.testdpc.common.Util;
3634
import com.afwsamples.testdpc.provision.ProvisioningUtil;

app/src/main/java/com/afwsamples/testdpc/PackageMonitorReceiver.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import android.content.Intent;
88
import android.support.v4.app.NotificationCompat;
99
import android.text.TextUtils;
10-
1110
import com.afwsamples.testdpc.common.NotificationUtil;
1211

1312
public class PackageMonitorReceiver extends BroadcastReceiver {

app/src/main/java/com/afwsamples/testdpc/SetupManagementFragment.java

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
import android.content.Intent;
3838
import android.content.res.ColorStateList;
3939
import android.net.Uri;
40-
import android.os.Build;
4140
import android.os.Build.VERSION_CODES;
4241
import android.os.Bundle;
4342
import android.os.PersistableBundle;
@@ -161,7 +160,7 @@ public void onResume() {
161160

162161
if (setProvisioningMethodsVisibility()) {
163162
// The extra logo uri and color are supported only from N
164-
if (Build.VERSION.SDK_INT >= VERSION_CODES.N) {
163+
if (Util.SDK_INT >= VERSION_CODES.N) {
165164
getView().findViewById(R.id.params_title).setVisibility(View.VISIBLE);
166165
if (canAnAppHandleGetContent()) {
167166
getView().findViewById(
@@ -190,18 +189,18 @@ private void setProvisioningModeSpecificUI() {
190189
final boolean isManagedProfileAction = setUpOptionId == R.id.setup_managed_profile;
191190
final boolean isManagedDeviceAction = setUpOptionId == R.id.setup_device_owner;
192191
mSkipUserConsent.setVisibility(
193-
Build.VERSION.SDK_INT >= VERSION_CODES.O
192+
Util.SDK_INT >= VERSION_CODES.O
194193
&& isManagedProfileAction
195194
&& Util.isDeviceOwner(getActivity())
196195
? View.VISIBLE
197196
: View.GONE);
198197
mKeepAccountMigrated.setVisibility(
199-
Build.VERSION.SDK_INT >= VERSION_CODES.O && isManagedProfileAction
198+
Util.SDK_INT >= VERSION_CODES.O && isManagedProfileAction
200199
? View.VISIBLE
201200
: View.GONE);
202201
mSkipEncryption.setVisibility(
203-
(isManagedProfileAction && Build.VERSION.SDK_INT >= VERSION_CODES.N)
204-
|| (isManagedDeviceAction && Build.VERSION.SDK_INT >= VERSION_CODES.M)
202+
(isManagedProfileAction && Util.SDK_INT >= VERSION_CODES.N)
203+
|| (isManagedDeviceAction && Util.SDK_INT >= VERSION_CODES.M)
205204
? View.VISIBLE
206205
: View.GONE);
207206

@@ -216,7 +215,7 @@ private void maybeLaunchProvisioning(String intentAction, int requestCode) {
216215
Activity activity = getActivity();
217216

218217
Intent intent = new Intent(intentAction);
219-
if (Build.VERSION.SDK_INT >= VERSION_CODES.M) {
218+
if (Util.SDK_INT >= VERSION_CODES.M) {
220219
intent.putExtra(EXTRA_PROVISIONING_DEVICE_ADMIN_COMPONENT_NAME,
221220
DeviceAdminReceiver.getComponentName(getActivity()));
222221
} else {
@@ -259,7 +258,7 @@ private void maybeSpecifySyncAuthExtras(Intent intent, PersistableBundle adminEx
259258
Account accountToMigrate = LaunchIntentUtil.getAddedAccount(launchIntent);
260259
if (accountToMigrate != null) {
261260
// EXTRA_PROVISIONING_ACCOUNT_TO_MIGRATE only supported in API 22+.
262-
if (Build.VERSION.SDK_INT >= VERSION_CODES.LOLLIPOP_MR1) {
261+
if (Util.SDK_INT >= VERSION_CODES.LOLLIPOP_MR1) {
263262
// Configure the account to migrate into the managed profile if setup
264263
// completes.
265264
intent.putExtra(EXTRA_PROVISIONING_ACCOUNT_TO_MIGRATE, accountToMigrate);
@@ -276,7 +275,7 @@ private void maybeSpecifySyncAuthExtras(Intent intent, PersistableBundle adminEx
276275
private void maybePassAffiliationIds(Intent intent, PersistableBundle adminExtras) {
277276
if (Util.isDeviceOwner(getActivity())
278277
&& ACTION_PROVISION_MANAGED_PROFILE.equals(intent.getAction())
279-
&& Build.VERSION.SDK_INT >= VERSION_CODES.O) {
278+
&& Util.SDK_INT >= VERSION_CODES.O) {
280279
passAffiliationIds(intent, adminExtras);
281280
}
282281
}
@@ -302,15 +301,15 @@ private void passAffiliationIds(Intent intent, PersistableBundle adminExtras) {
302301
* @return true if we can launch the intent
303302
*/
304303
private boolean maybeSpecifyNExtras(Intent intent) {
305-
if (Build.VERSION.SDK_INT >= VERSION_CODES.N) {
304+
if (Util.SDK_INT >= VERSION_CODES.N) {
306305
specifyLogoUri(intent);
307306
specifyColor(intent);
308307
}
309308
return true;
310309
}
311310

312311
private void specifyDefaultDisclaimers(Intent intent) {
313-
if (Build.VERSION.SDK_INT >= VERSION_CODES.O) {
312+
if (Util.SDK_INT >= VERSION_CODES.O) {
314313
Bundle emmBundle = new Bundle();
315314
emmBundle.putString(DevicePolicyManager.EXTRA_PROVISIONING_DISCLAIMER_HEADER,
316315
getString(R.string.default_disclaimer_emm_name));
@@ -334,7 +333,7 @@ private static Uri resourceToUri(Context context, int resID) {
334333
}
335334

336335
private void specifySkipUserConsent(Intent intent) {
337-
if (Build.VERSION.SDK_INT >= VERSION_CODES.O
336+
if (Util.SDK_INT >= VERSION_CODES.O
338337
&& ACTION_PROVISION_MANAGED_PROFILE.equals(intent.getAction())
339338
&& mSkipUserConsent.getVisibility() == View.VISIBLE) {
340339
intent.putExtra(
@@ -344,7 +343,7 @@ private void specifySkipUserConsent(Intent intent) {
344343
}
345344

346345
private void specifyKeepAccountMigrated(Intent intent) {
347-
if (Build.VERSION.SDK_INT >= VERSION_CODES.O
346+
if (Util.SDK_INT >= VERSION_CODES.O
348347
&& ACTION_PROVISION_MANAGED_PROFILE.equals(intent.getAction())
349348
&& mKeepAccountMigrated.getVisibility() == View.VISIBLE) {
350349
intent.putExtra(DevicePolicyManager.EXTRA_PROVISIONING_KEEP_ACCOUNT_ON_MIGRATION,

app/src/main/java/com/afwsamples/testdpc/common/NotificationUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public static void showNotification(
4040
}
4141

4242
public static NotificationCompat.Builder getNotificationBuilder(Context context) {
43-
if (Build.VERSION.SDK_INT >= VERSION_CODES.O) {
43+
if (Util.SDK_INT >= VERSION_CODES.O) {
4444
createDefaultNotificationChannel(context);
4545
}
4646
NotificationCompat.Builder builder

app/src/main/java/com/afwsamples/testdpc/common/ProfileOrParentFragment.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public View onCreateView(
6666

6767
final boolean showDualTabs =
6868
Util.isManagedProfileOwner(getActivity())
69-
&& Build.VERSION.SDK_INT >= VERSION_CODES.N;
69+
&& Util.SDK_INT >= VERSION_CODES.N;
7070

7171
// Tab for the parent profile
7272
if (showDualTabs) {

0 commit comments

Comments
 (0)