Skip to content

Commit a26c342

Browse files
committed
Not specify theming by default in TestDPC
This allows us to test MP UI without theming, which is something we prefer since P. BUG: 70621340 Change-Id: Id8e0bcd7fba72fd2ba8110386ec10d57a2de8758
1 parent 6afa64f commit a26c342

File tree

3 files changed

+35
-26
lines changed

3 files changed

+35
-26
lines changed

app/src/main/java/com/afwsamples/testdpc/SetupManagementFragment.java

Lines changed: 33 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,15 @@
1616

1717
package com.afwsamples.testdpc;
1818

19+
import static android.app.admin.DevicePolicyManager.ACTION_PROVISION_MANAGED_DEVICE;
20+
import static android.app.admin.DevicePolicyManager.ACTION_PROVISION_MANAGED_PROFILE;
21+
import static android.app.admin.DevicePolicyManager.EXTRA_PROVISIONING_ACCOUNT_TO_MIGRATE;
22+
import static android.app.admin.DevicePolicyManager.EXTRA_PROVISIONING_ADMIN_EXTRAS_BUNDLE;
23+
import static android.app.admin.DevicePolicyManager.EXTRA_PROVISIONING_DEVICE_ADMIN_COMPONENT_NAME;
24+
import static android.app.admin.DevicePolicyManager.EXTRA_PROVISIONING_DEVICE_ADMIN_PACKAGE_NAME;
25+
import static android.app.admin.DevicePolicyManager.EXTRA_PROVISIONING_LOGO_URI;
26+
import static android.app.admin.DevicePolicyManager.EXTRA_PROVISIONING_MAIN_COLOR;
27+
1928
import android.accounts.Account;
2029
import android.annotation.TargetApi;
2130
import android.app.Activity;
@@ -43,28 +52,16 @@
4352
import android.widget.RadioGroup;
4453
import android.widget.TextView;
4554
import android.widget.Toast;
46-
4755
import com.afwsamples.testdpc.common.ColorPicker;
4856
import com.afwsamples.testdpc.common.LaunchIntentUtil;
4957
import com.afwsamples.testdpc.common.ProvisioningStateUtil;
5058
import com.afwsamples.testdpc.common.Util;
5159
import com.android.setupwizardlib.SetupWizardLayout;
5260
import com.android.setupwizardlib.view.NavigationBar;
53-
5461
import java.security.SecureRandom;
55-
import java.util.Arrays;
5662
import java.util.Collections;
5763
import java.util.Set;
5864

59-
import static android.app.admin.DevicePolicyManager.ACTION_PROVISION_MANAGED_DEVICE;
60-
import static android.app.admin.DevicePolicyManager.ACTION_PROVISION_MANAGED_PROFILE;
61-
import static android.app.admin.DevicePolicyManager.EXTRA_PROVISIONING_ACCOUNT_TO_MIGRATE;
62-
import static android.app.admin.DevicePolicyManager.EXTRA_PROVISIONING_ADMIN_EXTRAS_BUNDLE;
63-
import static android.app.admin.DevicePolicyManager.EXTRA_PROVISIONING_DEVICE_ADMIN_COMPONENT_NAME;
64-
import static android.app.admin.DevicePolicyManager.EXTRA_PROVISIONING_DEVICE_ADMIN_PACKAGE_NAME;
65-
import static android.app.admin.DevicePolicyManager.EXTRA_PROVISIONING_LOGO_URI;
66-
import static android.app.admin.DevicePolicyManager.EXTRA_PROVISIONING_MAIN_COLOR;
67-
6865
/**
6966
* This {@link Fragment} shows the UI that allows the user to start the setup of a managed profile
7067
* or configuration of a device-owner if the device is in an appropriate state.
@@ -79,6 +76,8 @@ public class SetupManagementFragment extends Fragment implements
7976
private static final int REQUEST_PROVISION_DEVICE_OWNER = 2;
8077
private static final int REQUEST_GET_LOGO = 3;
8178

79+
private static final int NO_COLOR_SPECIFIED = -1;
80+
8281
private TextView mSetupManagementMessage;
8382
private RadioGroup mSetupOptions;
8483
private Button mNavigationNextButton;
@@ -95,18 +94,15 @@ public class SetupManagementFragment extends Fragment implements
9594
private ImageView mLogoPreviewView;
9695
private TextView mLogoValue;
9796

98-
private int mCurrentColor;
97+
private int mCurrentColor = NO_COLOR_SPECIFIED;
9998
private Uri mLogoUri = null;
10099

101100
@Override
102101
public View onCreateView(LayoutInflater inflater, ViewGroup container,
103102
Bundle savedInstanceState) {
104103
if (savedInstanceState != null) {
105-
mLogoUri = (Uri) savedInstanceState.getParcelable(EXTRA_PROVISIONING_LOGO_URI);
104+
mLogoUri = savedInstanceState.getParcelable(EXTRA_PROVISIONING_LOGO_URI);
106105
mCurrentColor = savedInstanceState.getInt(EXTRA_PROVISIONING_MAIN_COLOR);
107-
} else {
108-
mLogoUri = resourceToUri(getActivity(), R.drawable.ic_launcher);
109-
mCurrentColor = getResources().getColor(R.color.teal);
110106
}
111107

112108
// Use setupwizard theme
@@ -134,9 +130,9 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container,
134130

135131
view.findViewById(R.id.color_select_button).setOnClickListener(this);
136132
mColorValue = (TextView) view.findViewById(R.id.selected_color_value);
137-
mColorValue.setText(String.format(ColorPicker.COLOR_STRING_FORMATTER, mCurrentColor));
138133
mColorPreviewView = (ImageView) view.findViewById(R.id.preview_color);
139-
mColorPreviewView.setImageTintList(ColorStateList.valueOf(mCurrentColor));
134+
135+
updateColorUi();
140136

141137
Intent launchIntent = getActivity().getIntent();
142138
if (LaunchIntentUtil.isSynchronousAuthLaunch(launchIntent)) {
@@ -376,6 +372,9 @@ private void specifySkipEncryption(Intent intent) {
376372

377373

378374
private void specifyLogoUri(Intent intent) {
375+
if (mLogoUri == null) {
376+
return;
377+
}
379378
intent.putExtra(EXTRA_PROVISIONING_LOGO_URI, mLogoUri);
380379
if (mLogoUri.getScheme().equals(ContentResolver.SCHEME_CONTENT)) {
381380
intent.setFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION);
@@ -384,6 +383,9 @@ private void specifyLogoUri(Intent intent) {
384383
}
385384

386385
private void specifyColor(Intent intent) {
386+
if (mCurrentColor == NO_COLOR_SPECIFIED) {
387+
return;
388+
}
387389
intent.putExtra(EXTRA_PROVISIONING_MAIN_COLOR, mCurrentColor);
388390
}
389391

@@ -471,8 +473,7 @@ public void onClick(View view) {
471473
@Override
472474
public void onColorSelected(int colorValue, String id) {
473475
mCurrentColor = colorValue;
474-
mColorValue.setText(String.format(ColorPicker.COLOR_STRING_FORMATTER, colorValue));
475-
mColorPreviewView.setImageTintList(ColorStateList.valueOf(colorValue));
476+
updateColorUi();
476477
}
477478

478479
@Override
@@ -500,4 +501,15 @@ private Intent getGetContentIntent() {
500501
private boolean canAnAppHandleGetContent() {
501502
return getGetContentIntent().resolveActivity(getActivity().getPackageManager()) != null;
502503
}
504+
505+
private void updateColorUi() {
506+
if (mCurrentColor != NO_COLOR_SPECIFIED) {
507+
mColorValue.setText(String.format(ColorPicker.COLOR_STRING_FORMATTER, mCurrentColor));
508+
mColorPreviewView.setImageTintList(ColorStateList.valueOf(mCurrentColor));
509+
mColorPreviewView.setVisibility(View.VISIBLE);
510+
} else {
511+
mColorValue.setText("");
512+
mColorPreviewView.setVisibility(View.GONE);
513+
}
514+
}
503515
}

app/src/main/res/layout/choose_color_item.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,12 @@
3636
<TextView android:id="@+id/selected_color_value"
3737
android:layout_width="wrap_content"
3838
android:layout_height="wrap_content"
39-
android:text="@color/teal"
4039
android:layout_gravity="center_vertical"
4140
android:paddingEnd="@dimen/params_padding_start_end" />
4241
<ImageView android:id="@+id/preview_color"
4342
android:layout_width="wrap_content"
4443
android:layout_height="wrap_content"
4544
android:src="@drawable/ic_circle"
46-
android:tint="@color/teal"
4745
android:layout_gravity="center_vertical" />
4846
<View
4947
android:layout_width="0dp"

app/src/main/res/layout/choose_logo_item.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
<TextView android:id="@+id/selected_logo_value"
3939
android:layout_width="wrap_content"
4040
android:layout_height="wrap_content"
41-
android:text="ic_launcher"
41+
android:text=""
4242
android:layout_gravity="center_vertical"
4343
android:paddingEnd="@dimen/params_padding_start_end" />
4444
<ImageView android:id="@+id/preview_logo"
@@ -48,8 +48,7 @@
4848
android:maxWidth="@dimen/params_preview_logo_max_width"
4949
android:maxHeight="@dimen/params_preview_logo_max_height"
5050
android:scaleType="fitCenter"
51-
android:adjustViewBounds="true"
52-
android:src="@drawable/ic_launcher" />
51+
android:adjustViewBounds="true"/>
5352
<View
5453
android:layout_width="0dp"
5554
android:layout_height="match_parent"

0 commit comments

Comments
 (0)