Skip to content

Commit d61cc29

Browse files
committed
Remove reflection.
Test: manual Change-Id: I96b20840ecf3d2884e63417346b25be949082718
1 parent ebc1723 commit d61cc29

File tree

2 files changed

+13
-68
lines changed

2 files changed

+13
-68
lines changed

app/src/main/java/com/afwsamples/testdpc/DevicePolicyManagerGatewayImpl.java

Lines changed: 8 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -122,42 +122,21 @@ public boolean isOrganizationOwnedDeviceWithManagedProfile() {
122122
public boolean isHeadlessSystemUserMode() {
123123
Util.requireAndroidS();
124124

125-
// TODO(b/179160578): use proper method when available on SDK
126-
String method = "isHeadlessSystemUserMode";
127-
try {
128-
return ReflectionUtil.invoke(mUserManager, method);
129-
} catch (ReflectionIsTemporaryException e) {
130-
Log.wtf(TAG, "Error calling mUserManager." + method + "()", e);
131-
return false;
132-
}
125+
return mUserManager.isHeadlessSystemUserMode();
133126
}
134127

135128
@Override
136129
public boolean isUserForeground() {
137130
Util.requireAndroidS();
138131

139-
// TODO(b/179160578): use proper method when available on SDK
140-
String method = "isUserForeground";
141-
try {
142-
return ReflectionUtil.invoke(mUserManager, method);
143-
} catch (ReflectionIsTemporaryException e) {
144-
Log.wtf(TAG, "Error calling mUserManager." + method + "()", e);
145-
return false;
146-
}
132+
return mUserManager.isUserForeground();
147133
}
148134

149135
@Override
150136
public List<UserHandle> listForegroundAffiliatedUsers() {
151137
Util.requireAndroidS();
152138

153-
// TODO(b/179160578): use proper method when available on SDK
154-
String method = "listForegroundAffiliatedUsers";
155-
try {
156-
return ReflectionUtil.invoke(mDevicePolicyManager, method);
157-
} catch (ReflectionIsTemporaryException e) {
158-
Log.wtf(TAG, "Error calling mDevicePolicyManager." + method + "()", e);
159-
return Collections.emptyList();
160-
}
139+
return mDevicePolicyManager.listForegroundAffiliatedUsers();
161140
}
162141

163142
@Override
@@ -481,13 +460,11 @@ public void setUsbDataSignalingEnabled(boolean enabled, @NonNull Consumer<Void>
481460
Log.d(TAG, "setUsbDataSignalingEnabled(" + enabled + ")");
482461
Util.requireAndroidS();
483462

484-
String method = "setUsbDataSignalingEnabled";
485463
try {
486-
// TODO(b/179160578): use proper method when available on SDK
487-
ReflectionUtil.invoke(mDevicePolicyManager, method, new Class[]{Boolean.TYPE}, enabled);
464+
mDevicePolicyManager.setUsbDataSignalingEnabled(enabled);
488465
onSuccess.accept(null);
489466
} catch (Exception e) {
490-
Log.wtf(TAG, "Error calling " + method + "()", e);
467+
Log.wtf(TAG, "Error calling setUsbDataSignalingEnabled()", e);
491468
onError.accept(e);
492469
}
493470
}
@@ -506,13 +483,11 @@ public void setPreferentialNetworkServiceEnabled(boolean enabled, Consumer<Void>
506483
Log.d(TAG, "setPreferentialNetworkServiceEnabled(" + enabled + ")");
507484
Util.requireAndroidS();
508485

509-
String method = "setPreferentialNetworkServiceEnabled";
510486
try {
511-
// TODO(b/179160578): use proper method when available on SDK
512-
ReflectionUtil.invoke(mDevicePolicyManager, method, new Class[]{Boolean.TYPE}, enabled);
487+
mDevicePolicyManager.setPreferentialNetworkServiceEnabled(enabled);
513488
onSuccess.accept(null);
514489
} catch (Exception e) {
515-
Log.wtf(TAG, "Error calling " + method + "()", e);
490+
Log.wtf(TAG, "Error calling setPreferentialNetworkServiceEnabled()", e);
516491
onError.accept(e);
517492
}
518493
}
@@ -521,14 +496,7 @@ public void setPreferentialNetworkServiceEnabled(boolean enabled, Consumer<Void>
521496
public boolean isPreferentialNetworkServiceEnabled() {
522497
Util.requireAndroidS();
523498

524-
String method = "isPreferentialNetworkServiceEnabled";
525-
try {
526-
// TODO(b/179160578): use proper method when available on SDK
527-
return (Boolean) ReflectionUtil.invoke(mDevicePolicyManager, method);
528-
} catch (ReflectionIsTemporaryException e) {
529-
Log.wtf(TAG, "Error calling " + method + "()", e);
530-
return false;
531-
}
499+
return mDevicePolicyManager.isPreferentialNetworkServiceEnabled();
532500
}
533501

534502
@Override

app/src/main/java/com/afwsamples/testdpc/policy/PolicyManagementFragment.java

Lines changed: 5 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -2505,14 +2505,7 @@ private void loadEnrollmentSpecificId() {
25052505
return;
25062506
}
25072507

2508-
String esid = "";
2509-
try {
2510-
//TODO: Call directly when the S SDK is available.
2511-
esid = ReflectionUtil.invoke(mDevicePolicyManager, "getEnrollmentSpecificId");
2512-
} catch (ReflectionIsTemporaryException e) {
2513-
Log.e(TAG, "Error invoking getEnterpriseSpecificId", e);
2514-
esid = "Error";
2515-
}
2508+
String esid = mDevicePolicyManager.getEnrollmentSpecificId();
25162509

25172510
enrollmentSpecificIdPreference.setSummary(esid);
25182511
}
@@ -2552,13 +2545,7 @@ private void loadPasswordComplexity() {
25522545

25532546
@TargetApi(VERSION_CODES.S)
25542547
private int getRequiredComplexity(DevicePolicyManager dpm) {
2555-
try {
2556-
return ReflectionUtil.invoke(dpm, "getRequiredPasswordComplexity");
2557-
} catch (ReflectionIsTemporaryException e) {
2558-
Log.e(TAG, "Error invoking getRequiredPasswordComplexity", e);
2559-
}
2560-
2561-
return DevicePolicyManager.PASSWORD_COMPLEXITY_NONE;
2548+
return dpm.getRequiredPasswordComplexity();
25622549
}
25632550

25642551
private void loadRequiredPasswordComplexity() {
@@ -2605,12 +2592,7 @@ private void setRequiredPasswordComplexityOnParent(int complexity) {
26052592
// running older releases and obviates the need for a target sdk check here.
26062593
@TargetApi(VERSION_CODES.S)
26072594
private void setRequiredPasswordComplexity(DevicePolicyManager dpm, int complexity) {
2608-
try {
2609-
ReflectionUtil.invoke(dpm, "setRequiredPasswordComplexity",
2610-
new Class[]{Integer.TYPE}, complexity);
2611-
} catch (ReflectionIsTemporaryException e) {
2612-
Log.e(TAG, "Error invoking setRequiredPasswordComplexity", e);
2613-
}
2595+
dpm.setRequiredPasswordComplexity(complexity);
26142596
loadPasswordCompliant();
26152597
loadPasswordComplexity();
26162598
loadRequiredPasswordComplexity();
@@ -2768,13 +2750,8 @@ private void reloadCommonCriteriaModeUi() {
27682750
@TargetApi(VERSION_CODES.S)
27692751
private void reloadEnableUsbDataSignalingUi() {
27702752
if (isOrganizationOwnedDevice()) {
2771-
try {
2772-
boolean enabled = ReflectionUtil.invoke(mDevicePolicyManager,
2773-
"isUsbDataSignalingEnabled");
2774-
mEnableUsbDataSignalingPreference.setChecked(enabled);
2775-
} catch (ReflectionIsTemporaryException e) {
2776-
Log.e(TAG, "Error invoking isUsbDataSignalingEnabled", e);
2777-
}
2753+
boolean enabled = mDevicePolicyManager.isUsbDataSignalingEnabled();
2754+
mEnableUsbDataSignalingPreference.setChecked(enabled);
27782755
}
27792756
}
27802757

0 commit comments

Comments
 (0)