Skip to content
This repository was archived by the owner on Oct 3, 2024. It is now read-only.

Commit 4540513

Browse files
committed
Respond to review comments
Change-Id: Ie03a23b5b04af5146b887101566d765315cad356
1 parent e64510d commit 4540513

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ ext {
3131

3232
mavenGroup = 'pub.devrel'
3333
mavenArtifactId = 'easypermissions'
34-
mavenVersion = '2.0.0'
34+
mavenVersion = '2.0.1-SNAPSHOT'
3535

3636
bintrayOrg = 'easygoogle'
3737

easypermissions/src/test/java/pub/devrel/easypermissions/EasyPermissionsLowApiTest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,10 @@ public class EasyPermissionsLowApiTest {
3939
Manifest.permission.READ_SMS, Manifest.permission.ACCESS_FINE_LOCATION};
4040

4141
private TestActivity spyActivity;
42-
private TestAppCompatActivity spySupportActivity;
42+
private TestAppCompatActivity spyAppCompatActivity;
4343
private TestFragment spyFragment;
4444
private ActivityController<TestActivity> activityController;
45-
private ActivityController<TestAppCompatActivity> supportActivityController;
45+
private ActivityController<TestAppCompatActivity> appCompatActivityController;
4646
private SupportFragmentController<TestFragment> supportController;
4747
@Captor
4848
private ArgumentCaptor<Integer> integerCaptor;
@@ -84,9 +84,9 @@ public void shouldCallbackOnPermissionGranted_whenRequestFromActivity() {
8484

8585
@Test
8686
public void shouldCallbackOnPermissionGranted_whenRequestFromSupportActivity() {
87-
EasyPermissions.requestPermissions(spySupportActivity, RATIONALE, TestAppCompatActivity.REQUEST_CODE, ALL_PERMS);
87+
EasyPermissions.requestPermissions(spyAppCompatActivity, RATIONALE, TestAppCompatActivity.REQUEST_CODE, ALL_PERMS);
8888

89-
verify(spySupportActivity, times(1))
89+
verify(spyAppCompatActivity, times(1))
9090
.onPermissionsGranted(integerCaptor.capture(), listCaptor.capture());
9191
assertThat(integerCaptor.getValue()).isEqualTo(TestAppCompatActivity.REQUEST_CODE);
9292
assertThat(listCaptor.getValue()).containsAllIn(ALL_PERMS);
@@ -105,19 +105,19 @@ public void shouldCallbackOnPermissionGranted_whenRequestFromFragment() {
105105
private void setUpActivityAndFragment() {
106106
activityController = Robolectric.buildActivity(TestActivity.class)
107107
.create().start().resume();
108-
supportActivityController = Robolectric.buildActivity(TestAppCompatActivity.class)
108+
appCompatActivityController = Robolectric.buildActivity(TestAppCompatActivity.class)
109109
.create().start().resume();
110110
supportController = SupportFragmentController.of(new TestFragment())
111111
.create().start().resume();
112112

113113
spyActivity = Mockito.spy(activityController.get());
114-
spySupportActivity = Mockito.spy(supportActivityController.get());
114+
spyAppCompatActivity = Mockito.spy(appCompatActivityController.get());
115115
spyFragment = Mockito.spy(supportController.get());
116116
}
117117

118118
private void tearDownActivityAndFragment() {
119119
activityController.pause().stop().destroy();
120-
supportActivityController.pause().stop().destroy();
120+
appCompatActivityController.pause().stop().destroy();
121121
supportController.pause().stop().destroy();
122122
}
123123
}

0 commit comments

Comments
 (0)