Add tests for requestPermissions methods when low API

Author: Henrique Faria

easypermissions/src/test/java/pub/devrel/easypermissions/EasyPermissionsLowApiTest.java

@@ -2,13 +2,29 @@
 
 import android.Manifest;
 
+import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
+import org.mockito.ArgumentCaptor;
+import org.mockito.Captor;
+import org.mockito.Mockito;
+import org.mockito.MockitoAnnotations;
+import org.robolectric.Robolectric;
 import org.robolectric.RobolectricTestRunner;
 import org.robolectric.RuntimeEnvironment;
 import org.robolectric.annotation.Config;
+import org.robolectric.shadows.ShadowApplication;
+import org.robolectric.shadows.support.v4.SupportFragmentController;
+
+import java.util.ArrayList;
+
+import pub.devrel.easypermissions.testhelper.TestActivity;
+import pub.devrel.easypermissions.testhelper.TestFragment;
+import pub.devrel.easypermissions.testhelper.TestSupportFragment;
 
 import static com.google.common.truth.Truth.assertThat;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
 
 /**
  * Low-API (SDK = 19) tests for {@link pub.devrel.easypermissions.EasyPermissions}.
@@ -17,12 +33,71 @@
 @Config(sdk = 19)
 public class EasyPermissionsLowApiTest {
 
+    private static final int REQUEST_CODE = 10;
+    private static final String RATIONALE = "RATIONALE";
+    private static final String[] ALL_PERMS = new String[]{
+            Manifest.permission.READ_SMS, Manifest.permission.ACCESS_FINE_LOCATION};
+
+    private TestActivity spyActivity;
+    private TestFragment spyFragment;
+    private TestSupportFragment spySupportFragment;
+    @Captor
+    private ArgumentCaptor<Integer> integerCaptor;
+    @Captor
+    private ArgumentCaptor<ArrayList<String>> listCaptor;
+
+    @Before
+    public void setUp() {
+        MockitoAnnotations.initMocks(this);
+        setUpActivityAndFragment();
+    }
+
     @Test
     public void shouldHavePermission_whenHasPermissionsBeforeMarshmallow() {
-        // On low-API devices, we should always get 'true' when we call 'hasPermissions'
         assertThat(EasyPermissions.hasPermissions(RuntimeEnvironment.application,
                 Manifest.permission.ACCESS_COARSE_LOCATION)).isTrue();
     }
 
-    //TODO: call all needed methods and expect IllegalStateException
+    @Test
+    public void shouldCallbackOnPermissionGranted_whenRequestFromActivity() {
+        EasyPermissions.requestPermissions(spyActivity, RATIONALE, REQUEST_CODE, ALL_PERMS);
+
+        verify(spyActivity, times(1))
+                .onPermissionsGranted(integerCaptor.capture(), listCaptor.capture());
+        assertThat(integerCaptor.getValue()).isEqualTo(REQUEST_CODE);
+        assertThat(listCaptor.getValue()).containsAllIn(ALL_PERMS);
+    }
+
+    @Test
+    public void shouldCallbackOnPermissionGranted_whenRequestFromFragment() {
+        EasyPermissions.requestPermissions(spyFragment, RATIONALE, REQUEST_CODE, ALL_PERMS);
+
+        verify(spyFragment, times(1))
+                .onPermissionsGranted(integerCaptor.capture(), listCaptor.capture());
+        assertThat(integerCaptor.getValue()).isEqualTo(REQUEST_CODE);
+        assertThat(listCaptor.getValue()).containsAllIn(ALL_PERMS);
+    }
+
+    @Test
+    public void shouldCallbackOnPermissionGranted_whenRequestFromSupportedFragment() {
+        EasyPermissions.requestPermissions(spySupportFragment, RATIONALE, REQUEST_CODE, ALL_PERMS);
+
+        verify(spySupportFragment, times(1))
+                .onPermissionsGranted(integerCaptor.capture(), listCaptor.capture());
+        assertThat(integerCaptor.getValue()).isEqualTo(REQUEST_CODE);
+        assertThat(listCaptor.getValue()).containsAllIn(ALL_PERMS);
+    }
+
+    private void setUpActivityAndFragment() {
+        TestActivity activity = Robolectric.buildActivity(TestActivity.class)
+                .create().start().resume().get();
+        TestFragment fragment = Robolectric.buildFragment(TestFragment.class)
+                .create().start().resume().get();
+        TestSupportFragment supportFragment = SupportFragmentController.of(new TestSupportFragment())
+                .create().start().resume().get();
+
+        spyActivity = Mockito.spy(activity);
+        spyFragment = Mockito.spy(fragment);
+        spySupportFragment = Mockito.spy(supportFragment);
+    }
 }

easypermissions/src/test/java/pub/devrel/easypermissions/EasyPermissionsTest.java

@@ -93,7 +93,7 @@ public void shouldThrowException_whenHasPermissionsWithNullContext() {
     }
 
     @Test
-    public void shouldCallbackOnPermissionGranted_whenRequestAlreadyGrantedPermissionFromActivity() {
+    public void shouldCallbackOnPermissionGranted_whenRequestAlreadyGrantedPermissionsFromActivity() {
         grantPermissions(ALL_PERMS);
 
         EasyPermissions.requestPermissions(spyActivity, RATIONALE, REQUEST_CODE, ALL_PERMS);
@@ -148,7 +148,7 @@ public void shouldShowCorrectDialogUsingDeprecated_whenMissingPermissionsAndShow
     }
 
     @Test
-    public void shouldCallbackOnPermissionGranted_whenRequestAlreadyGrantedPermissionFromFragment() {
+    public void shouldCallbackOnPermissionGranted_whenRequestAlreadyGrantedPermissionsFromFragment() {
         grantPermissions(ALL_PERMS);
 
         EasyPermissions.requestPermissions(spyFragment, RATIONALE, REQUEST_CODE, ALL_PERMS);
@@ -203,7 +203,7 @@ public void shouldShowCorrectDialogUsingDeprecated_whenMissingPermissionsAndShow
     }
 
     @Test
-    public void shouldCallbackOnPermissionGranted_whenRequestAlreadyGrantedPermissionFromSupportFragment() {
+    public void shouldCallbackOnPermissionGranted_whenRequestAlreadyGrantedPermissionsFromSupportFragment() {
         grantPermissions(ALL_PERMS);
 
         EasyPermissions.requestPermissions(spySupportFragment, RATIONALE, REQUEST_CODE, ALL_PERMS);

easypermissions/src/test/java/pub/devrel/easypermissions/testhelper/TestSupportFragment.java

@@ -19,6 +19,7 @@ public class TestSupportFragment extends Fragment implements EasyPermissions.Per
     @Nullable
     @Override
     public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) {
+        // Support Fragments should use AppCompat or derived themes
         getContext().getTheme().applyStyle(R.style.Theme_AppCompat, true);
         return super.onCreateView(inflater, container, savedInstanceState);
     }