style: more manual lint error fixes

Author: jpoehnelt

.github/scripts/check-gs.ts

@@ -167,9 +167,9 @@ async function checkProject(
 	);
 
 	try {
-		await execAsync(`tsc -p "${projectTempDir}"`, { cwd: rootDir });
+		await execAsync(`tsc -p \"${projectTempDir}\"`, { cwd: rootDir });
 		return { name: project.name, success: true, output: "" };
-	} catch (e: any) {
+	} catch (e: { stdout: string; stderr: string }) {
 		const rawOutput = (e.stdout || "") + (e.stderr || "");
 
 		const rewritten = rawOutput

solutions/automations/offsite-activity-signup/Code.js

@@ -116,9 +116,9 @@ function assignWithRandomPriority_(
 	}, {});
 	for (let i = 0; i < numActivitiesPerPerson; ++i) {
 		const randomizedAttendees = shuffleArray_(attendees);
-		randomizedAttendees.forEach((attendee) => {
+		for (const attendee of randomizedAttendees) {
 			makeChoice_(attendee, activitiesById);
-		});
+		}
 	}
 }
 
@@ -201,7 +201,6 @@ function writeAttendeeAssignments_(ss, attendees) {
 function writeActivityRosters_(ss, activities) {
 	const sheet = findOrCreateSheetByName_(ss, "Activity rosters");
 	sheet.clear();
-	const rows = [];
 	let rows = activities.map((activity) => {
 		const roster = activity.roster.map((attendee) => attendee.email);
 		return [activity.description].concat(roster);
@@ -330,9 +329,9 @@ function generateTestData_() {
 
 	const activities = loadActivitySchedule_(ss);
 	const choices = fillArray_([], activities.length, "");
-	range_(1, 5).forEach((value) => {
+	for (const value of range_(1, 5)) {
 		choices[value] = toOrdinal_(value);
-	});
+	}
 
 	const rows = range_(1, NUM_TEST_USERS).map((value) => {
 		const randomizedChoices = shuffleArray_(choices);
@@ -457,7 +456,8 @@ function range_(start, end) {
 	const arr = [start];
 	let i = start;
 	while (i < end) {
-		arr.push((i += 1));
+		i += 1;
+		arr.push(i);
 	}
 	return arr;
 }
@@ -473,12 +473,12 @@ function range_(start, end) {
  */
 function transpose_(arr, fillValue) {
 	const transposed = [];
-	arr.forEach((row, rowIndex) => {
-		row.forEach((col, colIndex) => {
+	for (const [rowIndex, row] of arr.entries()) {
+		for (const [colIndex, col] of row.entries()) {
 			transposed[colIndex] =
 				transposed[colIndex] || fillArray_([], arr.length, fillValue);
 			transposed[colIndex][rowIndex] = row[colIndex];
-		});
-	});
+		}
+	}
 	return transposed;
 }

solutions/automations/upload-files/Code.js

@@ -75,10 +75,10 @@ function onFormSubmit(e) {
 
 		// Moves the files to the destination folder.
 		if (fileUploads.length > 0) {
-			fileUploads.forEach((fileId) => {
+			for (const fileId of fileUploads) {
 				DriveApp.getFileById(fileId).moveTo(destFolder);
 				console.log(`File Copied: ${fileId}`);
-			});
+			}
 		}
 	} catch (err) {
 		console.log(err);

solutions/automations/youtube-tracker/Code.js

@@ -37,7 +37,7 @@ function markVideos() {
 	const sheets = SpreadsheetApp.getActiveSpreadsheet().getSheets();
 
 	// Runs through process for each tab in Spreadsheet.
-	sheets.forEach((dataSheet) => {
+	for (const dataSheet of sheets) {
 		const tabName = dataSheet.getName();
 		const range = dataSheet.getDataRange();
 		const numRows = range.getNumRows();
@@ -96,7 +96,7 @@ function markVideos() {
 		if (emailContent.length > 0 && EMAIL_ON === "Y") {
 			sendEmailNotificationTemplate(emailContent, tabName);
 		}
-	});
+	}
 }
 
 /**

solutions/editor-add-on/clean-sheet/Code.js

@@ -84,9 +84,9 @@ function deleteEmptyRows() {
 	console.log(rangesToDelete);
 
 	// Deletes the rows using REVERSE order to ensure proper indexing is used.
-	rangesToDelete
-		.reverse()
-		.forEach(([start, end]) => sheet.deleteRows(start, end - start + 1));
+	for (const [start, end] of rangesToDelete.reverse()) {
+		sheet.deleteRows(start, end - start + 1);
+	}
 	SpreadsheetApp.flush();
 }
 
@@ -159,9 +159,9 @@ function deleteEmptyColumns() {
 	console.log(rangesToDelete);
 
 	// Deletes the columns using REVERSE order to ensure proper indexing is used.
-	rangesToDelete
-		.reverse()
-		.forEach(([start, end]) => sheet.deleteColumns(start, end - start + 1));
+	for (const [start, end] of rangesToDelete.reverse()) {
+		sheet.deleteColumns(start, end - start + 1);
+	}
 	SpreadsheetApp.flush();
 }