fix: prevent scheduleBuild from running when element is not connected

jpoehnelt · jpoehnelt · commit 84c485ffcb5d · 2025-09-11T09:09:13.000-06:00
diff --git a/src/drive-picker/drive-picker-element.ts b/src/drive-picker/drive-picker-element.ts
@@ -181,6 +181,8 @@ export class DrivePickerElement extends HTMLElement {
 	}
 
 	attributeChangedCallback() {
+		if (!this.isConnected) return;
+
 		this.scheduleBuild();
 	}
 
@@ -302,6 +304,8 @@ export class DrivePickerElement extends HTMLElement {
 			subtree: true,
 			attributes: true,
 		});
+
+		this.scheduleBuild();
 	}
 
 	private callbackToDispatchEvent(detail: google.picker.ResponseObject) {

Original file line number	Diff line number	Diff line change
`@@ -181,6 +181,8 @@ export class DrivePickerElement extends HTMLElement {`
`181`	`181`	`}`
`182`	`182`
`183`	`183`	`attributeChangedCallback() {`
	`184`	`+ if (!this.isConnected) return;`
	`185`	`+`
`184`	`186`	`this.scheduleBuild();`
`185`	`187`	`}`
`186`	`188`
`@@ -302,6 +304,8 @@ export class DrivePickerElement extends HTMLElement {`
`302`	`304`	`subtree: true,`
`303`	`305`	`attributes: true,`
`304`	`306`	`});`
	`307`	`+`
	`308`	`+ this.scheduleBuild();`
`305`	`309`	`}`
`306`	`310`
`307`	`311`	`private callbackToDispatchEvent(detail: google.picker.ResponseObject) {`