Revamp body validation and fix diagnostic drops + CHANGELOG update

Author: yuval-po

changelog/CHANGELOG.md

@@ -82,6 +82,26 @@ Previously, alias support was limited and resulted in the aliased type effective
 * Added a global `ApiValidator` as the entry point to the HIR validation subsystem.</br>
   This currently includes a URL conflict detection algorithm to emit diagnostics upon route conflicts such as between `POST /a/b/c` and `POST /a/{foo}/c`
 
+* Added an explicit visitor error when using interfaces in general and `interface{}` in particular
+
+* Added a validation error when passing arrays via inputs that do not accept them (i.e., a URL parameter)
+
+
+### Bugfixes
+
+* Fixed array/slice support. Previously resulted in broken generated code
+
+* Fixed cases where model fields were named after the type rather than the field name or JSON tag
+
+* Fixed an issue where `any` yielded an `object` schema entity rather than a 'map-like' one, i.e.,
+```json
+ "someField": {
+	"additionalProperties": {
+    	"type": "object"
+	},
+	"type": "object"
+}
+```
 
 ------------------
 

core/validators/receiver.validator.go

@@ -91,7 +91,7 @@ func (v ReceiverValidator) validateParams(receiver *metadata.ReceiverMeta) ([]di
 			return diags, err
 		}
 
-		common.AppendIfNotNil(diags, diag)
+		diags = common.AppendIfNotNil(diags, diag)
 		if passedIn == nil {
 			// If we couldn't process the passedIn portion, no reason in continuing.
 			// An error or error diagnostic will have been added, at this point.
@@ -100,12 +100,12 @@ func (v ReceiverValidator) validateParams(receiver *metadata.ReceiverMeta) ([]di
 
 		switch *passedIn {
 		case definitions.PassedInBody:
-			common.AppendIfNotNil(diags, v.validateBodyParam(receiver, param))
+			diags = common.AppendIfNotNil(diags, v.validateBodyParam(receiver, param))
 		default:
-			common.AppendIfNotNil(diags, v.validateNonBodyParam(receiver, param, *passedIn))
+			diags = common.AppendIfNotNil(diags, v.validateNonBodyParam(receiver, param, *passedIn))
 		}
 
-		common.AppendIfNotNil(diags, v.validateParamsCombinations(processedParams, param, *passedIn))
+		diags = common.AppendIfNotNil(diags, v.validateParamsCombinations(processedParams, param, *passedIn))
 
 		processedParams = append(processedParams, funcParamEx{FuncParam: param, PassedIn: *passedIn})
 	}
@@ -155,21 +155,15 @@ func (v ReceiverValidator) validateBodyParam(
 	receiver *metadata.ReceiverMeta,
 	param metadata.FuncParam,
 ) *diagnostics.ResolvedDiagnostic {
-	// Verify the body is a struct
-	if param.SymbolKind != common.SymKindStruct {
-		nameInSchema, err := metadata.GetParameterSchemaName(param.Name, param.Annotations)
-		if err != nil {
-			nameInSchema = "unknown"
-		}
-
+	// Verify the body is not a built-in
+	if param.Type.SymbolKind.IsBuiltin() {
 		diag := diagnostics.NewErrorDiagnostic(
 			receiver.Annotations.FileName(),
 			fmt.Sprintf(
-				"body parameters must be structs but '%s' (schema name '%s', type '%s') is of kind '%s'",
+				"body parameter '%s' (schema name '%s', type '%s') is a built-in primitive or special (e.g. time.Time) which is not allowed",
 				param.Name,
-				nameInSchema,
+				getParamSchemaNameOrFallback(param, "unknown"),
 				param.Type.Name,
-				param.Type.SymbolKind,
 			),
 			diagnostics.DiagReceiverInvalidBody,
 			param.Range,