Skip to content

Commit 81537f2

Browse files
committed
Don't require to shell-escape conf_overrides
Use heredoc syntax to append the value of `conf_overrides` to the `local.conf` file. Compared to the previous solution using `echo`, this removes the need to shell escape your value. Also remove the useless test, since the default value for `inputs.conf_overrides` is an empty string which results in a noop. Fixes #19.
1 parent c41f86d commit 81537f2

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

action.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,9 @@ runs:
8181
echo "ENABLED_SERVICES+=${ENABLED_SERVICES}" >> local.conf
8282
8383
# This must stay at the end to allow any overrides
84-
if [[ "${{ inputs.conf_overrides }}" != "" ]]; then
85-
echo "${{ inputs.conf_overrides }}" >> local.conf
86-
fi
84+
cat << EOF_CONF_OVERRIDES >> local.conf
85+
${{ inputs.conf_overrides }}
86+
EOF_CONF_OVERRIDES
8787
working-directory: ./devstack
8888
shell: bash
8989
- name: Run devstack

0 commit comments

Comments
 (0)