diff --git a/gnocchi/metric/v1/archivepolicies/testing/requests_test.go b/gnocchi/metric/v1/archivepolicies/testing/requests_test.go index 68518a8..2d89f90 100644 --- a/gnocchi/metric/v1/archivepolicies/testing/requests_test.go +++ b/gnocchi/metric/v1/archivepolicies/testing/requests_test.go @@ -13,10 +13,10 @@ import ( ) func TestListArchivePolicies(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/archive_policy", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/archive_policy", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "GET") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) @@ -28,7 +28,7 @@ func TestListArchivePolicies(t *testing.T) { expected := ListArchivePoliciesExpected pages := 0 - err := archivepolicies.List(fake.ServiceClient()).EachPage(context.TODO(), func(_ context.Context, page pagination.Page) (bool, error) { + err := archivepolicies.List(fake.ServiceClient(fakeServer)).EachPage(context.TODO(), func(_ context.Context, page pagination.Page) (bool, error) { pages++ actual, err := archivepolicies.ExtractArchivePolicies(page) @@ -46,10 +46,10 @@ func TestListArchivePolicies(t *testing.T) { } func TestListArchivePoliciesAllPages(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/archive_policy", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/archive_policy", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "GET") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) @@ -59,17 +59,17 @@ func TestListArchivePoliciesAllPages(t *testing.T) { fmt.Fprint(w, ArchivePoliciesListResult) }) - allPages, err := archivepolicies.List(fake.ServiceClient()).AllPages(context.TODO()) + allPages, err := archivepolicies.List(fake.ServiceClient(fakeServer)).AllPages(context.TODO()) th.AssertNoErr(t, err) _, err = archivepolicies.ExtractArchivePolicies(allPages) th.AssertNoErr(t, err) } func TestGetArchivePolicy(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/archive_policy/test_policy", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/archive_policy/test_policy", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "GET") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) @@ -79,7 +79,7 @@ func TestGetArchivePolicy(t *testing.T) { fmt.Fprint(w, ArchivePolicyGetResult) }) - s, err := archivepolicies.Get(context.TODO(), fake.ServiceClient(), "test_policy").Extract() + s, err := archivepolicies.Get(context.TODO(), fake.ServiceClient(fakeServer), "test_policy").Extract() th.AssertNoErr(t, err) th.AssertDeepEquals(t, s.AggregationMethods, []string{ @@ -104,10 +104,10 @@ func TestGetArchivePolicy(t *testing.T) { } func TestCreate(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/archive_policy", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/archive_policy", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "POST") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) th.TestHeader(t, r, "Content-Type", "application/json") @@ -139,7 +139,7 @@ func TestCreate(t *testing.T) { }, Name: "test_policy", } - s, err := archivepolicies.Create(context.TODO(), fake.ServiceClient(), opts).Extract() + s, err := archivepolicies.Create(context.TODO(), fake.ServiceClient(fakeServer), opts).Extract() th.AssertNoErr(t, err) th.AssertDeepEquals(t, s.AggregationMethods, []string{ @@ -164,10 +164,10 @@ func TestCreate(t *testing.T) { } func TestUpdateArchivePolicy(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/archive_policy/test_policy", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/archive_policy/test_policy", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "PATCH") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) th.TestHeader(t, r, "Content-Type", "application/json") @@ -192,7 +192,7 @@ func TestUpdateArchivePolicy(t *testing.T) { }, }, } - s, err := archivepolicies.Update(context.TODO(), fake.ServiceClient(), "test_policy", updateOpts).Extract() + s, err := archivepolicies.Update(context.TODO(), fake.ServiceClient(fakeServer), "test_policy", updateOpts).Extract() th.AssertNoErr(t, err) th.AssertDeepEquals(t, s.AggregationMethods, []string{ @@ -215,15 +215,15 @@ func TestUpdateArchivePolicy(t *testing.T) { } func TestDelete(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/archive_policy/test_policy", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/archive_policy/test_policy", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "DELETE") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) w.WriteHeader(http.StatusNoContent) }) - res := archivepolicies.Delete(context.TODO(), fake.ServiceClient(), "test_policy") + res := archivepolicies.Delete(context.TODO(), fake.ServiceClient(fakeServer), "test_policy") th.AssertNoErr(t, res.Err) } diff --git a/gnocchi/metric/v1/measures/testing/requests_test.go b/gnocchi/metric/v1/measures/testing/requests_test.go index 9a7b1ec..1e1d40e 100644 --- a/gnocchi/metric/v1/measures/testing/requests_test.go +++ b/gnocchi/metric/v1/measures/testing/requests_test.go @@ -14,10 +14,10 @@ import ( ) func TestListMeasures(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/metric/9e5a6441-1044-4181-b66e-34e180753040/measures", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/metric/9e5a6441-1044-4181-b66e-34e180753040/measures", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "GET") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) @@ -37,7 +37,7 @@ func TestListMeasures(t *testing.T) { } expected := ListMeasuresExpected pages := 0 - err := measures.List(fake.ServiceClient(), metricID, opts).EachPage(context.TODO(), func(_ context.Context, page pagination.Page) (bool, error) { + err := measures.List(fake.ServiceClient(fakeServer), metricID, opts).EachPage(context.TODO(), func(_ context.Context, page pagination.Page) (bool, error) { pages++ actual, err := measures.ExtractMeasures(page) @@ -55,10 +55,10 @@ func TestListMeasures(t *testing.T) { } func TestCreateMeasures(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/metric/9e5a6441-1044-4181-b66e-34e180753040/measures", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/metric/9e5a6441-1044-4181-b66e-34e180753040/measures", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "POST") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) th.TestHeader(t, r, "Content-Type", "application/json") @@ -81,15 +81,15 @@ func TestCreateMeasures(t *testing.T) { }, }, } - res := measures.Create(context.TODO(), fake.ServiceClient(), "9e5a6441-1044-4181-b66e-34e180753040", createOpts) + res := measures.Create(context.TODO(), fake.ServiceClient(fakeServer), "9e5a6441-1044-4181-b66e-34e180753040", createOpts) th.AssertNoErr(t, res.Err) } func TestBatchCreateMetrics(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/batch/metrics/measures", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/batch/metrics/measures", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "POST") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) th.TestHeader(t, r, "Content-Type", "application/json") @@ -128,15 +128,15 @@ func TestBatchCreateMetrics(t *testing.T) { }, }, } - err := measures.BatchCreateMetrics(context.TODO(), fake.ServiceClient(), createOpts).ExtractErr() + err := measures.BatchCreateMetrics(context.TODO(), fake.ServiceClient(fakeServer), createOpts).ExtractErr() th.AssertNoErr(t, err) } func TestBatchCreateResourcesMetrics(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/batch/resources/metrics/measures", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/batch/resources/metrics/measures", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "POST") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) th.TestHeader(t, r, "Content-Type", "application/json") @@ -207,6 +207,6 @@ func TestBatchCreateResourcesMetrics(t *testing.T) { }, }, } - err := measures.BatchCreateResourcesMetrics(context.TODO(), fake.ServiceClient(), createOpts).ExtractErr() + err := measures.BatchCreateResourcesMetrics(context.TODO(), fake.ServiceClient(fakeServer), createOpts).ExtractErr() th.AssertNoErr(t, err) } diff --git a/gnocchi/metric/v1/metrics/testing/requests_test.go b/gnocchi/metric/v1/metrics/testing/requests_test.go index 993c549..40b09b5 100644 --- a/gnocchi/metric/v1/metrics/testing/requests_test.go +++ b/gnocchi/metric/v1/metrics/testing/requests_test.go @@ -16,10 +16,10 @@ import ( ) func TestList(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/metric", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/metric", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "GET") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) @@ -40,7 +40,7 @@ func TestList(t *testing.T) { count := 0 - err := metrics.List(fake.ServiceClient(), metrics.ListOpts{}).EachPage(context.TODO(), func(_ context.Context, page pagination.Page) (bool, error) { + err := metrics.List(fake.ServiceClient(fakeServer), metrics.ListOpts{}).EachPage(context.TODO(), func(_ context.Context, page pagination.Page) (bool, error) { count++ actual, err := metrics.ExtractMetrics(page) if err != nil { @@ -65,10 +65,10 @@ func TestList(t *testing.T) { } func TestGet(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/metric/0ddf61cf-3747-4f75-bf13-13c28ff03ae3", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/metric/0ddf61cf-3747-4f75-bf13-13c28ff03ae3", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "GET") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) @@ -78,7 +78,7 @@ func TestGet(t *testing.T) { fmt.Fprint(w, MetricGetResult) }) - s, err := metrics.Get(context.TODO(), fake.ServiceClient(), "0ddf61cf-3747-4f75-bf13-13c28ff03ae3").Extract() + s, err := metrics.Get(context.TODO(), fake.ServiceClient(fakeServer), "0ddf61cf-3747-4f75-bf13-13c28ff03ae3").Extract() th.AssertNoErr(t, err) th.AssertDeepEquals(t, s.ArchivePolicy, archivepolicies.ArchivePolicy{ @@ -125,10 +125,10 @@ func TestGet(t *testing.T) { } func TestCreate(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/metric", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/metric", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "POST") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) th.TestHeader(t, r, "Content-Type", "application/json") @@ -147,7 +147,7 @@ func TestCreate(t *testing.T) { ResourceID: "23d5d3f7-9dfa-4f73-b72b-8b0b0063ec55", Unit: "B/s", } - s, err := metrics.Create(context.TODO(), fake.ServiceClient(), opts).Extract() + s, err := metrics.Create(context.TODO(), fake.ServiceClient(fakeServer), opts).Extract() th.AssertNoErr(t, err) th.AssertEquals(t, s.ArchivePolicyName, "high") @@ -161,15 +161,15 @@ func TestCreate(t *testing.T) { } func TestDelete(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/metric/01b2953e-de74-448a-a305-c84440697933", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/metric/01b2953e-de74-448a-a305-c84440697933", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "DELETE") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) w.WriteHeader(http.StatusNoContent) }) - res := metrics.Delete(context.TODO(), fake.ServiceClient(), "01b2953e-de74-448a-a305-c84440697933") + res := metrics.Delete(context.TODO(), fake.ServiceClient(fakeServer), "01b2953e-de74-448a-a305-c84440697933") th.AssertNoErr(t, res.Err) } diff --git a/gnocchi/metric/v1/resources/testing/requests_test.go b/gnocchi/metric/v1/resources/testing/requests_test.go index f57e608..1a8056a 100644 --- a/gnocchi/metric/v1/resources/testing/requests_test.go +++ b/gnocchi/metric/v1/resources/testing/requests_test.go @@ -14,10 +14,10 @@ import ( ) func TestList(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/resource/generic", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/resource/generic", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "GET") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) @@ -38,7 +38,7 @@ func TestList(t *testing.T) { count := 0 - err := resources.List(fake.ServiceClient(), resources.ListOpts{}, "generic").EachPage(context.TODO(), func(_ context.Context, page pagination.Page) (bool, error) { + err := resources.List(fake.ServiceClient(fakeServer), resources.ListOpts{}, "generic").EachPage(context.TODO(), func(_ context.Context, page pagination.Page) (bool, error) { count++ actual, err := resources.ExtractResources(page) if err != nil { @@ -63,10 +63,10 @@ func TestList(t *testing.T) { } func TestGet(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/resource/compute_instance_network/75274f99-faf6-4112-a6d5-2794cb07c789", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/resource/compute_instance_network/75274f99-faf6-4112-a6d5-2794cb07c789", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "GET") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) @@ -76,7 +76,7 @@ func TestGet(t *testing.T) { fmt.Fprint(w, ResourceGetResult) }) - s, err := resources.Get(context.TODO(), fake.ServiceClient(), "compute_instance_network", "75274f99-faf6-4112-a6d5-2794cb07c789").Extract() + s, err := resources.Get(context.TODO(), fake.ServiceClient(fakeServer), "compute_instance_network", "75274f99-faf6-4112-a6d5-2794cb07c789").Extract() th.AssertNoErr(t, err) th.AssertEquals(t, s.CreatedByProjectID, "3d40ca37723449118987b9f288f4ae84") @@ -103,10 +103,10 @@ func TestGet(t *testing.T) { } func TestCreateWithoutMetrics(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/resource/generic", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/resource/generic", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "POST") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) th.TestHeader(t, r, "Content-Type", "application/json") @@ -124,7 +124,7 @@ func TestCreateWithoutMetrics(t *testing.T) { ProjectID: "4154f088-8333-4e04-94c4-1155c33c0fc9", UserID: "bd5874d6-6662-4b24-a9f01c128871e4ac", } - s, err := resources.Create(context.TODO(), fake.ServiceClient(), "generic", opts).Extract() + s, err := resources.Create(context.TODO(), fake.ServiceClient(fakeServer), "generic", opts).Extract() th.AssertNoErr(t, err) th.AssertEquals(t, s.CreatedByProjectID, "3d40ca37-7234-4911-8987b9f288f4ae84") @@ -143,10 +143,10 @@ func TestCreateWithoutMetrics(t *testing.T) { } func TestCreateLinkMetrics(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/resource/compute_instance_network", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/resource/compute_instance_network", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "POST") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) th.TestHeader(t, r, "Content-Type", "application/json") @@ -172,7 +172,7 @@ func TestCreateLinkMetrics(t *testing.T) { "network.outgoing.bytes.rate": "dc9f3198-155b-4b88-a92c-58a3853ce2b2", }, } - s, err := resources.Create(context.TODO(), fake.ServiceClient(), "compute_instance_network", opts).Extract() + s, err := resources.Create(context.TODO(), fake.ServiceClient(fakeServer), "compute_instance_network", opts).Extract() th.AssertNoErr(t, err) th.AssertEquals(t, s.CreatedByProjectID, "3d40ca37-7234-4911-8987b9f288f4ae84") @@ -194,10 +194,10 @@ func TestCreateLinkMetrics(t *testing.T) { } func TestCreateWithMetrics(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/resource/compute_instance_disk", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/resource/compute_instance_disk", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "POST") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) th.TestHeader(t, r, "Content-Type", "application/json") @@ -222,7 +222,7 @@ func TestCreateWithMetrics(t *testing.T) { }, }, } - s, err := resources.Create(context.TODO(), fake.ServiceClient(), "compute_instance_disk", opts).Extract() + s, err := resources.Create(context.TODO(), fake.ServiceClient(fakeServer), "compute_instance_disk", opts).Extract() th.AssertNoErr(t, err) th.AssertEquals(t, s.CreatedByProjectID, "3d40ca37-7234-4911-8987b9f288f4ae84") @@ -243,10 +243,10 @@ func TestCreateWithMetrics(t *testing.T) { } func TestUpdateLinkMetrics(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/resource/compute_instance_network/23d5d3f7-9dfa-4f73-b72b-8b0b0063ec55", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/resource/compute_instance_network/23d5d3f7-9dfa-4f73-b72b-8b0b0063ec55", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "PATCH") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) th.TestHeader(t, r, "Content-Type", "application/json") @@ -267,7 +267,7 @@ func TestUpdateLinkMetrics(t *testing.T) { EndedAt: &endedAt, Metrics: &metrics, } - s, err := resources.Update(context.TODO(), fake.ServiceClient(), "compute_instance_network", "23d5d3f7-9dfa-4f73-b72b-8b0b0063ec55", updateOpts).Extract() + s, err := resources.Update(context.TODO(), fake.ServiceClient(fakeServer), "compute_instance_network", "23d5d3f7-9dfa-4f73-b72b-8b0b0063ec55", updateOpts).Extract() th.AssertNoErr(t, err) th.AssertEquals(t, s.CreatedByProjectID, "3d40ca37-7234-4911-8987b9f288f4ae84") @@ -288,10 +288,10 @@ func TestUpdateLinkMetrics(t *testing.T) { } func TestUpdateCreateMetrics(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/resource/compute_instance_network/23d5d3f7-9dfa-4f73-b72b-8b0b0063ec55", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/resource/compute_instance_network/23d5d3f7-9dfa-4f73-b72b-8b0b0063ec55", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "PATCH") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) th.TestHeader(t, r, "Content-Type", "application/json") @@ -314,7 +314,7 @@ func TestUpdateCreateMetrics(t *testing.T) { StartedAt: &startedAt, Metrics: &metrics, } - s, err := resources.Update(context.TODO(), fake.ServiceClient(), "compute_instance_network", "23d5d3f7-9dfa-4f73-b72b-8b0b0063ec55", updateOpts).Extract() + s, err := resources.Update(context.TODO(), fake.ServiceClient(fakeServer), "compute_instance_network", "23d5d3f7-9dfa-4f73-b72b-8b0b0063ec55", updateOpts).Extract() th.AssertNoErr(t, err) th.AssertEquals(t, s.CreatedByProjectID, "3d40ca37-7234-4911-8987b9f288f4ae84") @@ -335,15 +335,15 @@ func TestUpdateCreateMetrics(t *testing.T) { } func TestDelete(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/resource/generic/23d5d3f7-9dfa-4f73-b72b-8b0b0063ec55", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/resource/generic/23d5d3f7-9dfa-4f73-b72b-8b0b0063ec55", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "DELETE") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) w.WriteHeader(http.StatusNoContent) }) - res := resources.Delete(context.TODO(), fake.ServiceClient(), "generic", "23d5d3f7-9dfa-4f73-b72b-8b0b0063ec55") + res := resources.Delete(context.TODO(), fake.ServiceClient(fakeServer), "generic", "23d5d3f7-9dfa-4f73-b72b-8b0b0063ec55") th.AssertNoErr(t, res.Err) } diff --git a/gnocchi/metric/v1/resourcetypes/testing/requests_test.go b/gnocchi/metric/v1/resourcetypes/testing/requests_test.go index 594a115..2445f30 100644 --- a/gnocchi/metric/v1/resourcetypes/testing/requests_test.go +++ b/gnocchi/metric/v1/resourcetypes/testing/requests_test.go @@ -13,10 +13,10 @@ import ( ) func TestList(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/resource_type", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/resource_type", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "GET") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) @@ -28,7 +28,7 @@ func TestList(t *testing.T) { count := 0 - err := resourcetypes.List(fake.ServiceClient()).EachPage(context.TODO(), func(_ context.Context, page pagination.Page) (bool, error) { + err := resourcetypes.List(fake.ServiceClient(fakeServer)).EachPage(context.TODO(), func(_ context.Context, page pagination.Page) (bool, error) { count++ actual, err := resourcetypes.ExtractResourceTypes(page) if err != nil { @@ -54,10 +54,10 @@ func TestList(t *testing.T) { } func TestGet(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/resource_type/compute_instance", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/resource_type/compute_instance", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "GET") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) @@ -67,7 +67,7 @@ func TestGet(t *testing.T) { fmt.Fprint(w, ResourceTypeGetResult) }) - s, err := resourcetypes.Get(context.TODO(), fake.ServiceClient(), "compute_instance").Extract() + s, err := resourcetypes.Get(context.TODO(), fake.ServiceClient(fakeServer), "compute_instance").Extract() th.AssertNoErr(t, err) th.AssertEquals(t, s.Name, "compute_instance") @@ -91,10 +91,10 @@ func TestGet(t *testing.T) { } func TestCreateWithoutAttributes(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/resource_type", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/resource_type", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "POST") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) th.TestHeader(t, r, "Content-Type", "application/json") @@ -110,7 +110,7 @@ func TestCreateWithoutAttributes(t *testing.T) { opts := resourcetypes.CreateOpts{ Name: "identity_project", } - s, err := resourcetypes.Create(context.TODO(), fake.ServiceClient(), opts).Extract() + s, err := resourcetypes.Create(context.TODO(), fake.ServiceClient(fakeServer), opts).Extract() th.AssertNoErr(t, err) th.AssertEquals(t, s.Name, "identity_project") @@ -119,10 +119,10 @@ func TestCreateWithoutAttributes(t *testing.T) { } func TestCreateWithAttributes(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/resource_type", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/resource_type", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "POST") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) th.TestHeader(t, r, "Content-Type", "application/json") @@ -153,7 +153,7 @@ func TestCreateWithAttributes(t *testing.T) { }, }, } - s, err := resourcetypes.Create(context.TODO(), fake.ServiceClient(), opts).Extract() + s, err := resourcetypes.Create(context.TODO(), fake.ServiceClient(fakeServer), opts).Extract() th.AssertNoErr(t, err) th.AssertEquals(t, s.Name, "compute_instance_network") @@ -177,10 +177,10 @@ func TestCreateWithAttributes(t *testing.T) { } func TestUpdate(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/resource_type/identity_project", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/resource_type/identity_project", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "PATCH") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) th.TestHeader(t, r, "Content-Type", "application/json-patch+json") @@ -227,7 +227,7 @@ func TestUpdate(t *testing.T) { }, } - s, err := resourcetypes.Update(context.TODO(), fake.ServiceClient(), "identity_project", opts).Extract() + s, err := resourcetypes.Update(context.TODO(), fake.ServiceClient(fakeServer), "identity_project", opts).Extract() th.AssertNoErr(t, err) th.AssertEquals(t, s.Name, "identity_project") @@ -257,15 +257,15 @@ func TestUpdate(t *testing.T) { } func TestDelete(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/resource_type/compute_instance_network", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/resource_type/compute_instance_network", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "DELETE") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) w.WriteHeader(http.StatusNoContent) }) - res := resourcetypes.Delete(context.TODO(), fake.ServiceClient(), "compute_instance_network") + res := resourcetypes.Delete(context.TODO(), fake.ServiceClient(fakeServer), "compute_instance_network") th.AssertNoErr(t, res.Err) } diff --git a/gnocchi/metric/v1/status/testing/requests_test.go b/gnocchi/metric/v1/status/testing/requests_test.go index 3a056e4..a828915 100644 --- a/gnocchi/metric/v1/status/testing/requests_test.go +++ b/gnocchi/metric/v1/status/testing/requests_test.go @@ -12,10 +12,10 @@ import ( ) func TestGetWithDetails(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/status", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/status", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "GET") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) @@ -31,17 +31,17 @@ func TestGetWithDetails(t *testing.T) { Details: &details, } - s, err := status.Get(context.TODO(), fake.ServiceClient(), getOpts).Extract() + s, err := status.Get(context.TODO(), fake.ServiceClient(fakeServer), getOpts).Extract() th.AssertNoErr(t, err) th.AssertDeepEquals(t, s.Metricd, GetStatusWithDetailsExpected.Metricd) th.AssertDeepEquals(t, s.Storage, GetStatusWithDetailsExpected.Storage) } func TestGetWithoutDetails(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() - th.Mux.HandleFunc("/v1/status", func(w http.ResponseWriter, r *http.Request) { + fakeServer.Mux.HandleFunc("/v1/status", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "GET") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) @@ -57,7 +57,7 @@ func TestGetWithoutDetails(t *testing.T) { Details: &details, } - s, err := status.Get(context.TODO(), fake.ServiceClient(), getOpts).Extract() + s, err := status.Get(context.TODO(), fake.ServiceClient(fakeServer), getOpts).Extract() th.AssertNoErr(t, err) th.AssertDeepEquals(t, s.Metricd, GetStatusWithoutDetailsExpected.Metricd) th.AssertDeepEquals(t, s.Storage, GetStatusWithoutDetailsExpected.Storage) diff --git a/gnocchi/testhelper/client/fake.go b/gnocchi/testhelper/client/fake.go index 79ad34e..6e4cbf7 100644 --- a/gnocchi/testhelper/client/fake.go +++ b/gnocchi/testhelper/client/fake.go @@ -2,6 +2,7 @@ package client import ( "github.com/gophercloud/gophercloud/v2" + th "github.com/gophercloud/gophercloud/v2/testhelper" "github.com/gophercloud/gophercloud/v2/testhelper/client" ) @@ -9,8 +10,8 @@ import ( const TokenID = client.TokenID // ServiceClient returns a generic service client for use in tests. -func ServiceClient() *gophercloud.ServiceClient { - sc := client.ServiceClient() +func ServiceClient(fakeServer th.FakeServer) *gophercloud.ServiceClient { + sc := client.ServiceClient(fakeServer) sc.ResourceBase = sc.Endpoint + "v1/" return sc } diff --git a/go.mod b/go.mod index 1d04622..be03bd1 100644 --- a/go.mod +++ b/go.mod @@ -6,7 +6,7 @@ toolchain go1.24.1 require ( github.com/gofrs/uuid/v5 v5.3.2 - github.com/gophercloud/gophercloud/v2 v2.7.0 + github.com/gophercloud/gophercloud/v2 v2.8.0 golang.org/x/sys v0.35.0 golang.org/x/text v0.28.0 gopkg.in/yaml.v3 v3.0.1 diff --git a/go.sum b/go.sum index b9fb500..3bd2e06 100644 --- a/go.sum +++ b/go.sum @@ -1,7 +1,7 @@ github.com/gofrs/uuid/v5 v5.3.2 h1:2jfO8j3XgSwlz/wHqemAEugfnTlikAYHhnqQ8Xh4fE0= github.com/gofrs/uuid/v5 v5.3.2/go.mod h1:CDOjlDMVAtN56jqyRUZh58JT31Tiw7/oQyEXZV+9bD8= -github.com/gophercloud/gophercloud/v2 v2.7.0 h1:o0m4kgVcPgHlcXiWAjoVxGd8QCmvM5VU+YM71pFbn0E= -github.com/gophercloud/gophercloud/v2 v2.7.0/go.mod h1:Ki/ILhYZr/5EPebrPL9Ej+tUg4lqx71/YH2JWVeU+Qk= +github.com/gophercloud/gophercloud/v2 v2.8.0 h1:of2+8tT6+FbEYHfYC8GBu8TXJNsXYSNm9KuvpX7Neqo= +github.com/gophercloud/gophercloud/v2 v2.8.0/go.mod h1:Ki/ILhYZr/5EPebrPL9Ej+tUg4lqx71/YH2JWVeU+Qk= golang.org/x/sys v0.35.0 h1:vz1N37gP5bs89s7He8XuIYXpyY0+QlsKmzipCbUtyxI= golang.org/x/sys v0.35.0/go.mod h1:BJP2sWEmIv4KK5OTEluFJCKSidICx8ciO85XgH3Ak8k= golang.org/x/text v0.28.0 h1:rhazDwis8INMIwQ4tpjLDzUhx6RlXqZNPEM0huQojng= diff --git a/openstack/objectstorage/v1/objects/testing/fixtures.go b/openstack/objectstorage/v1/objects/testing/fixtures.go index ef99cfe..f2ac7ed 100644 --- a/openstack/objectstorage/v1/objects/testing/fixtures.go +++ b/openstack/objectstorage/v1/objects/testing/fixtures.go @@ -64,8 +64,8 @@ var expectedMultipartManifest = []objects.Manifest{ // HandleDownloadManifestSuccessfully creates an HTTP handler at // `/testContainer/testObject` on the test handler mux that responds with a // Download response. -func HandleDownloadManifestSuccessfully(t *testing.T) { - th.Mux.HandleFunc("/testContainer/testObject", func(w http.ResponseWriter, r *http.Request) { +func HandleDownloadManifestSuccessfully(t *testing.T, fakeServer th.FakeServer) { + fakeServer.Mux.HandleFunc("/testContainer/testObject", func(w http.ResponseWriter, r *http.Request) { th.TestMethod(t, r, "GET") th.TestHeader(t, r, "X-Auth-Token", fake.TokenID) th.TestHeader(t, r, "Accept", "application/json") diff --git a/openstack/objectstorage/v1/objects/testing/manifest_test.go b/openstack/objectstorage/v1/objects/testing/manifest_test.go index dde5f56..7784b12 100644 --- a/openstack/objectstorage/v1/objects/testing/manifest_test.go +++ b/openstack/objectstorage/v1/objects/testing/manifest_test.go @@ -42,15 +42,15 @@ func TestMultipartManifest(t *testing.T) { } func TestChunkData(t *testing.T) { - th.SetupHTTP() - defer th.TeardownHTTP() - HandleDownloadManifestSuccessfully(t) + fakeServer := th.SetupHTTP() + defer fakeServer.Teardown() + HandleDownloadManifestSuccessfully(t, fakeServer) downloadOpts := o.DownloadOpts{ MultipartManifest: "get", } - res := o.Download(context.TODO(), fake.ServiceClient(), "testContainer", "testObject", downloadOpts) + res := o.Download(context.TODO(), fake.ServiceClient(fakeServer), "testContainer", "testObject", downloadOpts) defer res.Body.Close() th.AssertNoErr(t, res.Err) @@ -67,7 +67,7 @@ func TestChunkData(t *testing.T) { StaticLargeObject: true, } - actualChunkData, err := objects.GetManifest(context.TODO(), fake.ServiceClient(), gmo) + actualChunkData, err := objects.GetManifest(context.TODO(), fake.ServiceClient(fakeServer), gmo) th.AssertNoErr(t, err) th.AssertDeepEquals(t, actualChunkData, expectedMultipartManifest) }