-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Issue Description
Current Situation
The Goverhaul GitHub Action currently uses a Docker-based implementation, which has several drawbacks:
- Slower execution due to Docker build time
- Higher resource usage from Docker overhead
- More complex implementation requiring Dockerfile and entrypoint script
- Potential compatibility issues across different GitHub Actions runners
Proposed Solution
Replace the current Docker-based implementation with a direct binary release approach:
- Modify
action.ymlto use a composite action instead of Docker - Add steps to download the Goverhaul binary release directly
- Remove
Dockerfileandentrypoint.shas they will no longer be needed - Update documentation to reflect the new implementation
Benefits
- Faster execution: Eliminating Docker build time will result in quicker action runs
- Reduced resource usage: Removing Docker overhead means more efficient resource utilization
- Simpler implementation: Direct binary execution simplifies the codebase
- Better compatibility: Works more consistently across different GitHub Actions runners
Implementation Notes
The implementation would require:
- Changing the
runssection inaction.ymlfromusing: 'docker'tousing: 'composite' - Adding steps to download and execute the Goverhaul binary directly
- Ensuring all inputs (
path,config,verbose) continue to function as expected - Updating documentation to reflect the new approach
This change would maintain full backward compatibility with existing workflows while providing a more efficient implementation.
Questions
- What is the latest stable binary release version we should target?
- Should we support multiple platforms or focus on the common GitHub Actions environments?
- Are there any specific performance benchmarks we want to achieve?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels