fix(spx-gui): fix update checker false positive caused by weak ETag prefix (#2979)

* fix update checker false positive caused by weak ETag prefix

* remove redundant trim

Co-authored-by: xgopilot[bot] <231223108+xgopilot[bot]@users.noreply.github.com>

---------

Co-authored-by: xgopilot[bot] <231223108+xgopilot[bot]@users.noreply.github.com>

Author: cn0809

spx-gui/src/components/app/update-check/update-checker.test.ts

@@ -124,6 +124,52 @@ describe('update-checker', () => {
         cache: 'no-cache'
       })
     })
+
+    it('should treat weak etag with W/ prefix as unchanged', async () => {
+      const strongEtag = '"abc123"'
+      const weakEtag = 'W/"abc123"'
+
+      global.fetch = vi.fn().mockResolvedValue({
+        ok: true,
+        headers: {
+          get: (key: string) => (key === 'etag' ? strongEtag : null)
+        }
+      })
+      await checker.checkForUpdates()
+
+      global.fetch = vi.fn().mockResolvedValue({
+        ok: true,
+        headers: {
+          get: (key: string) => (key === 'etag' ? weakEtag : null)
+        }
+      })
+
+      const hasUpdate = await checker.checkForUpdates()
+      expect(hasUpdate).toBe(false)
+    })
+
+    it('should detect update when weak etag value changes', async () => {
+      const oldWeakEtag = 'W/"abc123"'
+      const newWeakEtag = 'W/"def456"'
+
+      global.fetch = vi.fn().mockResolvedValue({
+        ok: true,
+        headers: {
+          get: (key: string) => (key === 'etag' ? oldWeakEtag : null)
+        }
+      })
+      await checker.checkForUpdates()
+
+      global.fetch = vi.fn().mockResolvedValue({
+        ok: true,
+        headers: {
+          get: (key: string) => (key === 'etag' ? newWeakEtag : null)
+        }
+      })
+
+      const hasUpdate = await checker.checkForUpdates()
+      expect(hasUpdate).toBe(true)
+    })
   })
 
   describe('start', () => {

spx-gui/src/components/app/update-check/update-checker.ts

@@ -18,6 +18,12 @@ export class UpdateChecker {
   private updateCheckTimer: ReturnType<typeof setInterval> | null = null
   private currentEtag: string | null = null
 
+  /** Normalizes ETag values by removing weak validator prefix and trimming whitespace */
+  private normalizeEtag(etag: string): string {
+    const trimmed = etag.trim()
+    return trimmed.startsWith('W/') ? trimmed.slice(2) : trimmed
+  }
+
   /**
    * Checks if there is a new version of the application available
    *
@@ -37,9 +43,10 @@ export class UpdateChecker {
       throw new Error('ETag header not found')
     }
 
-    const hasUpdate = this.currentEtag != null && this.currentEtag !== etag
+    const normalizedEtag = this.normalizeEtag(etag)
+    const hasUpdate = this.currentEtag != null && this.currentEtag !== normalizedEtag
     // Initialize currentEtag on first check
-    if (this.currentEtag == null) this.currentEtag = etag
+    if (this.currentEtag == null) this.currentEtag = normalizedEtag
     return hasUpdate
   }